[GitHub] [couchdb-fauxton] mharrigan26 opened a new pull request, #1409: [Bug fix] Set a default value for local database source/target for New Replications

2023-08-07 Thread via GitHub
mharrigan26 opened a new pull request, #1409: URL: https://github.com/apache/couchdb-fauxton/pull/1409 ## Overview When `Local database` is selected as the source/target for a new replication, set the internal value of `localSource/localTarget` to the first database

[GitHub] [couchdb] nickva opened a new issue, #4723: Update docs to describe how to install on CIS hardened ubuntu

2023-08-07 Thread via GitHub
nickva opened a new issue, #4723: URL: https://github.com/apache/couchdb/issues/4723 From Slack thread: EC2 instance with CIS Hardened (AMI ami-09bc4918bb796a43a) ``` NAME="Ubuntu" VERSION="18.04.6 LTS (Bionic Beaver)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu

[Jenkins] SUCCESS: CouchDB » Full Platform Builds » main #814

2023-08-07 Thread Apache Jenkins Server
Yay, we passed. https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/main/814/display/redirect

[GitHub] [couchdb] nickva merged pull request #4722: Fix badmatch error when purge requests time out

2023-08-07 Thread via GitHub
nickva merged PR #4722: URL: https://github.com/apache/couchdb/pull/4722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva opened a new pull request, #4722: Fix badmatch error when purge requests time out

2023-08-07 Thread via GitHub
nickva opened a new pull request, #4722: URL: https://github.com/apache/couchdb/pull/4722 Previously, if some workers responded, and some timed-out, fabric_doc_purge would throw a badmatch error, as it mistakenly expected the set of worker_uuids to match the initial set of worker_uuids.

[GitHub] [couchdb] rnewson commented on pull request #4718: enhance smoosh to cleanup search indexes when ddocs change

2023-08-07 Thread via GitHub
rnewson commented on PR #4718: URL: https://github.com/apache/couchdb/pull/4718#issuecomment-1668145671 that's an excellent point, we must ensure that cannot happen, at least not with any higher probability than the existing cleanup code for mrview. -- This is an automated message from

[GitHub] [couchdb] nickva commented on pull request #4718: enhance smoosh to cleanup search indexes when ddocs change

2023-08-07 Thread via GitHub
nickva commented on PR #4718: URL: https://github.com/apache/couchdb/pull/4718#issuecomment-1668066441 Overall this looks like what we would want to happen: as soon as we update the ddoc we can clean up the old index data. With the ddoc trigger one thing I was worried about is the

[GitHub] [couchdb] nickva commented on a diff in pull request #4718: enhance smoosh to cleanup search indexes when ddocs change

2023-08-07 Thread via GitHub
nickva commented on code in PR #4718: URL: https://github.com/apache/couchdb/pull/4718#discussion_r1286023989 ## src/smoosh/src/smoosh_server.erl: ## @@ -342,6 +345,8 @@ find_channel(#state{} = State, [Channel | Rest], Object) -> find_channel(State, Rest, Object)

[GitHub] [couchdb] nickva closed pull request #4719: Add extra nouveau purge tests with conflicts

2023-08-07 Thread via GitHub
nickva closed pull request #4719: Add extra nouveau purge tests with conflicts URL: https://github.com/apache/couchdb/pull/4719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [couchdb] janl commented on a diff in pull request #4673: Per document access control

2023-08-07 Thread via GitHub
janl commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1285935495 ## src/couch/src/couch_httpd_auth.erl: ## @@ -199,7 +206,7 @@ proxy_auth_user(Req) -> Roles = case header_value(Req, XHeaderRoles) of

[GitHub] [couchdb] janl commented on a diff in pull request #4673: Per document access control

2023-08-07 Thread via GitHub
janl commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1285934675 ## src/couch/src/couch_db.erl: ## @@ -769,6 +787,64 @@ security_error_type(#user_ctx{name = null}) -> security_error_type(#user_ctx{name = _}) -> forbidden.

[GitHub] [couchdb] janl commented on a diff in pull request #4673: Per document access control

2023-08-07 Thread via GitHub
janl commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1285934675 ## src/couch/src/couch_db.erl: ## @@ -769,6 +787,64 @@ security_error_type(#user_ctx{name = null}) -> security_error_type(#user_ctx{name = _}) -> forbidden.

[GitHub] [couchdb] janl commented on a diff in pull request #4673: Per document access control

2023-08-07 Thread via GitHub
janl commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1285933876 ## src/couch/src/couch_httpd_auth.erl: ## @@ -98,6 +98,13 @@ basic_name_pw(Req) -> nil end. +extract_roles(UserProps) -> +Roles =

[GitHub] [couchdb] rnewson commented on a diff in pull request #4673: Per document access control

2023-08-07 Thread via GitHub
rnewson commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1285854728 ## src/chttpd/src/chttpd_db.erl: ## @@ -1967,6 +1972,21 @@ parse_shards_opt("placement", Req, Default) -> throw({bad_request, Err})

[Jenkins] SUCCESS: CouchDB » Full Platform Builds » main #813

2023-08-07 Thread Apache Jenkins Server
Yay, we passed. https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/main/813/display/redirect

[GitHub] [couchdb] janl commented on pull request #4673: Per document access control

2023-08-07 Thread via GitHub
janl commented on PR #4673: URL: https://github.com/apache/couchdb/pull/4673#issuecomment-1667546917 latest push fixes compiler warnings noted by Jay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [couchdb] rnewson merged pull request #4721: Update README.md

2023-08-07 Thread via GitHub
rnewson merged PR #4721: URL: https://github.com/apache/couchdb/pull/4721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] janl commented on pull request #4673: Per document access control

2023-08-07 Thread via GitHub
janl commented on PR #4673: URL: https://github.com/apache/couchdb/pull/4673#issuecomment-1667483112 > Currently this PR has no description, and I wonder if you could add some high level documentation of how this works, or maybe link to an architectural document? sorry for not

[GitHub] [couchdb] janl commented on pull request #4673: Per document access control

2023-08-07 Thread via GitHub
janl commented on PR #4673: URL: https://github.com/apache/couchdb/pull/4673#issuecomment-1667485441 > I also noticed a few TODO and other comments that I'm guessing need to still be addressed or removed? thanks and yes, these are all minor or already resolved, but not cleaned up