[GitHub] [couchdb] fr2lancer opened a new issue, #4733: file copy of .couch from 2.x isn't picked up by couchdb 3.3.2

2023-08-17 Thread via GitHub
fr2lancer opened a new issue, #4733: URL: https://github.com/apache/couchdb/issues/4733 [NOTE]: # file copy of .couch from 2.x isn't picked up by couchdb 3.3.2 ## Description Simple I copied one of .couch file to couchdb 3.3.2 GET '127.0.0.1:5984/ -> no database error

[GitHub] [couchdb] nickva commented on a diff in pull request #4729: Fabric workers should exit if the client exits

2023-08-17 Thread via GitHub
nickva commented on code in PR #4729: URL: https://github.com/apache/couchdb/pull/4729#discussion_r1297875425 ## rel/haproxy.cfg: ## @@ -25,9 +25,9 @@ defaults option redispatch retries 4 option http-server-close -timeout client 15 -

[GitHub] [couchdb] nickva commented on pull request #4718: enhance smoosh to cleanup search indexes when ddocs change

2023-08-17 Thread via GitHub
nickva commented on PR #4718: URL: https://github.com/apache/couchdb/pull/4718#issuecomment-1683131792 > that's an excellent point, we must ensure that cannot happen, at least not with any higher probability than the existing cleanup code for mrview. We could punt changing the

[GitHub] [couchdb] nickva commented on a diff in pull request #4718: enhance smoosh to cleanup search indexes when ddocs change

2023-08-17 Thread via GitHub
nickva commented on code in PR #4718: URL: https://github.com/apache/couchdb/pull/4718#discussion_r1297859281 ## src/fabric/src/fabric.erl: ## @@ -590,25 +590,38 @@ cleanup_index_files(DbName) -> cleanup_local_indices_and_purge_checkpoints([]) -> ok;

[Jenkins] FAILURE: CouchDB » Full Platform Builds » main #817

2023-08-17 Thread Apache Jenkins Server
Boo, we failed. https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/main/817/display/redirect

[GitHub] [couchdb] nickva commented on pull request #4726: Unlock build using Elixir 1.15

2023-08-17 Thread via GitHub
nickva commented on PR #4726: URL: https://github.com/apache/couchdb/pull/4726#issuecomment-1682446731 Thanks for fixing it @jjrodrig! I did notice in the last main full CI build for .deb packages failed to build with this error:

[GitHub] [couchdb] janl commented on a diff in pull request #4673: Per document access control

2023-08-17 Thread via GitHub
janl commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1296848122 ## src/couch/src/couch_db.erl: ## @@ -1330,13 +1411,41 @@ update_docs(Db, Docs0, Options, ?REPLICATED_CHANGES) -> ] || Bucket <- DocBuckets ], -

[GitHub] [couchdb] janl commented on a diff in pull request #4673: Per document access control

2023-08-17 Thread via GitHub
janl commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1296851094 ## src/couch/src/couch_db_updater.erl: ## @@ -294,12 +304,12 @@ collect_updates(GroupedDocsAcc, ClientsAcc, ReplicatedChanges) -> % local docs. It's easier to

[GitHub] [couchdb] janl commented on a diff in pull request #4673: Per document access control

2023-08-17 Thread via GitHub
janl commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1296850568 ## src/couch/src/couch_db.erl: ## @@ -1458,23 +1567,29 @@ collect_results(Pid, MRef, ResultsAcc) -> end. write_and_commit( -#db{main_pid = Pid, user_ctx =

[GitHub] [couchdb] janl commented on a diff in pull request #4673: Per document access control

2023-08-17 Thread via GitHub
janl commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1296848122 ## src/couch/src/couch_db.erl: ## @@ -1330,13 +1411,41 @@ update_docs(Db, Docs0, Options, ?REPLICATED_CHANGES) -> ] || Bucket <- DocBuckets ], -

[GitHub] [couchdb] janl commented on a diff in pull request #4673: Per document access control

2023-08-17 Thread via GitHub
janl commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1296845740 ## src/couch/src/couch_db.erl: ## @@ -769,6 +787,64 @@ security_error_type(#user_ctx{name = null}) -> security_error_type(#user_ctx{name = _}) -> forbidden.

[GitHub] [couchdb] janl commented on a diff in pull request #4673: Per document access control

2023-08-17 Thread via GitHub
janl commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1296843937 ## src/couch/src/couch_db.erl: ## @@ -302,17 +312,23 @@ open_doc(Db, Id, Options) -> {ok, #doc{deleted = true} = Doc} -> case lists:member(deleted,

[GitHub] [couchdb] janl commented on a diff in pull request #4673: Per document access control

2023-08-17 Thread via GitHub
janl commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1296837886 ## src/couch/src/couch_access_native_proc.erl: ## @@ -0,0 +1,139 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use this file except

[GitHub] [couchdb] janl commented on a diff in pull request #4673: Per document access control

2023-08-17 Thread via GitHub
janl commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1296837073 ## src/chttpd/src/chttpd_db.erl: ## @@ -1967,6 +1972,21 @@ parse_shards_opt("placement", Req, Default) -> throw({bad_request, Err}) end

[GitHub] [couchdb] janl commented on a diff in pull request #4673: Per document access control

2023-08-17 Thread via GitHub
janl commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1296826112 ## src/chttpd/src/chttpd_db.erl: ## @@ -1967,6 +1972,21 @@ parse_shards_opt("placement", Req, Default) -> throw({bad_request, Err}) end

[GitHub] [couchdb] janl commented on a diff in pull request #4673: Per document access control

2023-08-17 Thread via GitHub
janl commented on code in PR #4673: URL: https://github.com/apache/couchdb/pull/4673#discussion_r1296823297 ## src/chttpd/src/chttpd_db.erl: ## @@ -958,16 +958,18 @@ view_cb(Msg, Acc) -> couch_mrview_http:view_cb(Msg, Acc). db_doc_req(#httpd{method = 'DELETE'} = Req,