Re: [PR] mango: add $beginsWith operator [couchdb]

pgj commented on PR #4810: URL: https://github.com/apache/couchdb/pull/4810#issuecomment-1790228128 Thanks @nickva! I will experiment with the options you described above and get back to you with the results. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] mango: add $beginsWith operator [couchdb]

willholley commented on PR #4810: URL: https://github.com/apache/couchdb/pull/4810#issuecomment-1790366824 thanks @nickva - this solution looks good in my tests using the CentoOS container -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[PR] mango: fix $beginsWith range [couchdb]

willholley opened a new pull request, #4828: URL: https://github.com/apache/couchdb/pull/4828 ## Overview In the initial implementation of $beginsWith, the range calculation for view indexes mistakenly appends an integer with the size of 8 bits which gets maxed out at FF, rather than bui

Re: [PR] mango: fix $beginsWith range [couchdb]

pgj commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1379838747 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWith"

Re: [PR] mango: fix $beginsWith range [couchdb]

pgj commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1379843635 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWith"

Re: [PR] mango: fix $beginsWith range [couchdb]

willholley commented on PR #4828: URL: https://github.com/apache/couchdb/pull/4828#issuecomment-1790448696 @pgj I'm trying to think where it would make sense to add unit tests for non-UTF8 data. There are no existing eunit tests for `field_ranges` or `range` (perhaps we add some?) and I don

Re: [PR] mango: fix $beginsWith range [couchdb]

pgj commented on PR #4828: URL: https://github.com/apache/couchdb/pull/4828#issuecomment-1790482735 If you implement the pre-check that I suggested then it can be established for `mango_idx_view:range/5` that the input will always be a valid UTF-8 input hence no tests are needed. The requi

Re: [PR] do-not-merge(`mango`): fix derivation of upper bound for the range of `$beginsWith` [couchdb]

pgj commented on PR #4829: URL: https://github.com/apache/couchdb/pull/4829#issuecomment-1790508697 @willholley FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] mango: fix $beginsWith range [couchdb]

willholley commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1379933225 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$begi

Re: [PR] Add Debian Bookworm [couchdb-ci]

pgj commented on code in PR #58: URL: https://github.com/apache/couchdb-ci/pull/58#discussion_r1379953990 ## bin/apt-dependencies.sh: ## @@ -172,6 +171,9 @@ if [ "$1" != "nojs" ]; then if [ "${VERSION_CODENAME}" == "bullseye" ]; then apt-get install --no-install-recommen

Re: [PR] Add Debian Bookworm [couchdb-ci]

pgj commented on PR #58: URL: https://github.com/apache/couchdb-ci/pull/58#issuecomment-1790547333 I think it is still worth to make explicit that support for Debian Jessie is removed at the same time. -- This is an automated message from the Apache Git Service. To respond to the message,

[Jenkins] SUCCESS: CouchDB » Full Platform Builds » jenkins-test-mango-beginswith #1

Yay, we passed. https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/jenkins-test-mango-beginswith/1/display/redirect

Re: [PR] mango: add $beginsWith operator [couchdb]

pgj commented on PR #4810: URL: https://github.com/apache/couchdb/pull/4810#issuecomment-1790609445 > Even better, since unicode standard seems to define a max sortable code point `U+`, we should use that instead of `U+10`. Erlang itself supports `U+10` and it is numerical

Re: [PR] Add Debian Bookworm [couchdb-ci]

big-r81 commented on code in PR #58: URL: https://github.com/apache/couchdb-ci/pull/58#discussion_r1380049786 ## bin/apt-dependencies.sh: ## @@ -172,6 +171,9 @@ if [ "$1" != "nojs" ]; then if [ "${VERSION_CODENAME}" == "bullseye" ]; then apt-get install --no-install-reco

Re: [PR] Decouple offline hash strength from online [couchdb]

rnewson commented on PR #4814: URL: https://github.com/apache/couchdb/pull/4814#issuecomment-179079 sorry, I've modified this yet again. Notably I increase the default iterations to 50,000. I override this in a test to avoid adding a timer:sleep hack. I changed needs_upgrade to _

Re: [PR] mango: fix $beginsWith range [couchdb]

willholley commented on PR #4828: URL: https://github.com/apache/couchdb/pull/4828#issuecomment-1790827914 @pgj updated as per #4829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] snapcraft now runs ./configure with --prefix [couchdb-pkg]

sklassen closed pull request #80: snapcraft now runs ./configure with --prefix URL: https://github.com/apache/couchdb-pkg/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Add Debian Bookworm [couchdb-ci]

pgj commented on code in PR #58: URL: https://github.com/apache/couchdb-ci/pull/58#discussion_r1380461322 ## bin/apt-dependencies.sh: ## @@ -172,6 +171,9 @@ if [ "$1" != "nojs" ]; then if [ "${VERSION_CODENAME}" == "bullseye" ]; then apt-get install --no-install-recommen

Re: [PR] mango: fix $beginsWith range [couchdb]

pgj commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380459255 ## src/mango/src/mango_selector.erl: ## @@ -1070,12 +1073,17 @@ check_beginswith(Field, Prefix) -> match_beginswith_test() -> % matching ?assertEqual(true, check

Re: [PR] mango: fix $beginsWith range [couchdb]

nickva commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380586593 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWi

Re: [PR] mango: fix $beginsWith range [couchdb]

willholley commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380595004 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$begi

Re: [PR] mango: fix $beginsWith range [couchdb]

pgj commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380608148 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWith"

Re: [PR] mango: fix $beginsWith range [couchdb]

pgj commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380608148 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWith"

Re: [PR] mango: fix $beginsWith range [couchdb]

nickva commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380599542 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWi

Re: [PR] mango: fix $beginsWith range [couchdb]

pgj commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380600671 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWith"

Re: [PR] mango: fix $beginsWith range [couchdb]

willholley commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380597426 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$begi

Re: [PR] mango: fix $beginsWith range [couchdb]

willholley commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380595300 ## src/mango/src/mango_selector.erl: ## @@ -1070,12 +1073,17 @@ check_beginswith(Field, Prefix) -> match_beginswith_test() -> % matching ?assertEqual(true

Re: [PR] mango: fix $beginsWith range [couchdb]

pgj commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380599046 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWith"

Re: [PR] mango: fix $beginsWith range [couchdb]

willholley commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380629457 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$begi

[Jenkins] FAILURE: CouchDB » Full Platform Builds » jenkins-test-mango-beginswith #2

Boo, we failed. https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/jenkins-test-mango-beginswith/2/display/redirect

Re: [PR] mango: fix $beginsWith range [couchdb]

nickva commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380652572 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWi

Re: [PR] mango: fix $beginsWith range [couchdb]

nickva commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380599542 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWi

Re: [PR] mango: fix $beginsWith range [couchdb]

pgj commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380662149 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWith"

Re: [PR] mango: fix $beginsWith range [couchdb]

big-r81 commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380667886 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsW

Re: [I] compaction_log_level not working on Couchdb version 3.3.2 [couchdb]

Sdas commented on issue #4815: URL: https://github.com/apache/couchdb/issues/4815#issuecomment-1791409321 After setting compaction logging information , we are still not getting anything in our log for compaction , "log": { "level": "error", "writer": "journald" },

Re: [PR] mango: fix $beginsWith range [couchdb]

pgj commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380675948 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWith"

Re: [PR] mango: fix $beginsWith range [couchdb]

nickva commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380688095 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWi

Re: [I] compaction_log_level not working on Couchdb version 3.3.2 [couchdb]

nickva commented on issue #4815: URL: https://github.com/apache/couchdb/issues/4815#issuecomment-1791442468 That's great @Sdas. Yeah, compaction level has to higher or equal than your log level, otherwise you won't see those messages. So for instance if you set your log level to `warnin

Re: [PR] mango: fix $beginsWith range [couchdb]

big-r81 commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380700798 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsW

Re: [PR] mango: fix $beginsWith range [couchdb]

nickva commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380652572 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWi

Re: [I] compaction_log_level not working on Couchdb version 3.3.2 [couchdb]

Sdas commented on issue #4815: URL: https://github.com/apache/couchdb/issues/4815#issuecomment-1791461071 if log level is info or warning , we are already getting compaction info without setting compaction_log_level. There no need to set compaction_log_level. Our issue is we want to kee

Re: [PR] mango: fix $beginsWith range [couchdb]

nickva commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380717931 ## src/mango/src/mango_idx_view.erl: ## @@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) -> % beginsWith requires both a high and low bound range({[{<<"$beginsWi

Re: [I] compaction_log_level not working on Couchdb version 3.3.2 [couchdb]

nickva commented on issue #4815: URL: https://github.com/apache/couchdb/issues/4815#issuecomment-1791518288 > Our issue is we want to keep log as "error" and need compaction information by setting compaction_log_level to info or notice See my comment above: https://github.com/apache

[PR] mango: fix $beginsWith range [couchdb]

nickva opened a new pull request, #4830: URL: https://github.com/apache/couchdb/pull/4830 This is a full jenkins runs for the `mango-begingswith-fixes` pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] mango: fix $beginsWith range [couchdb]

pgj commented on PR #4830: URL: https://github.com/apache/couchdb/pull/4830#issuecomment-1791536007 Why is not #4829 enough? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] mango: fix $beginsWith range [couchdb]

nickva commented on PR #4830: URL: https://github.com/apache/couchdb/pull/4830#issuecomment-1791537538 > Why is not #4829 enough? noticed some failures there and was wondering if it just need to be rebased -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] mango: fix $beginsWith range [couchdb]

pgj commented on PR #4830: URL: https://github.com/apache/couchdb/pull/4830#issuecomment-1791569055 Okay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[Jenkins] SUCCESS: CouchDB » Full Platform Builds » jenkins-mango-begingswith-fixes-2 #1

Yay, we passed. https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/jenkins-mango-begingswith-fixes-2/1/display/redirect

Re: [PR] mango: fix $beginsWith range [couchdb]

nickva commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380811414 ## src/mango/src/mango_selector.erl: ## @@ -1070,12 +1073,18 @@ check_beginswith(Field, Prefix) -> match_beginswith_test() -> % matching ?assertEqual(true, ch

Re: [PR] mango: fix $beginsWith range [couchdb]

nickva commented on PR #4828: URL: https://github.com/apache/couchdb/pull/4828#issuecomment-1791577531 Full CI tests passed https://ci-couchdb.apache.org/blue/organizations/jenkins/jenkins-cm1%2FFullPlatformMatrix/detail/jenkins-mango-begingswith-fixes-2/1/pipeline but see the minor test fi

Re: [PR] mango: fix $beginsWith range [couchdb]

nickva closed pull request #4830: mango: fix $beginsWith range URL: https://github.com/apache/couchdb/pull/4830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] mango: fix $beginsWith range [couchdb]

nickva commented on PR #4830: URL: https://github.com/apache/couchdb/pull/4830#issuecomment-1791584258 the build passed! closing the pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] mango: fix $beginsWith range [couchdb]

nickva commented on code in PR #4828: URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380811414 ## src/mango/src/mango_selector.erl: ## @@ -1070,12 +1073,18 @@ check_beginswith(Field, Prefix) -> match_beginswith_test() -> % matching ?assertEqual(true, ch

[PR] Handle Debian 12 Bookworm [couchdb-ci]

sblaisot opened a new pull request, #59: URL: https://github.com/apache/couchdb-ci/pull/59 Add necessary bits to package for Debian 12 Bookworm. Someone with access to CI will neet to take a look at that. This PR has been made blindly with no visibility on repositories and CI.

[PR] Handle Debian 12 Bookworm [couchdb-pkg]

sblaisot opened a new pull request, #116: URL: https://github.com/apache/couchdb-pkg/pull/116 ## Overview Handle Packaging for Debian 12 Bookworm ## Testing recommendations This requires prior merge of https://github.com/apache/couchdb-ci/pull/59 and an access to CI and

Re: [PR] Remove installation via snap package [couchdb]

sblaisot commented on PR #4826: URL: https://github.com/apache/couchdb/pull/4826#issuecomment-1791686692 @big-r81 No sooner said than done. Not for snap package but at least for deb12 packages. This was a 15 minutes job. it is completely ueless because I have no mean to test it without visi

Re: [PR] Remove installation via snap package [couchdb]

big-r81 commented on PR #4826: URL: https://github.com/apache/couchdb/pull/4826#issuecomment-1791959331 > @big-r81 No sooner said than done. Not for snap package but at least for deb12 packages. This was a 15 minutes job. it is completely useless because I have no mean to test it without vi