[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-12 Thread kxepal
Github user kxepal closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-12 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/42#issuecomment-120722319 @rnewson thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-12 Thread rnewson
Github user rnewson commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/42#issuecomment-120722250 fixed by enhancing couch_httpd's json_body function to match chttpd's which checks for undefined and throws a clean 400 bad request. --- If your project is set u

[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-12 Thread rnewson
Github user rnewson commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/42#issuecomment-120720505 thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-12 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/42#issuecomment-120719395 @rnewson ``` $ curl -v -XPOST http://localhost:59840/db/_changes?filter=_doc_ids -H 'Content-Type:application/json' * Trying ::1... * conne

[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-12 Thread rnewson
Github user rnewson commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/42#issuecomment-120717918 vote to close this now apache/couchdb-couch#68 is reverted. Clearly there's a way to get a function_clause error, @jaydoane or @kxepal are you able to ind

[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-12 Thread rnewson
Github user rnewson commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/42#issuecomment-120717799 Reverting apache/couchdb-couch#68 seems to be enough, I'm unable to make a post request that causes the function_clause, can someone explain? --- If your projec

[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-12 Thread rnewson
Github user rnewson commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/42#issuecomment-120715448 Ok, I took a look. I think the right fix is to revert https://github.com/apache/couchdb-couch/pull/68 and but the validating logic right after the original `couch

[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-12 Thread daleharvey
Github user daleharvey commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/42#issuecomment-120702967 Yeh also as mentioned on irc, this fixes the pouchdb test suite that is currently broken with anything that filters by doc_ids --- If your project is set up f

[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-11 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/42#issuecomment-120673633 FWIW, this does seem to fix the problem for me locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-11 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/42#issuecomment-120665181 Ok. I also not sure if this one is correct, but I took [`handle_view_list_req/3`](https://github.com/apache/couchdb-chttpd/blob/master/src/chttpd_show.erl#L170-L172

[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-11 Thread rnewson
Github user rnewson commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/42#issuecomment-120661779 Hrm. Will look in the week. Not sure this is the right fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-11 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/42#issuecomment-120654381 cc @rnewson --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] couchdb-chttpd pull request: Read request body on POST to changes ...

2015-07-11 Thread kxepal
GitHub user kxepal opened a pull request: https://github.com/apache/couchdb-chttpd/pull/42 Read request body on POST to changes feed Prevents to return https://github.com/apache/couchdb-couch/pull/68 error for every POST request. You can merge this pull request into a Git repositor