Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-config/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-175569950
I think +1. Shutdown notices a bit distracting, but that's another story,
not related to this PR.
---
If your project is set up for it, you can reply to this email
Github user nickva commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-175380774
I checked this one against master using this patch
```
-{config, "config",
"84197a6f1c5cb43447239df1fe57b4312b0c03c4"},
+%{conf
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-174659864
@kxepal, @iilyak thought I should reiterate that I can no longer reproduce
the
`2015-11-02 08:31:53.274 [error] Undefined <0.885.0> Supervisor
gr_counter_sup
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-173819593
@kxepal, thank you for reminding me of that change.
I tracked down where the remaining logging is coming from in config_tests,
and was able to remove a li
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-173510292
@jaydoane Trivial: because tests modifies config level and we now let it be
changed in runtime.
https://github.com/apache/couchdb-config/blob/master/test/config
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-173451479
Interestingly, I'm no longer able to reproduce the `[error] Undefined`
errors, although I *am* seeing a lot more logging than before for some reason.
@kxe
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-154503958
I agree that explicitly starting lager is not required for the tests to
pass, but like you pointed out above, not doing so generates a bunch of
supervisor related
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-154493803
@jaydoane haha, thanks, it's better (: I'm still thinking how these changes
correlates with yours in https://github.com/apache/couchdb-couch/pull/126
because it see
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-154492458
@kxepal, if your head is feeling better, I was hoping you could share your
thoughts on my latest approach?
---
If your project is set up for it, you can reply to
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-153906372
@jaydoane my head is going to blow today, will check tomorrow. Thanks for
the update!
---
If your project is set up for it, you can reply to this email and have yo
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-153901692
@kxepal, I've cleaned up the code and added some comments. Please let me
know if this is or is not an acceptable solution.
If not, another approach could
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-153194830
@kxepal, I changed the approach to leave lager in (while removing other
unnecessary deps), and just filtering nonexistent applications.
This patch no long
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-152930791
@jaydoane Because travis config was a little bit outdated. I just updated
it, please rebase for green light.
---
If your project is set up for it, you can reply to
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-152925628
@kxepal, good point - I had not noticed those errors, and had just been
happy that all the tests passed. I wonder if those errors are what's causing
travis to fai
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-152918941
This causes errors during tests run:
```
EUnit
module 'config_app'
module 'config_util'
module '
GitHub user jaydoane opened a pull request:
https://github.com/apache/couchdb-config/pull/7
Don't start lager during setup for each config_test
BugzID: 55507
COUCHDB-2866
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudan
17 matches
Mail list logo
