[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...

2016-08-15 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/45 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...

2016-08-15 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/45 nice catch, reviewing now and should land in RC5 this Thursday if we're good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...

2016-08-15 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/45 Our tests in sad state yeah /: But good that they are green now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...

2016-08-15 Thread nickva
Github user nickva commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/45 @kxepal all green again wondering if there are other small chunks of code we never ran before because of this and those might have bugs hidden too --- If your project is

[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...

2016-08-15 Thread nickva
Github user nickva commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/45 @davisp @rnewson this was a fun one to discover --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...

2016-08-15 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/45 @nickva Good. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...

2016-08-15 Thread nickva
Github user nickva commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/45 @kxepal I have a fix, fixing this bug revealed another one apparently --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...

2016-08-15 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/45 +1. But failed tests worries me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this