[GitHub] couchdb-couch-replicator pull request: Switch replicator manager c...

2016-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-replicator/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] couchdb-couch-replicator pull request: Switch replicator manager c...

2016-03-04 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/30#issuecomment-192491536 Right, I forgot about this moment and get confused by timeout. Thanks! --- If your project is set up for it, you can reply to this email and have your r

[GitHub] couchdb-couch-replicator pull request: Switch replicator manager c...

2016-03-04 Thread nickva
Github user nickva commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/30#issuecomment-192488296 @kxepal Longpolling works because we start the change feed after db has notified that it has changes, so we ask it for all changes since checkpo

[GitHub] couchdb-couch-replicator pull request: Switch replicator manager c...

2016-03-04 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/30#issuecomment-192458539 How they'll eventually exit if timeout is infinity? IIRC longpoll feeds has the only special option to early break when they hit the limit of requested

[GitHub] couchdb-couch-replicator pull request: Switch replicator manager c...

2016-03-04 Thread davisp
Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/30#issuecomment-192455441 I wouldn't bother adding that to the commit message. That's just for a historical note to explain the background of the PR. The commit message is clear

[GitHub] couchdb-couch-replicator pull request: Switch replicator manager c...

2016-03-04 Thread davisp
Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/30#issuecomment-192455095 +1 I'd also note that the fact its continuous in the first place looks to be a bad merge from when we ported the clustered version of the replicator back

[GitHub] couchdb-couch-replicator pull request: Switch replicator manager c...

2016-03-04 Thread nickva
GitHub user nickva opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/30 Switch replicator manager change feeds to "longpoll" Fixes replication manager rescans on cluster membership change. Replication manager resets all replication db seq