[GitHub] couchdb-couch issue #193: Fix validation for ddoc and _local id

2016-09-01 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/193 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] couchdb-couch issue #193: Fix validation for ddoc and _local id

2016-09-01 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-couch/pull/193 try ```erlang <<"_design/", Rest/binary>> when byte_size(Rest) > 0 -> ok ``` That way we only say the _design and _local rule once each. anything else beginning _ will hit

[GitHub] couchdb-couch issue #193: Fix validation for ddoc and _local id

2016-09-01 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-couch/pull/193 hm, there must be a better way. we now have two bits of special logic in the same function for the same reason. --- If your project is set up for it, you can reply to this email and have your

[GitHub] couchdb-couch issue #193: Fix validation for ddoc and _local id

2016-09-01 Thread eiri
Github user eiri commented on the issue: https://github.com/apache/couchdb-couch/pull/193 @rnewson I did it at first, but then decided to go with less confusing error message for the users sake. If you think it's not a problem here then sure, I'll use guards. --- If your project is

[GitHub] couchdb-couch issue #193: Fix validation for ddoc and _local id

2016-09-01 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-couch/pull/193 hrm, fair enough. I can't see a tidier way to say it once but still give good error messages. +1. --- If your project is set up for it, you can reply to this email and have your repl