Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/115#issuecomment-146275519
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user iilyak commented on the pull request:
https://github.com/apache/couchdb-couch/pull/115#issuecomment-146250492
I'll revert the UUID change and squash for final review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/115#issuecomment-146244135
+1 after reverting the uuid change. the original names were fine for
uniqueness, the issue was the assumption that the test runs within one second
(it would fail
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/115#discussion_r41408779
--- Diff: src/couch_server.erl ---
@@ -538,20 +540,31 @@ db_closed(Server, Options) ->
true -> Server
end.
-delete_db_fi
Github user iilyak commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/115#discussion_r41401845
--- Diff: src/couch_server.erl ---
@@ -549,9 +554,13 @@ delete_db_file(RootDir, FullFilePath, Options) ->
end.
rename_on_delete(Origi
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/115#discussion_r41382938
--- Diff: src/couch_server.erl ---
@@ -549,9 +554,13 @@ delete_db_file(RootDir, FullFilePath, Options) ->
end.
rename_on_delete(Orig
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/115#discussion_r41280523
--- Diff: src/couch_server.erl ---
@@ -549,9 +554,12 @@ delete_db_file(RootDir, FullFilePath, Options) ->
end.
rename_on_delete(Origi
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/115#issuecomment-145903047
+1, and nice cleanup of a cut-and-paste in the test. The assumption that
the rename takes less than one second predates your change but it would be nice
to get ri
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-couch/pull/115
Export delete file
In order to support `rename_on_delete` semantics for views. We want to
reuse `couch_server:delete_file` in couch_mrview_cleanup.
You can merge this pull request into a Git
10 matches
Mail list logo
