[GitHub] davisp commented on issue #496: Couchdb 3287 pluggable storage engines

davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-369270935 Last rebase. Will merge once CI comes back green. This is an automated message from

[GitHub] davisp commented on issue #496: Couchdb 3287 pluggable storage engines

davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-367357591 Has anyone got any reason for me to not merge this in 72h or whenever? I've rebased it against master and its passing CI checks. As far as I

[GitHub] davisp commented on issue #496: Couchdb 3287 pluggable storage engines

davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-314139670 For more color since I was talking to @garrensmith off list about his work on couch_rocks, those two places are a bit rough because I wanted to

[GitHub] davisp commented on issue #496: Couchdb 3287 pluggable storage engines

davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-311163050 Looks like not because it doesn't appear to exist in 17.x On Mon, Jun 26, 2017 at 8:11 AM, garren smith wrote:

[GitHub] davisp commented on issue #496: Couchdb 3287 pluggable storage engines

davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-304971908 @tonysun83 @eiri I've fixed up the input validation for invalid engines and added a log statement for when the default engine isn't set to an

[GitHub] davisp commented on issue #496: Couchdb 3287 pluggable storage engines

davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-302760914 Aha! Good catch. On Fri, May 19, 2017 at 11:06 AM, Eric Avdey wrote: > *@eiri* commented on this pull

[GitHub] davisp commented on issue #496: Couchdb 3287 pluggable storage engines

davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-302251567 @tonysun83 Hrm, I'll add a test for that case and try and track down what's causing the 500's with the bad engine. For that and for the replicator

[GitHub] davisp commented on issue #496: Couchdb 3287 pluggable storage engines

davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-302130228 @tonysun83 The shard's db info blob should include the engine, however this wasn't included in the clustered db info because I had originally had

[GitHub] davisp commented on issue #496: Couchdb 3287 pluggable storage engines

davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-30130 Rebased. Forgot to push earlier. Just have that one function I'm not sure about where it went. I'm guessing the couch_server revert but will have to

[GitHub] davisp commented on issue #496: Couchdb 3287 pluggable storage engines

davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-299222303 Awesome, thanks for the notes @garrensmith! This is an automated message from the

[GitHub] davisp commented on issue #496: Couchdb 3287 pluggable storage engines

davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-297745272 Also, I forgot to link out to the first complete alternative storage engines. https://github.com/cloudant/couch_ngen The couch_ngen

[GitHub] davisp commented on issue #496: Couchdb 3287 pluggable storage engines

davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-297741300 Also for documentation I'm not sure what we want to do there. Should I open a PR for the docs now or should we wait and let this soak on master and