[GitHub] tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query

2017-07-13 Thread git
tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query URL: https://github.com/apache/couchdb/pull/627#issuecomment-315130740 +1 This is an automated message from the Apache Git Service. To res

[GitHub] tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query

2017-07-10 Thread git
tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query URL: https://github.com/apache/couchdb/pull/627#issuecomment-314259028 @eiri @nickva : The source looks good to me. The tests also pass for me. If there's a better pythonic way to combine the two new test

[GitHub] tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query

2017-07-03 Thread git
tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query URL: https://github.com/apache/couchdb/pull/627#issuecomment-312680336 Also, we would probably want to check what happens if users created a mango text index as well. ---

[GitHub] tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query

2017-07-03 Thread git
tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query URL: https://github.com/apache/couchdb/pull/627#issuecomment-312679369 I think we wanted to convert the mango test framework over to eunit at some point. It's become such a clunky thing. I guess we could

[GitHub] tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query

2017-07-02 Thread git
tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query URL: https://github.com/apache/couchdb/pull/627#issuecomment-312542128 The only thing that confuses me here a bit is that the original bug poster mentioned he created a index on id and name field. The err

[GitHub] tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query

2017-07-02 Thread git
tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query URL: https://github.com/apache/couchdb/pull/627#issuecomment-312542128 The only thing that confuses me here a bit is that the original bug poster mentioned he created a index on id and name field. The err

[GitHub] tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query

2017-07-02 Thread git
tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query URL: https://github.com/apache/couchdb/pull/627#issuecomment-312540347 @eiri : The source looks good, but would it be possible to add a test to the python suite that queries the _users db for sanity? --

[GitHub] tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query

2017-07-02 Thread git
tonysun83 commented on issue #627: Pass UserCtx to fabric's all_docs from mango query URL: https://github.com/apache/couchdb/pull/627#issuecomment-312540347 @eiri : The source looks good, but would it be possible to add a test to the python suite that queries the _users db for sanity? --