nickva merged PR #5036:
URL: https://github.com/apache/couchdb/pull/5036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nickva commented on code in PR #5036:
URL: https://github.com/apache/couchdb/pull/5036#discussion_r1577941884
##
src/couch_replicator/src/couch_replicator_scheduler.erl:
##
@@ -623,28 +627,20 @@ start_job_int(#job{pid = Pid}, _State) when Pid /=
undefined ->
ok;
rnewson commented on code in PR #5036:
URL: https://github.com/apache/couchdb/pull/5036#discussion_r1577415538
##
src/couch_replicator/src/couch_replicator_scheduler.erl:
##
@@ -623,28 +627,20 @@ start_job_int(#job{pid = Pid}, _State) when Pid /=
undefined ->
ok;
nickva commented on code in PR #5036:
URL: https://github.com/apache/couchdb/pull/5036#discussion_r1577252745
##
src/couch_replicator/src/couch_replicator_job_sup.erl:
##
@@ -1,34 +0,0 @@
-% Licensed under the Apache License, Version 2.0 (the "License"); you may not
Review
nickva opened a new pull request, #5036:
URL: https://github.com/apache/couchdb/pull/5036
Use the scheduler as the job supervisor, since the scheduler is already a
fancy supervisor, with its own backoff logic, process monitoring, etc.
This simplifies the job starting/stopping logic
