Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1587028297 ## bin/shell.ps1: ## @@ -33,6 +33,7 @@ $env:PATH += ";${elxInstallPath}\bin" $env:PATH += ";${vcpkgBase}\bin" $env:PATH += ";C:\Program Files (x86)\WiX Toolset

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva merged PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Investigate using QuickJS as a Javascript Engine [couchdb]

2024-05-01 Thread via GitHub
nickva commented on issue #4448: URL: https://github.com/apache/couchdb/issues/4448#issuecomment-2089147124 As discussed in one of the CouchDB dev meetings, the last two required features for https://github.com/apache/couchdb/pull/4627 support were: 1) Windows support 2) A way to

Re: [PR] Add QuickJS as a Javascript engine option [couchdb]

2024-05-01 Thread via GitHub
nickva commented on PR #4627: URL: https://github.com/apache/couchdb/pull/4627#issuecomment-2089141941 After another update ready for review: * Added Windows support using MSYS2 glazier [PR](https://github.com/apache/couchdb-glazier/pull/32) * A

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586814081 ## bin/shell.ps1: ## @@ -33,6 +33,7 @@ $env:PATH += ";${elxInstallPath}\bin" $env:PATH += ";${vcpkgBase}\bin" $env:PATH += ";C:\Program Files (x86)\WiX Toolset

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586661597 ## bin/install_dependencies.ps1: ## @@ -34,6 +36,11 @@ if (Test-Path($ChocolateyProfile)) { } refreshenv +Write-Output " * Seting up MSYS *** " Review

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586658315 ## bin/install_dependencies.ps1: ## @@ -34,6 +36,11 @@ if (Test-Path($ChocolateyProfile)) { } refreshenv +Write-Output " * Seting up MSYS *** " Review

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586657681 ## bin/shell.ps1: ## @@ -33,6 +33,7 @@ $env:PATH += ";${elxInstallPath}\bin" $env:PATH += ";${vcpkgBase}\bin" $env:PATH += ";C:\Program Files (x86)\WiX Toolset

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
big-r81 commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586646945 ## bin/shell.ps1: ## @@ -33,6 +33,7 @@ $env:PATH += ";${elxInstallPath}\bin" $env:PATH += ";${vcpkgBase}\bin" $env:PATH += ";C:\Program Files (x86)\WiX Toolset

[PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva opened a new pull request, #32: URL: https://github.com/apache/couchdb-glazier/pull/32 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,