Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1587028297 ## bin/shell.ps1: ## @@ -33,6 +33,7 @@ $env:PATH += ";${elxInstallPath}\bin" $env:PATH += ";${vcpkgBase}\bin" $env:PATH += ";C:\Program Files (x86)\WiX Toolset

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva merged PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586814081 ## bin/shell.ps1: ## @@ -33,6 +33,7 @@ $env:PATH += ";${elxInstallPath}\bin" $env:PATH += ";${vcpkgBase}\bin" $env:PATH += ";C:\Program Files (x86)\WiX Toolset

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586661597 ## bin/install_dependencies.ps1: ## @@ -34,6 +36,11 @@ if (Test-Path($ChocolateyProfile)) { } refreshenv +Write-Output " * Seting up MSYS *** " Review

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586658315 ## bin/install_dependencies.ps1: ## @@ -34,6 +36,11 @@ if (Test-Path($ChocolateyProfile)) { } refreshenv +Write-Output " * Seting up MSYS *** " Review

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586657681 ## bin/shell.ps1: ## @@ -33,6 +33,7 @@ $env:PATH += ";${elxInstallPath}\bin" $env:PATH += ";${vcpkgBase}\bin" $env:PATH += ";C:\Program Files (x86)\WiX Toolset

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
big-r81 commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586646945 ## bin/shell.ps1: ## @@ -33,6 +33,7 @@ $env:PATH += ";${elxInstallPath}\bin" $env:PATH += ";${vcpkgBase}\bin" $env:PATH += ";C:\Program Files (x86)\WiX Toolset

[PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva opened a new pull request, #32: URL: https://github.com/apache/couchdb-glazier/pull/32 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,