[GitHub] [dubbo-go] hxmhlt commented on pull request #398: user can add attachment

2020-03-11 Thread GitHub
May null pointer error? [ Full content available at: https://github.com/apache/dubbo-go/pull/398 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubs

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

2020-03-11 Thread GitHub
This function set default value [ Full content available at: https://github.com/apache/dubbo-go/pull/352 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notification

[GitHub] [dubbo-hessian-lite] codecov-io commented on issue #23: throw 0x41 for large request in hessian InputStream & OutputStream

2020-03-11 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-hessian-lite/pull/23?src=pr&el=h1) Report > Merging > [#23](https://codecov.io/gh/apache/dubbo-hessian-lite/pull/23?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/dubbo-hessian-lite/commit/6d112471d5aef0b952fa5f0a62bf97e5a52e16f0?s

[GitHub] [dubbo-go] codecov-io commented on issue #398: user can add attachment

2020-03-11 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/398?src=pr&el=h1) Report > Merging [#398](https://codecov.io/gh/apache/dubbo-go/pull/398?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/e31ac1dfd3bc0732bd88f139564130bbce8754ad?src=pr&el=desc) > will **decrea

[GitHub] [dubbo] chickenlj commented on issue #5831: There is no metadata available, please update to Dubbo2.7, or check your config center configuration in application.properties

2020-03-11 Thread GitHub
fixed in 2.7.6 [ Full content available at: https://github.com/apache/dubbo/issues/5831 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dub

[GitHub] [dubbo-go-hessian2] wongoo opened pull request #165: release note for v1.4.0

2020-03-11 Thread GitHub
**What this PR does**: merge release note for v1.4.0 [ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/165 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To

[GitHub] [dubbo] chickenlj commented on issue #5846: didn't find this package org.apache.dubbo.common.serialize.protobuf.support.wrapper

2020-03-11 Thread GitHub
Reopen if necessary. [ Full content available at: https://github.com/apache/dubbo/issues/5846 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [dubbo] chickenlj closed issue #5846: didn't find this package org.apache.dubbo.common.serialize.protobuf.support.wrapper

2020-03-11 Thread GitHub
[ issue closed by chickenlj ] [ Full content available at: https://github.com/apache/dubbo/issues/5846 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-

[GitHub] [dubbo] chickenlj commented on issue #5855: [WARN]ReferenceConfig(null) is not DESTROYED when FINALIZE

2020-03-11 Thread GitHub
Agree, it can be removed now, would you like to submit a PR? [ Full content available at: https://github.com/apache/dubbo/issues/5855 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsu

[dubbo-samples] branch master updated: fix monitor sample

2020-03-11 Thread liujun
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new 8e426d8 fix monitor sample 8e426d8 is de

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

2020-03-11 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report > Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) > will **increa

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

2020-03-11 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report > Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) > will **increa

[GitHub] [dubbo-go] zouyx closed pull request #399: Fix problem of rest protocol PR #352

2020-03-11 Thread GitHub
[ pull request closed by zouyx ] [ Full content available at: https://github.com/apache/dubbo-go/pull/399 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notificatio

[GitHub] [dubbo-go] Patrick0308 opened pull request #399: Fix problem of rest protocol PR #352

2020-03-11 Thread GitHub
**What this PR does**: **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**: ```release-note ``` [ Full content available at: https://github.com/apache/dubbo-go/pull/399 ] This message was relayed via gitbox.apache.

[GitHub] [dubbo-go] Patrick0308 commented on issue #352: Rest protocol

2020-03-11 Thread GitHub
@fangyincheng rest_config and other_config are may be in different places. For example, other_config is in a yml, rest_config may be in code. ![image](https://user-images.githubusercontent.com/5486149/76484457-cc8c5200-6454-11ea-8fac-8828a02d023d.png) [ Full content available at: https://github

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

2020-03-11 Thread GitHub
`GetRestyClient` will return `rest_interface.RestClient` and `NewRestyClient` will return `*RestyClient` [ Full content available at: https://github.com/apache/dubbo-go/pull/352 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] pantianying opened pull request #398: user can add attachment

2020-03-11 Thread GitHub
**What this PR does**: **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**: ```release-note ``` [ Full content available at: https://github.com/apache/dubbo-go/pull/398 ] This message was relayed via gitbox.apache.

[dubbo-samples] branch master updated: fix protostuff and validation sample

2020-03-11 Thread liujun
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new b914c28 fix protostuff and validation sa

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

2020-03-11 Thread GitHub
Is it useful now? if not delete it. [ Full content available at: https://github.com/apache/dubbo-go/pull/352 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifica

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

2020-03-11 Thread GitHub
this if condition clause is so long. pls change it as follows, if ok { return restServer } x [ Full content available at: https://github.com/apache/dubbo-go/pull/352 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org ---

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

2020-03-11 Thread GitHub
as above [ Full content available at: https://github.com/apache/dubbo-go/pull/352 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apa

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

2020-03-11 Thread GitHub
as above [ Full content available at: https://github.com/apache/dubbo-go/pull/352 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apa

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

2020-03-11 Thread GitHub
as above [ Full content available at: https://github.com/apache/dubbo-go/pull/352 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apa

[GitHub] [dubbo] qinliujie commented on issue #5848: Fix merge does not work.

2020-03-11 Thread GitHub
LGTM [ Full content available at: https://github.com/apache/dubbo/pull/5848 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.or

[dubbo-samples] branch master updated: update README.md

2020-03-11 Thread liujun
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new 8593a40 update README.md 8593a40 is desc

[GitHub] [dubbo-go] codecov-io commented on issue #397: Add: Grpc tracing for client and server

2020-03-11 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/397?src=pr&el=h1) Report > Merging [#397](https://codecov.io/gh/apache/dubbo-go/pull/397?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/ab850a49254fa3c31753af0db099f08b124e31a4&el=desc) > will **decrease** co

[GitHub] [dubbo] lkj41110 opened issue #5855: [WARN]ReferenceConfig(null) is not DESTROYED when FINALIZE

2020-03-11 Thread GitHub
### Environment * Dubbo version: 2.7.4.1 ### Steps to reproduce this issue 在dubbo正常启动的时候,会出现很多一样的警告 ``` 2020-03-11 22:56:34.344 [Finalizer] [WARN] com.alibaba.dubbo.config.AbstractConfig - [DUBBO] ReferenceConfig(null) is not DESTROYED when FINALIZE, dubbo version: 2.6.4, current host: 192.1

[GitHub] [dubbo] itbeeZh opened issue #5853: Can the 2.7 client call the 2.6 server, and how to implement it?

2020-03-11 Thread GitHub
2.7 客户端 是否可以调用2.6 服务, 如何实现? Can the 2.7 client call the 2.6 server, and how to implement it? [ Full content available at: https://github.com/apache/dubbo/issues/5853 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org --

[dubbo-samples] branch master updated: Update .travis.yml

2020-03-11 Thread hyunkun
This is an automated email from the ASF dual-hosted git repository. hyunkun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new 287e2cc Update .travis.yml 287e2cc is d

[GitHub] [dubbo] Patrick0308 opened pull request #5852: If parameter of Injvm is true, it will do check again in 2.6.x.

2020-03-11 Thread GitHub
…true, check again. ## What is the purpose of the change Modify default parameter injvm to true in Reference, and if injvm is true, it will do check again. ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and eas

[GitHub] [dubbo-samples] htynkn opened a new pull request #153: fix ci script to include maven sub project

2020-03-11 Thread GitBox
htynkn opened a new pull request #153: fix ci script to include maven sub project URL: https://github.com/apache/dubbo-samples/pull/153 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [dubbo] chickenlj commented on issue #5849: throw unknown exception

2020-03-11 Thread GitHub
LGTM. [ Full content available at: https://github.com/apache/dubbo/pull/5849 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.o

[GitHub] [dubbo] chickenlj opened pull request #5849: throw unknown exception

2020-03-11 Thread GitHub
## What is the purpose of the change In `AsyncToSyncInvoker`, when `ExecutionException` happens, only `TimeoutException` and `RemotingException` are handled and wrapped as `RpcException` and re-throw. The problem here is other exception will be swallowed silently. ## Brief changelog wrap othe

[GitHub] [dubbo] codecov-io commented on issue #5851: add compatible setAttachment methods

2020-03-11 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5851?src=pr&el=h1) Report > Merging [#5851](https://codecov.io/gh/apache/dubbo/pull/5851?src=pr&el=desc) > into > [2.7.6-release](https://codecov.io/gh/apache/dubbo/commit/e0ff2effb61e049ed9cf50017f9c1e9deba12168&el=desc) > will **increase** co

[dubbo-samples] branch master updated: fix samples: consul, tengine and grpc

2020-03-11 Thread liujun
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new 7898f1f fix samples: consul,tengine and

[GitHub] [dubbo-samples] htynkn closed pull request #152: add go lang ci

2020-03-11 Thread GitHub
[ pull request closed by htynkn ] [ Full content available at: https://github.com/apache/dubbo-samples/pull/152 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notif

[dubbo-samples] branch master updated: add go lang ci, build only (#152)

2020-03-11 Thread hyunkun
This is an automated email from the ASF dual-hosted git repository. hyunkun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new fecef29 add go lang ci, build only (#15

[GitHub] [dubbo-samples] htynkn merged pull request #152: add go lang ci

2020-03-11 Thread GitBox
htynkn merged pull request #152: add go lang ci URL: https://github.com/apache/dubbo-samples/pull/152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [dubbo-samples] htynkn opened a new pull request #152: add go lang ci

2020-03-11 Thread GitBox
htynkn opened a new pull request #152: add go lang ci URL: https://github.com/apache/dubbo-samples/pull/152 build only, not integration test This is an automated message from the Apache Git Service. To respond to the message,