Re: [PR] skip failed tests [dubbo-go-samples]

2023-11-21 Thread via GitHub
AlbumenJ merged PR #651: URL: https://github.com/apache/dubbo-go-samples/pull/651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [I] Uniformly use log4j2 as the logging component [dubbo]

2023-11-21 Thread via GitHub
oxsean closed issue #13378: Uniformly use log4j2 as the logging component URL: https://github.com/apache/dubbo/issues/13378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Bump io.micrometer:micrometer-tracing-bom from 1.1.6 to 1.2.0 [dubbo]

2023-11-21 Thread via GitHub
sonarcloud[bot] commented on PR #13397: URL: https://github.com/apache/dubbo/pull/13397#issuecomment-1822252753 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qual

[PR] skip failed tests [dubbo-go-samples]

2023-11-21 Thread via GitHub
chickenlj opened a new pull request, #651: URL: https://github.com/apache/dubbo-go-samples/pull/651 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [I] Tri and Dubbo port reuse (PortUnification), consumer TripleInvoker and DubboInvoker coverage issues [dubbo]

2023-11-21 Thread via GitHub
iJIAJIA commented on issue #13401: URL: https://github.com/apache/dubbo/issues/13401#issuecomment-1822235168 > Could you pls submit a PR to fix it? ok! i'll do it later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] Tri and Dubbo port reuse (PortUnification), consumer TripleInvoker and DubboInvoker coverage issues [dubbo]

2023-11-21 Thread via GitHub
AlbumenJ commented on issue #13401: URL: https://github.com/apache/dubbo/issues/13401#issuecomment-186407 Could you pls submit a PR to fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump io.micrometer:micrometer-tracing-bom from 1.1.6 to 1.2.0 [dubbo]

2023-11-21 Thread via GitHub
conghuhu commented on code in PR #13397: URL: https://github.com/apache/dubbo/pull/13397#discussion_r1401590599 ## dubbo-spring-boot/dubbo-spring-boot-starters/observability/autoconfigure/src/main/java/org/apache/dubbo/spring/boot/observability/autoconfigure/otel/OpenTelemetryAutoConfig

Re: [I] dubbo version 3.2.5 customer serialization failure [dubbo]

2023-11-21 Thread via GitHub
AlbumenJ commented on issue #13399: URL: https://github.com/apache/dubbo/issues/13399#issuecomment-1822209804 Have you configure this in both consumer and provider sides? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] After the provider application is shut down, consumers will still send heartbeat requests to this offline process [dubbo]

2023-11-21 Thread via GitHub
AlbumenJ commented on issue #13400: URL: https://github.com/apache/dubbo/issues/13400#issuecomment-1822210620 Maybe we have fixed it in the latest version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] complete already: DefaultPromise [dubbo]

2023-11-21 Thread via GitHub
AlbumenJ commented on issue #13398: URL: https://github.com/apache/dubbo/issues/13398#issuecomment-1822206920 @icodening @EarthChen PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Bump io.micrometer:micrometer-tracing-bom from 1.1.6 to 1.2.0 [dubbo]

2023-11-21 Thread via GitHub
AlbumenJ commented on code in PR #13397: URL: https://github.com/apache/dubbo/pull/13397#discussion_r1401581724 ## dubbo-spring-boot/dubbo-spring-boot-starters/observability/autoconfigure/src/main/java/org/apache/dubbo/spring/boot/observability/autoconfigure/otel/OpenTelemetryAutoConfig

Re: [PR] Completely delete `old triple` and `dubbo3` package [dubbo-go]

2023-11-21 Thread via GitHub
sonarcloud[bot] commented on PR #2506: URL: https://github.com/apache/dubbo-go/pull/2506#issuecomment-1822194962 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

(dubbo-samples) branch master updated (cc07b7e9b -> 2bb29dd7c)

2023-11-21 Thread albumenj
This is an automated email from the ASF dual-hosted git repository. albumenj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git from cc07b7e9b fix triple grpc interop (#1023) add 2bb29dd7c feat(logging): #13378 Uniformly uses log4j2 as t

Re: [PR] feat(logging): #13378 Uniformly uses log4j2 as the logging component [dubbo-samples]

2023-11-21 Thread via GitHub
AlbumenJ merged PR #1024: URL: https://github.com/apache/dubbo-samples/pull/1024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] Fix, set default application name if it's empty [dubbo-go]

2023-11-21 Thread via GitHub
AlbumenJ merged PR #2518: URL: https://github.com/apache/dubbo-go/pull/2518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@du

Re: [PR] Bump io.micrometer:micrometer-tracing-bom from 1.1.6 to 1.2.0 [dubbo]

2023-11-21 Thread via GitHub
sonarcloud[bot] commented on PR #13397: URL: https://github.com/apache/dubbo/pull/13397#issuecomment-1822156716 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qual

Re: [PR] Fix, set default application name if it's empty [dubbo-go]

2023-11-21 Thread via GitHub
sonarcloud[bot] commented on PR #2518: URL: https://github.com/apache/dubbo-go/pull/2518#issuecomment-1822024810 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[PR] Fix, set default application name if it's empty [dubbo-go]

2023-11-21 Thread via GitHub
chickenlj opened a new pull request, #2518: URL: https://github.com/apache/dubbo-go/pull/2518 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [I] URL encoding is performed when passing URL parameters under the rest protocol [dubbo]

2023-11-21 Thread via GitHub
kazetyan commented on issue #13349: URL: https://github.com/apache/dubbo/issues/13349#issuecomment-1822011264 > [demo-bug.zip](https://github.com/apache/dubbo/files/13428227/demo-bug.zip) 这是写的一个示例压缩包,采用了三个子模块的形式,然后也测试过将所有的代码放到一个模块中,在一个模块中并没有出现乱码问题,但在三个子模块中就出现了乱码问题 ![image](https://g

Re: [PR] Tst: local test passed [dubbo-rust]

2023-11-21 Thread via GitHub
yang20150702 commented on code in PR #166: URL: https://github.com/apache/dubbo-rust/pull/166#discussion_r1401439896 ## dubbo/src/directory/mod.rs: ## @@ -164,26 +160,27 @@ where let registry = self.inner.clone(); -let (tx, rx) = channel(1024); +let

Re: [PR] Update helloworld [dubbo-go-samples]

2023-11-21 Thread via GitHub
chickenlj merged PR #650: URL: https://github.com/apache/dubbo-go-samples/pull/650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] RpcServiceContext.isConsumerSide return false in consumer side [dubbo]

2023-11-21 Thread via GitHub
LoveleeKay commented on issue #12376: URL: https://github.com/apache/dubbo/issues/12376#issuecomment-1821988792 > > 这个问题会在3.1.x修复吗?还是只能升级到3.2.x? > > 这个提交到了3.2.3里了,按AlbumenJ之前的说法,目前3.1.x只解决安全问题了 我用的3.2.9 版本判断依旧不准确,也是使用到了alibaba的filter ![image](https://github.com/apache/dubbo/

Re: [PR] feat(logging): #13378 Uniformly uses log4j2 as the logging component [dubbo]

2023-11-21 Thread via GitHub
AlbumenJ merged PR #13402: URL: https://github.com/apache/dubbo/pull/13402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dub

Re: [PR] Add protoc release action [dubbo-go]

2023-11-21 Thread via GitHub
sonarcloud[bot] commented on PR #2516: URL: https://github.com/apache/dubbo-go/pull/2516#issuecomment-1821963047 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

Re: [PR] feat(logging): #13378 Uniformly uses log4j2 as the logging component [dubbo]

2023-11-21 Thread via GitHub
sonarcloud[bot] commented on PR #13402: URL: https://github.com/apache/dubbo/pull/13402#issuecomment-1821250331 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qual

Re: [PR] Tst: local test passed [dubbo-rust]

2023-11-21 Thread via GitHub
yang20150702 commented on code in PR #166: URL: https://github.com/apache/dubbo-rust/pull/166#discussion_r1400762072 ## dubbo/src/loadbalancer/mod.rs: ## @@ -40,59 +44,50 @@ where let svc = self.inner.new_service(target); LoadBalancer { -inner: sv

Re: [I] Reactor programming works in oneToOne mode, but the server reports an error in other modes [dubbo]

2023-11-21 Thread via GitHub
wiscloud commented on issue #13348: URL: https://github.com/apache/dubbo/issues/13348#issuecomment-1821203424 [demo-bug.zip](https://github.com/apache/dubbo/files/13428450/demo-bug.zip) 这是一个 springboot3 的示例,本机是M1芯片的 MacStudio,OneToOne 模式是可以的,其它模式不行 -- This is an automated message from t

[PR] feat(logging): #13378 Uniformly uses log4j2 as the logging component [dubbo-samples]

2023-11-21 Thread via GitHub
oxsean opened a new pull request, #1024: URL: https://github.com/apache/dubbo-samples/pull/1024 ## What is the purpose of the change See: https://github.com/apache/dubbo/pull/13402 ## Brief changelog 1. Replace log4j and logback with log4j2, providing a simple Log4j2 configurati

Re: [I] URL encoding is performed when passing URL parameters under the rest protocol [dubbo]

2023-11-21 Thread via GitHub
wiscloud commented on issue #13349: URL: https://github.com/apache/dubbo/issues/13349#issuecomment-1821179014 [demo-bug.zip](https://github.com/apache/dubbo/files/13428227/demo-bug.zip) 这是写的一个示例压缩包,采用了三个子模块的形式,然后也测试过将所有的代码放到一个模块中,在一个模块中并没有出现乱码问题,但在三个子模块中就出现了乱码问题 -- This is an automated

Re: [I] Transitive dependency problem with Zookeeper and Curator5 log jars [dubbo]

2023-11-21 Thread via GitHub
oxsean closed issue #13188: Transitive dependency problem with Zookeeper and Curator5 log jars URL: https://github.com/apache/dubbo/issues/13188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] Enhance spring boot configuration metadata [dubbo]

2023-11-21 Thread via GitHub
oxsean closed issue #13299: Enhance spring boot configuration metadata URL: https://github.com/apache/dubbo/issues/13299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] feat(logging): #13378 Uniformly uses log4j2 as the logging component [dubbo]

2023-11-21 Thread via GitHub
oxsean opened a new pull request, #13402: URL: https://github.com/apache/dubbo/pull/13402 ## What is the purpose of the change Currently in Dubbo, there is a mixed use of log components, and some modules lack log configuration, due to no log output. Therefore, uniformly use log4j2 can re

[I] dubbo protocol and dubbo-go-hessian2 can not process (*int32)(nil) corner case [dubbo-go]

2023-11-21 Thread via GitHub
DMwangnima opened a new issue, #2517: URL: https://github.com/apache/dubbo-go/issues/2517 ### Environment - Server: Dubbo-go, v3.1.0 - Client: Dubbo-go, v3.1.0 - Protocol: Dubbo ### Issue description defining API ```go type UserProvider struct {

[PR] Tst: local test passed [dubbo-rust]

2023-11-21 Thread via GitHub
onewe opened a new pull request, #166: URL: https://github.com/apache/dubbo-rust/pull/166 - refactor some logic for directory component - BufferedBody use CloneBody instead of generics - add CloneInvoker component and remove request param generics - add map_request method in the Tri

Re: [PR] Upgrade to 3.2.x and refactor code [dubbo-spi-extensions]

2023-11-21 Thread via GitHub
songxiaosheng merged PR #241: URL: https://github.com/apache/dubbo-spi-extensions/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Bump io.micrometer:micrometer-tracing-bom from 1.1.6 to 1.2.0 [dubbo]

2023-11-21 Thread via GitHub
songxiaosheng commented on code in PR #13397: URL: https://github.com/apache/dubbo/pull/13397#discussion_r1400687101 ## dubbo-spring-boot/dubbo-spring-boot-starters/observability/autoconfigure/src/main/java/org/apache/dubbo/spring/boot/observability/autoconfigure/otel/OpenTelemetryAutoC

Re: [PR] Bump io.micrometer:micrometer-tracing-bom from 1.1.6 to 1.2.0 [dubbo]

2023-11-21 Thread via GitHub
sonarcloud[bot] commented on PR #13397: URL: https://github.com/apache/dubbo/pull/13397#issuecomment-1821025470 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qual

Re: [PR] Bump io.micrometer:micrometer-tracing-bom from 1.1.6 to 1.2.0 [dubbo]

2023-11-21 Thread via GitHub
conghuhu commented on PR #13397: URL: https://github.com/apache/dubbo/pull/13397#issuecomment-1820946137 > Are you considering compatibility between two versions through the existence of classes? @songxiaosheng Thank you for your suggestion. The code has been updated -- This is an

[I] tri和dubbo端口融合, consumer TripleInvoker和DubboInvoker覆盖问题 [dubbo]

2023-11-21 Thread via GitHub
iJIAJIA opened a new issue, #13401: URL: https://github.com/apache/dubbo/issues/13401 - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate. ### Environment * Dubbo version: 3.2.3 * Oper

Re: [I] URL encoding is performed when passing URL parameters under the rest protocol [dubbo]

2023-11-21 Thread via GitHub
kazetyan commented on issue #13349: URL: https://github.com/apache/dubbo/issues/13349#issuecomment-1820842240 ![image](https://github.com/apache/dubbo/assets/50894526/4c562d3e-db6e-4b0e-a0fc-83874c319a98) ![image](https://github.com/apache/dubbo/assets/50894526/9542a458-1ce0-480f

[PR] Update helloworld [dubbo-go-samples]

2023-11-21 Thread via GitHub
chickenlj opened a new pull request, #650: URL: https://github.com/apache/dubbo-go-samples/pull/650 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Add protoc release action [dubbo-go]

2023-11-21 Thread via GitHub
sonarcloud[bot] commented on PR #2516: URL: https://github.com/apache/dubbo-go/pull/2516#issuecomment-1820553544 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

Re: [PR] Update helloworld [dubbo-go-samples]

2023-11-21 Thread via GitHub
chickenlj closed pull request #649: Update helloworld URL: https://github.com/apache/dubbo-go-samples/pull/649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] Add protoc release action [dubbo-go]

2023-11-21 Thread via GitHub
sonarcloud[bot] commented on PR #2516: URL: https://github.com/apache/dubbo-go/pull/2516#issuecomment-1820472676 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[PR] Add protoc release action [dubbo-go]

2023-11-21 Thread via GitHub
chickenlj opened a new pull request, #2516: URL: https://github.com/apache/dubbo-go/pull/2516 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [I] hessian 解参panic [dubbo-go-hessian2]

2023-11-21 Thread via GitHub
zonghaishang closed issue #367: hessian 解参panic URL: https://github.com/apache/dubbo-go-hessian2/issues/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Update helloworld [dubbo-go-samples]

2023-11-21 Thread via GitHub
AlexStocks commented on PR #649: URL: https://github.com/apache/dubbo-go-samples/pull/649#issuecomment-1820463432 CI 失败了,看看为啥。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co