Re: [I] If --add-opens=java.base/java.net=ALL-UNNAMED added to native-maven-plugin's buildArgs, Exception will be found in Dubbo ExtensionLoader [dubbo]

2024-03-26 Thread via GitHub
imgoby commented on issue #13802: URL: https://github.com/apache/dubbo/issues/13802#issuecomment-2022065148 @CrazyHZM Hello,This issue exists indeed. I am sure it is dubbo 's bug.If I remove org.apache.dubbo.common.utils.ClassLoaderResourceLoader code between line 86 to line 89,anything wil

Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-26 Thread via GitHub
walklown commented on code in PR #1110: URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1540516941 ## 1-basic/dubbo-samples-spring-boot-idl/pom.xml: ## @@ -53,6 +53,13 @@ + +org.apache +apache +

Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-26 Thread via GitHub
walklown closed pull request #1110: Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 URL: https://github.com/apache/dubbo-samples/pull/1110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] If --add-opens=java.base/java.net=ALL-UNNAMED added to native-maven-plugin's buildArgs, Exception will be found in Dubbo ExtensionLoader [dubbo]

2024-03-26 Thread via GitHub
CrazyHZM commented on issue #13802: URL: https://github.com/apache/dubbo/issues/13802#issuecomment-2022014599 @imgoby This buildArgs schema is provided by native-maven-plugin, so I think it is not the cause of this exception. Can you provide a demo for reproduce it? -- This is an auto

Re: [PR] add auddo-wasm/README_zh.md [dubbo-spi-extensions]

2024-03-26 Thread via GitHub
songxiaosheng merged PR #298: URL: https://github.com/apache/dubbo-spi-extensions/pull/298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Feat security [dubbo-go]

2024-03-26 Thread via GitHub
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2021887589 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] add auddo-wasm/README_zh.md [dubbo-spi-extensions]

2024-03-26 Thread via GitHub
loongs-zhang commented on PR #298: URL: https://github.com/apache/dubbo-spi-extensions/pull/298#issuecomment-2021791249 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] feat:Update org.apache.dubbo.dependency.FileTest [dubbo]

2024-03-26 Thread via GitHub
Stellar1999 commented on PR #14001: URL: https://github.com/apache/dubbo/pull/14001#issuecomment-2021788723 I've checked `core-spi` and `all-shaded` just like checked `dubbo-all` transforms, so I added some transforms in these POM files. I'm not sure if these additions are correct. Should

Re: [PR] feat:Update org.apache.dubbo.dependency.FileTest [dubbo]

2024-03-26 Thread via GitHub
codecov-commenter commented on PR #14001: URL: https://github.com/apache/dubbo/pull/14001#issuecomment-2021772518 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/14001?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] feat:Update org.apache.dubbo.dependency.FileTest [dubbo]

2024-03-26 Thread via GitHub
sonarcloud[bot] commented on PR #14001: URL: https://github.com/apache/dubbo/pull/14001#issuecomment-2021768238 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] feat:Update org.apache.dubbo.dependency.FileTest [dubbo]

2024-03-26 Thread via GitHub
sonarcloud[bot] commented on PR #14001: URL: https://github.com/apache/dubbo/pull/14001#issuecomment-2021768065 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

[PR] feat:Update org.apache.dubbo.dependency.FileTest [dubbo]

2024-03-26 Thread via GitHub
Stellar1999 opened a new pull request, #14001: URL: https://github.com/apache/dubbo/pull/14001 ## What is the purpose of the change Update org.apache.dubbo.dependency.FileTest in 3.3 to support check dubbo-all-shaded and dubbo-core-spi (#13961) ## Brief changelog

Re: [PR] Feat security [dubbo-go]

2024-03-26 Thread via GitHub
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2021715190 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

2024-03-26 Thread via GitHub
sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2020974137 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] feat:Remove zk3.4 support in 3.3 [dubbo]

2024-03-26 Thread via GitHub
Stellar1999 commented on PR #13970: URL: https://github.com/apache/dubbo/pull/13970#issuecomment-2020732636 > Please check why test cases failed The new error is:` Could not find artifact org.apache.dubbo:dubbo-dependencies-zookeeper-curator5:pom:3.3.0-beta.2-SNAPSHOT` I think I sh

Re: [PR] fix: examples dubbo-zookeeper consumer imports [dubbo-js]

2024-03-26 Thread via GitHub
jianyi-gronk commented on PR #386: URL: https://github.com/apache/dubbo-js/pull/386#issuecomment-2020710178 Maybe we don’t need to modify the dubbo2 branch code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] docs: common errors & supported browsers and frameworks [dubbo-js]

2024-03-26 Thread via GitHub
sonarcloud[bot] commented on PR #388: URL: https://github.com/apache/dubbo-js/pull/388#issuecomment-2020653878 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclou

Re: [PR] docs: common errors & supported browsers and frameworks [dubbo-js]

2024-03-26 Thread via GitHub
CoderSerio commented on PR #388: URL: https://github.com/apache/dubbo-js/pull/388#issuecomment-2020647043 fix #373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] docs: common errors & supported browsers and frameworks [dubbo-js]

2024-03-26 Thread via GitHub
sonarcloud[bot] commented on PR #388: URL: https://github.com/apache/dubbo-js/pull/388#issuecomment-2020642426 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclou

[PR] docs: common errors & supported browsers and frameworks [dubbo-js]

2024-03-26 Thread via GitHub
CoderSerio opened a new pull request, #388: URL: https://github.com/apache/dubbo-js/pull/388 1. create 2 docs: - common errors - supported browsers and frameworks 2. move 2 picture files to a new directory -- This is an automated message from the Apache Git Service. To res

Re: [I] 请教一个provider复用ip导致的问题 [dubbo]

2024-03-26 Thread via GitHub
zhoujinsy commented on issue #12338: URL: https://github.com/apache/dubbo/issues/12338#issuecomment-2020461618 麻烦问一下是什么原因导致的呢, 我们也遇到了相同问题, dubbo版本是3.0.12, nacos版本是2.2.4, 查看了consumer端的推送日志, 接口级的和应用级的ip变更也都正常推送了 -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] 请教一个provider复用ip导致的问题 [dubbo]

2024-03-26 Thread via GitHub
zhoujinsy commented on issue #12338: URL: https://github.com/apache/dubbo/issues/12338#issuecomment-2020459569 麻烦问一下是什么原因导致的呢, 我们也遇到了相同问题, dubbo版本是3.0.12, nacos版本是2.2.4, 查看了consumer端的推送日志, 接口级的和服务级的ip变更也都正常推送了 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] For HTTP/1 unary mode, use Content-Length instead of chunk [dubbo]

2024-03-26 Thread via GitHub
oxsean commented on PR #13979: URL: https://github.com/apache/dubbo/pull/13979#issuecomment-2020329259 @AlbumenJ @finefuture I think END_STREAM flag is enough, because END_STREAM flag is mandatory. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] For HTTP/1 unary mode, use Content-Length instead of chunk [dubbo]

2024-03-26 Thread via GitHub
finefuture commented on PR #13979: URL: https://github.com/apache/dubbo/pull/13979#issuecomment-2020265363 > For HTTP/2 unary, should we fix it? Maybe we don't need to fix it, refer to this link: https://stackoverflow.com/questions/77520309/why-is-content-length-header-not-sent-over-h

Re: [PR] For HTTP/1 unary mode, use Content-Length instead of chunk [dubbo]

2024-03-26 Thread via GitHub
sonarcloud[bot] commented on PR #13979: URL: https://github.com/apache/dubbo/pull/13979#issuecomment-2020249697 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [I] [Bug] Why can't I find the code for the adaptive throttling algorithm in dubbo's source code, but I see it in dubbo's documentation. [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ closed issue #13997: [Bug] Why can't I find the code for the adaptive throttling algorithm in dubbo's source code, but I see it in dubbo's documentation. URL: https://github.com/apache/dubbo/issues/13997 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Exlude transitive logbak dependency in zookeeper [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ merged PR #13995: URL: https://github.com/apache/dubbo/pull/13995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dub

Re: [I] [Feature] Update FileTest in 3.3 [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ commented on issue #13961: URL: https://github.com/apache/dubbo/issues/13961#issuecomment-2020160688 Update `checkDubboAllTransform` in `FileTest` to check `dubbo-all-shaded` and `dubbo-core-spi` -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [I] [Bug] org.hibernate.validator.internal.constraintvalidators.bv.MinValidatorForCharSequence, you can config 'JSONReader.Feature.SupportClassForName', offset 2057 [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ closed issue #13994: [Bug] org.hibernate.validator.internal.constraintvalidators.bv.MinValidatorForCharSequence, you can config 'JSONReader.Feature.SupportClassForName', offset 2057 URL: https://github.com/apache/dubbo/issues/13994 -- This is an automated message from the Apache Gi

Re: [PR] Fix the triple protocol request failed in the native scenario [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ merged PR #13984: URL: https://github.com/apache/dubbo/pull/13984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dub

Re: [I] Discontinue support for JDK versions below 17[Feature] [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ closed issue #13985: Discontinue support for JDK versions below 17[Feature] URL: https://github.com/apache/dubbo/issues/13985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Discontinue support for JDK versions below 17[Feature] [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ commented on issue #13985: URL: https://github.com/apache/dubbo/issues/13985#issuecomment-2020148839 However, we still have a great number of users using JDK8. We can try it in Dubbo 4.x. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Bump org.apache.maven.plugins:maven-assembly-plugin from 3.7.0 to 3.7.1 [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ merged PR #13992: URL: https://github.com/apache/dubbo/pull/13992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dub

Re: [PR] Bump org.springframework.security:spring-security-bom from 5.8.10 to 5.8.11 [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ merged PR #13993: URL: https://github.com/apache/dubbo/pull/13993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dub

Re: [PR] Bump netty4_version from 4.1.107.Final to 4.1.108.Final [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ merged PR #13988: URL: https://github.com/apache/dubbo/pull/13988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dub

Re: [PR] Bump com.alibaba.fastjson2:fastjson2 from 2.0.47 to 2.0.48 [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ merged PR #13989: URL: https://github.com/apache/dubbo/pull/13989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dub

Re: [PR] Bump org.aspectj:aspectjweaver from 1.9.21.2 to 1.9.22 [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ merged PR #13991: URL: https://github.com/apache/dubbo/pull/13991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dub

Re: [PR] Bump swagger_version from 1.6.13 to 1.6.14 [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ merged PR #13990: URL: https://github.com/apache/dubbo/pull/13990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dub

Re: [PR] Bump org.apache.maven.plugins:maven-compiler-plugin from 3.12.1 to 3.13.0 [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ merged PR #13986: URL: https://github.com/apache/dubbo/pull/13986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dub

Re: [PR] Bump commons-logging:commons-logging from 1.3.0 to 1.3.1 [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ merged PR #13987: URL: https://github.com/apache/dubbo/pull/13987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dub

Re: [PR] feat:Remove zk3.4 support in 3.3 [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ commented on PR #13970: URL: https://github.com/apache/dubbo/pull/13970#issuecomment-2020131489 Please check why test cases failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Use ExecutorService instead of event loop for Netty connection [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ commented on PR #13904: URL: https://github.com/apache/dubbo/pull/13904#issuecomment-2020123712 @icodening PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [Bug] dubbo interacts with native grpc java_package is unavailable [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ commented on issue #13980: URL: https://github.com/apache/dubbo/issues/13980#issuecomment-2020115714 @EarthChen @icodening PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]

2024-03-26 Thread via GitHub
AlbumenJ commented on issue #13957: URL: https://github.com/apache/dubbo/issues/13957#issuecomment-2020113584 > hello,I want to solve it,please assign it to me,thanks ~ done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Feat security [dubbo-go]

2024-03-26 Thread via GitHub
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2019891481 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

[I] [Bug] Why can't I find the code for the adaptive throttling algorithm in dubbo's source code, but I see it in dubbo's documentation. [dubbo]

2024-03-26 Thread via GitHub
Iron-Buster opened a new issue, #13997: URL: https://github.com/apache/dubbo/issues/13997 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?

Re: [PR] For HTTP/1 unary mode, use Content-Length instead of chunk [dubbo]

2024-03-26 Thread via GitHub
codecov-commenter commented on PR #13979: URL: https://github.com/apache/dubbo/pull/13979#issuecomment-2019548744 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/13979?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [I] 在配置 group 情况下,接口/应用同时注册,会导致 consumer 无法读取到 provide 的服务信息,导致启动失败 [dubbo]

2024-03-26 Thread via GitHub
roadToit commented on issue #12097: URL: https://github.com/apache/dubbo/issues/12097#issuecomment-2019548728 请问这个问题有在哪个版本解决吗,我使用3.1.11版本也遇到了这个问题 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] For HTTP/1 unary mode, use Content-Length instead of chunk [dubbo]

2024-03-26 Thread via GitHub
sonarcloud[bot] commented on PR #13979: URL: https://github.com/apache/dubbo/pull/13979#issuecomment-2019540757 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo