Re: [I] triple request missed http header like scheme, host etc. [dubbo-go]

2024-04-02 Thread via GitHub
2456868764 commented on issue #2642: URL: https://github.com/apache/dubbo-go/issues/2642#issuecomment-2033530141 这个设置头部做法在 http2下有问题,一开始有个 method = PRI 协商协议,这个时候是不能设置头部,否则这个协商协议就挂了,对要兼容 http2 / http1 协议不是很熟悉,对triple不是很熟悉,也尝试trick做法,写到 ctx里也是可以的,我现在也是 trick 做法只保留 https会设置头,在 mtls filter检查没有这

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

2024-04-02 Thread via GitHub
sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2033505083 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

[I] 请问支持服务注册发现、负载均衡等服务治理能力吗? [dubbo-js]

2024-04-02 Thread via GitHub
mrwangyin opened a new issue, #390: URL: https://github.com/apache/dubbo-js/issues/390 请问支持服务注册发现、负载均衡等服务治理能力吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] Merge CommonConfigPostProcessor and ConfigPostProcessor [dubbo]

2024-04-02 Thread via GitHub
sonarcloud[bot] commented on PR #14027: URL: https://github.com/apache/dubbo/pull/14027#issuecomment-2033294509 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

[PR] Merge CommonConfigPostProcessor and ConfigPostProcessor [dubbo]

2024-04-02 Thread via GitHub
heliang666s opened a new pull request, #14027: URL: https://github.com/apache/dubbo/pull/14027 ## What is the purpose of the change Merge CommonConfigPostProcessor and ConfigPostProcessor #13959 ## Brief changelog * delete ConfigPostProcessor.java * change related code

Re: [PR] Feat security [dubbo-go]

2024-04-02 Thread via GitHub
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2033046354 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] Triple protocol http1 upgrade support [dubbo]

2024-04-02 Thread via GitHub
sonarcloud[bot] commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2032608711 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [I] [Bug] The triple protocol is called through http, and the return value is incorrect [dubbo]

2024-04-02 Thread via GitHub
cnzakii commented on issue #14023: URL: https://github.com/apache/dubbo/issues/14023#issuecomment-2032168181 This is a misunderstanding caused by habitual thinking, perhaps because you're accustomed to data being passed in JSON format. ![2024-04-02_22 08 27](https://github.com/apache/dub

Re: [PR] Dubbo-2.7.x版本,源码解读注释提交-----未看完 [dubbo]

2024-04-02 Thread via GitHub
MinMonk commented on PR #14025: URL: https://github.com/apache/dubbo/pull/14025#issuecomment-2031934869 同步最新的 2.7.x 版本的代码到当前分支 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Dubbo-2.7.x版本,源码解读注释提交-----未看完 [dubbo]

2024-04-02 Thread via GitHub
MinMonk closed pull request #14025: Dubbo-2.7.x版本,源码解读注释提交-未看完 URL: https://github.com/apache/dubbo/pull/14025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] Dubbo-2.7.x版本,源码解读注释提交-----未看完 [dubbo]

2024-04-02 Thread via GitHub
MinMonk opened a new pull request, #14025: URL: https://github.com/apache/dubbo/pull/14025 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.co

[I] Optimization registry extension [dubbo-rust]

2024-04-02 Thread via GitHub
onewe opened a new issue, #186: URL: https://github.com/apache/dubbo-rust/issues/186 - [ ] Optimization Nacos registry extension - [ ] Finish Zookeeper registry extension -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] For HTTP/1 unary mode, use Content-Length instead of chunk [dubbo]

2024-04-02 Thread via GitHub
sonarcloud[bot] commented on PR #13979: URL: https://github.com/apache/dubbo/pull/13979#issuecomment-2031666705 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] For HTTP/1 unary mode, use Content-Length instead of chunk [dubbo]

2024-04-02 Thread via GitHub
sonarcloud[bot] commented on PR #13979: URL: https://github.com/apache/dubbo/pull/13979#issuecomment-2031664927 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [I] [Task] Monitoring indicators support otel format indicator export [dubbo]

2024-04-02 Thread via GitHub
glmapper commented on issue #13902: URL: https://github.com/apache/dubbo/issues/13902#issuecomment-2031609523 I finished the initial coding and testing, here are my design ideas and some sample data, I hope to submit it to the community and then discuss it together! 1. add new module

Re: [PR] Bump version && fix test case failed [dubbo-spi-extensions]

2024-04-02 Thread via GitHub
aofall commented on PR #303: URL: https://github.com/apache/dubbo-spi-extensions/pull/303#issuecomment-2031600031 @songxiaosheng PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] For HTTP/1 unary mode, use Content-Length instead of chunk [dubbo]

2024-04-02 Thread via GitHub
oxsean commented on PR #13979: URL: https://github.com/apache/dubbo/pull/13979#issuecomment-2031590307 @AlbumenJ LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[I] 有一个panic导致应用挂了 [dubbo-go]

2024-04-02 Thread via GitHub
alan2016llg opened a new issue, #2650: URL: https://github.com/apache/dubbo-go/issues/2650 ### Environment - Server: java-dubbo - Client: Dubbo-go, v3.1.1-rc - Protocol: dubbo - Registry: zk ### Issue description 应用挂了,查询docker最后日志,有一个panic出现,日志如下 #

[PR] :memo: readme update [dubbo-spi-extensions]

2024-04-02 Thread via GitHub
songxiaosheng opened a new pull request, #305: URL: https://github.com/apache/dubbo-spi-extensions/pull/305 ## What is the purpose of the change X ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

2024-04-02 Thread via GitHub
sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2031221667 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo