[PR] Bump com.google.protobuf:protobuf-java from 3.19.4 to 3.19.6 in /java_interop/service_discovery/service/java-server [dubbo-go-samples]

2024-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #749: URL: https://github.com/apache/dubbo-go-samples/pull/749 Bumps [com.google.protobuf:protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.19.4 to 3.19.6. Release notes Sourced from

[PR] Bump com.google.protobuf:protobuf-java from 3.19.4 to 3.19.6 in /java_interop/service_discovery/service/java-client [dubbo-go-samples]

2024-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #751: URL: https://github.com/apache/dubbo-go-samples/pull/751 Bumps [com.google.protobuf:protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.19.4 to 3.19.6. Release notes Sourced from

[PR] Bump junit:junit from 4.13 to 4.13.1 in /java_interop/service_discovery/interface/java-server [dubbo-go-samples]

2024-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #748: URL: https://github.com/apache/dubbo-go-samples/pull/748 Bumps [junit:junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases;>junit:junit's

[PR] Bump com.google.protobuf:protobuf-java from 3.19.4 to 3.19.6 in /java_interop/service_discovery/interface/java-server [dubbo-go-samples]

2024-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #750: URL: https://github.com/apache/dubbo-go-samples/pull/750 Bumps [com.google.protobuf:protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.19.4 to 3.19.6. Release notes Sourced from

Re: [PR] Update helloworld [dubbo-go-samples]

2024-04-11 Thread via GitHub
chickenlj merged PR #747: URL: https://github.com/apache/dubbo-go-samples/pull/747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Sync BitList for all the operations [dubbo]

2024-04-11 Thread via GitHub
He-Pin commented on code in PR #14057: URL: https://github.com/apache/dubbo/pull/14057#discussion_r1562003458 ## dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/state/BitList.java: ## @@ -93,23 +93,23 @@ public BitList(List originList, BitSet rootSet, List

Re: [PR] Task #13958 Move Rest Protocol to SPI Extensions [dubbo]

2024-04-11 Thread via GitHub
chickenlj commented on PR #14061: URL: https://github.com/apache/dubbo/pull/14061#issuecomment-2050959114 @wcy666103 Too many things are included in one single pull request, better only include one thing each time. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Fix: After the streaming call ends, client response.tailer() returns empty #2656 [dubbo-go]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #2658: URL: https://github.com/apache/dubbo-go/pull/2658#issuecomment-2050956806 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] fix: Server return with Attachment (#2641) [dubbo-go]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #2648: URL: https://github.com/apache/dubbo-go/pull/2648#issuecomment-2050955590 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Refactor 3.3 grpc http2 processes [dubbo]

2024-04-11 Thread via GitHub
BitoAgent commented on PR #13786: URL: https://github.com/apache/dubbo/pull/13786#issuecomment-2050954767 ## Code Review Agent Run Status - **AI Based Review:** Successful - **Static Analysis:** Partially Successful - Failed to execute static code analysis using fb_infer ##

Re: [PR] fix : fix test case [dubbo-go]

2024-04-11 Thread via GitHub
chickenlj merged PR #2660: URL: https://github.com/apache/dubbo-go/pull/2660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support more content types for Triple protocol [dubbo]

2024-04-11 Thread via GitHub
oxsean commented on PR #13387: URL: https://github.com/apache/dubbo/pull/13387#issuecomment-2050944708 What version? you can create a separate bug ticket. @crazyStar00 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HTTP/3 support for dubbo triple [dubbo]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #14033: URL: https://github.com/apache/dubbo/pull/14033#issuecomment-2050920121 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [I] [Bug] The triple protocol is called through http, and the return value is incorrect [dubbo]

2024-04-11 Thread via GitHub
crazyStar00 commented on issue #14023: URL: https://github.com/apache/dubbo/issues/14023#issuecomment-2050893512 > > > > This is a misunderstanding caused by habitual thinking, perhaps because you're accustomed to data being passed in JSON format. ![2024-04-02_22 08

Re: [I] [Bug] The triple protocol is called through http, and the return value is incorrect [dubbo]

2024-04-11 Thread via GitHub
crazyStar00 commented on issue #14023: URL: https://github.com/apache/dubbo/issues/14023#issuecomment-2050892241 > > > This is a misunderstanding caused by habitual thinking, perhaps because you're accustomed to data being passed in JSON format. ![2024-04-02_22 08

Re: [I] [Bug] The triple protocol is called through http, and the return value is incorrect [dubbo]

2024-04-11 Thread via GitHub
crazyStar00 commented on issue #14023: URL: https://github.com/apache/dubbo/issues/14023#issuecomment-2050891666 > > This is a misunderstanding caused by habitual thinking, perhaps because you're accustomed to data being passed in JSON format. ![2024-04-02_22 08

Re: [PR] Support more content types for Triple protocol [dubbo]

2024-04-11 Thread via GitHub
crazyStar00 commented on PR #13387: URL: https://github.com/apache/dubbo/pull/13387#issuecomment-2050888152 form-data is bak;multipart/formdata、text/plain、application/x-www-form-urlencoded is ok

Re: [PR] fix: Bytebuf resource leak [dubbo]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #14071: URL: https://github.com/apache/dubbo/pull/14071#issuecomment-2050862201 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [I] dubbo-go的服务,在dubbo-admin中无法发现方法 #1262 [dubbo-go]

2024-04-11 Thread via GitHub
FoghostCn commented on issue #2588: URL: https://github.com/apache/dubbo-go/issues/2588#issuecomment-2050860766 you should set metadata type to remote ```go rootConfigBuilder := config.NewRootConfigBuilder() cb := rootConfigBuilder.

Re: [PR] build(deps): bump idna from 2.8 to 3.7 in /samples/bookinfo/src/productpage [dubbo-go-pixiu]

2024-04-11 Thread via GitHub
AlexStocks merged PR #620: URL: https://github.com/apache/dubbo-go-pixiu/pull/620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Is it correct to continue to maintain the connection pool when a connection encounters an error? [dubbo-getty]

2024-04-11 Thread via GitHub
AlexStocks commented on issue #116: URL: https://github.com/apache/dubbo-getty/issues/116#issuecomment-2050856427 > > > > > 再补充一下这个 issue。当连接数超过 provider 上限之后,TCP 连接能够完成,但是服务端会马上主动断开连接。针对这种情况我认为是需要避免重新连接的。期待回复,谢谢。

Re: [I] Is it correct to continue to maintain the connection pool when a connection encounters an error? [dubbo-getty]

2024-04-11 Thread via GitHub
No-SilverBullet commented on issue #116: URL: https://github.com/apache/dubbo-getty/issues/116#issuecomment-2050834579 > > > > 再补充一下这个 issue。当连接数超过 provider 上限之后,TCP 连接能够完成,但是服务端会马上主动断开连接。针对这种情况我认为是需要避免重新连接的。期待回复,谢谢。

[PR] fix: Bytebuf resource leak [dubbo]

2024-04-11 Thread via GitHub
aofall opened a new pull request, #14071: URL: https://github.com/apache/dubbo/pull/14071 ## What is the purpose of the change fix #14070 Netty will automatically release the reference-counted object when calling the `channel.flush()` method usually. The

Re: [I] 请问可以利用java dubbo3+版本泛化调用至【Apache Dubbo-js 4.0.0 released】提供的dubbo接口吗? [dubbo-js]

2024-04-11 Thread via GitHub
mrwangyin commented on issue #393: URL: https://github.com/apache/dubbo-js/issues/393#issuecomment-2050825616 我这边测试,上图中的使用Nacos注册中心时,dubbo js consumer 无法调用至 dubbo java provider ,但是切换为Zookeeper注册中心时,又能调用成功; -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] 请问可以利用java dubbo3+版本泛化调用至【Apache Dubbo-js 4.0.0 released】提供的dubbo接口吗? [dubbo-js]

2024-04-11 Thread via GitHub
mrwangyin commented on issue #393: URL: https://github.com/apache/dubbo-js/issues/393#issuecomment-2050824650 ![dubbojs](https://github.com/apache/dubbo-js/assets/44059656/8065dc2b-0c68-4186-9c28-a6ec8633fba7) 请问图中红色需求,当前dubbo-js能支持吗?那个版本能支持? -- This is an automated message from the

Re: [PR] build(deps): bump idna from 2.8 to 3.7 in /samples/bookinfo/src/productpage [dubbo-go-pixiu]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #620: URL: https://github.com/apache/dubbo-go-pixiu/pull/620#issuecomment-2050717150 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] build(deps): bump idna from 2.8 to 3.7 in /samples/bookinfo/src/productpage [dubbo-go-pixiu]

2024-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #620: URL: https://github.com/apache/dubbo-go-pixiu/pull/620 Bumps [idna](https://github.com/kjd/idna) from 2.8 to 3.7. Release notes Sourced from https://github.com/kjd/idna/releases;>idna's releases. v3.7 What's Changed

[PR] Bump org.eclipse.jgit:org.eclipse.jgit from 5.7.0.202003090808-r to 5.13.3.202401111512-r [dubbo-initializer]

2024-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #36: URL: https://github.com/apache/dubbo-initializer/pull/36 Bumps org.eclipse.jgit:org.eclipse.jgit from 5.7.0.202003090808-r to 5.13.3.20240512-r. [![Dependabot compatibility

Re: [I] 请问可以利用java dubbo3+版本泛化调用至【Apache Dubbo-js 4.0.0 released】提供的dubbo接口吗? [dubbo-js]

2024-04-11 Thread via GitHub
mrwangyin commented on issue #393: URL: https://github.com/apache/dubbo-js/issues/393#issuecomment-2050110332 或者说java dubbo3泛化调用至其他版本的dubbojs服务端? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[I] 请问可以利用java dubbo3+版本泛化调用至【Apache Dubbo-js 4.0.0 released】提供的dubbo接口吗? [dubbo-js]

2024-04-11 Thread via GitHub
mrwangyin opened a new issue, #393: URL: https://github.com/apache/dubbo-js/issues/393 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] memory leak when press test [dubbo]

2024-04-11 Thread via GitHub
aofall commented on issue #13244: URL: https://github.com/apache/dubbo/issues/13244#issuecomment-2049943687 I think this maybe a stress test beyond what the application could handle, causing a full gc, netty will automatic released related resource otherwise . You can try observe the JVM

Re: [I] Is it correct to continue to maintain the connection pool when a connection encounters an error? [dubbo-getty]

2024-04-11 Thread via GitHub
AlexStocks commented on issue #116: URL: https://github.com/apache/dubbo-getty/issues/116#issuecomment-2049800060 > > > 再补充一下这个 issue。当连接数超过 provider 上限之后,TCP 连接能够完成,但是服务端会马上主动断开连接。针对这种情况我认为是需要避免重新连接的。期待回复,谢谢。

Re: [PR] Task #13958 Move Rest Protocol to SPI Extensions [dubbo]

2024-04-11 Thread via GitHub
wcy666103 commented on PR #14061: URL: https://github.com/apache/dubbo/pull/14061#issuecomment-2049774879 After discussion, it is appropriate to move these three tests to `apache/dubbo-integration-cases`. Thanks for your help @oxsean -- This is an automated message from the Apache Git

Re: [PR] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]

2024-04-11 Thread via GitHub
heliang666s commented on PR #14069: URL: https://github.com/apache/dubbo/pull/14069#issuecomment-2049734397 Yes,I clone dubbo-samples code,I find the same problem.@wcy666103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]

2024-04-11 Thread via GitHub
wcy666103 commented on PR #14069: URL: https://github.com/apache/dubbo/pull/14069#issuecomment-2049725611 This error is due to the version definition problem of dubbo-samples project with Dubbo-samples-meshrule-router Supported component versions of the test case, It can be asked if it is

Re: [PR] feat:remove old zookeeper [dubbo]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #14028: URL: https://github.com/apache/dubbo/pull/14028#issuecomment-2049717486 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #2654: URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2049715212 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HTTP/3 support for dubbo triple [dubbo]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #14033: URL: https://github.com/apache/dubbo/pull/14033#issuecomment-2049685467 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #14069: URL: https://github.com/apache/dubbo/pull/14069#issuecomment-2049679632 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [I] spring parse config failed [dubbo]

2024-04-11 Thread via GitHub
cnzakii commented on issue #12806: URL: https://github.com/apache/dubbo/issues/12806#issuecomment-2049674168 @AlbumenJ I need to confirm whether these configuration format is allowed: `dubbo.application.metadata.publish.delay=1000` `dubbo.application.metadata.proxy.delay=1000`

[I] [Bug] Memory leak in TripleServerStream.ServerTransportObserver#doOnData [dubbo]

2024-04-11 Thread via GitHub
PaulTan94 opened a new issue, #14070: URL: https://github.com/apache/dubbo/issues/14070 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the

[PR] fix : fix test case [dubbo-go]

2024-04-11 Thread via GitHub
YarBor opened a new pull request, #2660: URL: https://github.com/apache/dubbo-go/pull/2660 It always failed in CI #2659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] fix : fix test case [dubbo-go]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #2660: URL: https://github.com/apache/dubbo-go/pull/2660#issuecomment-2049632662 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [I] [Task] All samples support builds and launches with jar or native-image [dubbo]

2024-04-11 Thread via GitHub
heliang666s commented on issue #13861: URL: https://github.com/apache/dubbo/issues/13861#issuecomment-2049624628 ![图片](https://github.com/apache/dubbo/assets/147408835/712db05d-8b7d-4b61-a898-48f2dc228453) Why the first and third file is package instead of module?Is this deliberate or a

[I] Test case bug, a contradiction in its logic. [dubbo-go]

2024-04-11 Thread via GitHub
YarBor opened a new issue, #2659: URL: https://github.com/apache/dubbo-go/issues/2659 ### Environment - Server: Dubbo-go, v3.1.1 - Client: Dubbo-go, v3.1.1 ### Issue description When submitting PR, there is a certain probability that this test case will go wrong.

[PR] Feat/curator5 zookeeper transporter remove [dubbo-samples]

2024-04-11 Thread via GitHub
Stellar1999 opened a new pull request, #1131: URL: https://github.com/apache/dubbo-samples/pull/1131 refer: [#14028](https://github.com/apache/dubbo/pull/14028) This is a part of PR **feat:Remove zk3.4 support in 3.3** -- This is an automated message from the Apache Git Service. To

[PR] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]

2024-04-11 Thread via GitHub
heliang666s opened a new pull request, #14069: URL: https://github.com/apache/dubbo/pull/14069 ## What is the purpose of the change [Feature] Move Mesh Rule Router to SPI Extensions ## Brief changelog * copy all the related classes to

[PR] fix test lib [dubbo-spi-extensions]

2024-04-11 Thread via GitHub
wcy666103 opened a new pull request, #310: URL: https://github.com/apache/dubbo-spi-extensions/pull/310 ## What is the purpose of the change Many tests were not run due to the low junit api version ## Brief changelog Two pom files were modified to update their versions

[PR] complete dynamic config page [dubbo-kubernetes]

2024-04-11 Thread via GitHub
jianyi-gronk opened a new pull request, #261: URL: https://github.com/apache/dubbo-kubernetes/pull/261 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix: After the streaming call ends, client response.tailer() returns empty #2656 [dubbo-go]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #2658: URL: https://github.com/apache/dubbo-go/pull/2658#issuecomment-2049431141 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Feature metrics support otlp 3.3 [dubbo]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #14067: URL: https://github.com/apache/dubbo/pull/14067#issuecomment-2049396299 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix: After the streaming call ends, client response.tailer() returns empty #2656 [dubbo-go]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #2658: URL: https://github.com/apache/dubbo-go/pull/2658#issuecomment-2049368750 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Fix: After the streaming call ends, client response.tailer() returns empty #2656 [dubbo-go]

2024-04-11 Thread via GitHub
YarBor opened a new pull request, #2658: URL: https://github.com/apache/dubbo-go/pull/2658 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] fix : fix_StreamCall_Tailer [dubbo-go]

2024-04-11 Thread via GitHub
YarBor closed pull request #2657: fix : fix_StreamCall_Tailer URL: https://github.com/apache/dubbo-go/pull/2657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Sync BitList for all the operations [dubbo]

2024-04-11 Thread via GitHub
oxsean commented on code in PR #14057: URL: https://github.com/apache/dubbo/pull/14057#discussion_r1560775056 ## dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/state/BitList.java: ## @@ -93,23 +93,23 @@ public BitList(List originList, BitSet rootSet, List

Re: [PR] fix : fix_StreamCall_Tailer [dubbo-go]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #2657: URL: https://github.com/apache/dubbo-go/pull/2657#issuecomment-2049356924 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] fix : fix_StreamCall_Tailer [dubbo-go]

2024-04-11 Thread via GitHub
YarBor opened a new pull request, #2657: URL: https://github.com/apache/dubbo-go/pull/2657 fix issue : #2656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] fix : fix_StreamCall_Tailer [dubbo-go]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #2657: URL: https://github.com/apache/dubbo-go/pull/2657#issuecomment-2049358646 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [I] metrics need to merge old and new implementations [dubbo]

2024-04-11 Thread via GitHub
wxbty commented on issue #11953: URL: https://github.com/apache/dubbo/issues/11953#issuecomment-2049333732 > Prometheus protocol It turns out that the MetricsFilter of the Dubbo-Monitor module includes the data export function of the custom Protocol. It has been removed in version

Re: [I] [Feature][3.3] Triple http limiting the size of the HTTP request and response [dubbo]

2024-04-11 Thread via GitHub
finefuture commented on issue #14068: URL: https://github.com/apache/dubbo/issues/14068#issuecomment-2049323257 I'm working on it, please assign it to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[I] [Feature][3.3] Triple http limiting the size of the HTTP request and response [dubbo]

2024-04-11 Thread via GitHub
oxsean opened a new issue, #14068: URL: https://github.com/apache/dubbo/issues/14068 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the

[PR] Feature metrics support otlp 3.3 [dubbo]

2024-04-11 Thread via GitHub
glmapper opened a new pull request, #14067: URL: https://github.com/apache/dubbo/pull/14067 cheery pick from this pr : https://github.com/apache/dubbo/pull/14050 to 3.3 branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] [Feature][3.3] CORS support for triple rest protocol [dubbo]

2024-04-11 Thread via GitHub
Rawven commented on issue #13965: URL: https://github.com/apache/dubbo/issues/13965#issuecomment-2049311237 # Triple Rest Cors Plan ### 1. **Cors related implementation** Under the rest/cors package of dubbo-rpc-triple module CorsMeta configuration class currently

Re: [PR] upgrade 3.2.12 to 3.2.13-SNAPSHOT [dubbo]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #14066: URL: https://github.com/apache/dubbo/pull/14066#issuecomment-2049297914 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Task] All samples unified switch to annotation + yaml configuration … [dubbo-samples]

2024-04-11 Thread via GitHub
CrazyHZM commented on code in PR #1128: URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1560697795 ## 10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-filter-provider/src/main/resources/application.yml: ## @@ -0,0 +1,31 @@ +# Licensed to the

Re: [PR] [Task] All samples unified switch to annotation + yaml configuration … [dubbo-samples]

2024-04-11 Thread via GitHub
cnzakii commented on code in PR #1128: URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1556786592 ## 10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-filter-provider/src/main/resources/application.yml: ## @@ -0,0 +1,31 @@ +# Licensed to the

Re: [PR] feat:remove old zookeeper [dubbo]

2024-04-11 Thread via GitHub
CrazyHZM commented on PR #14028: URL: https://github.com/apache/dubbo/pull/14028#issuecomment-2049258719 @Stellar1999 We should keep the dubbo-remoting-zookeeper-curator5 module and move the dubbo-remoting-zookeeper-api module into it. -- This is an automated message from the Apache

Re: [PR] [Task] All samples unified switch to annotation + yaml configuration … [dubbo-samples]

2024-04-11 Thread via GitHub
cnzakii commented on code in PR #1128: URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1560690409 ## 10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-filter-provider/src/main/resources/application.yml: ## @@ -0,0 +1,31 @@ +# Licensed to the

Re: [PR] [Task] All samples unified switch to annotation + yaml configuration … [dubbo-samples]

2024-04-11 Thread via GitHub
CrazyHZM commented on code in PR #1128: URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1560681265 ## 10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-filter-provider/src/main/resources/application.yml: ## @@ -0,0 +1,31 @@ +# Licensed to the

Re: [PR] merge 3.2.12-release to 3.2 [dubbo]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #14065: URL: https://github.com/apache/dubbo/pull/14065#issuecomment-2049241829 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] upgrade 3.2.12 to 3.2.13-SNAPSHOT [dubbo]

2024-04-11 Thread via GitHub
AlbumenJ merged PR #14066: URL: https://github.com/apache/dubbo/pull/14066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] upgrade 3.2.12 to 3.2.13-SNAPSHOT [dubbo]

2024-04-11 Thread via GitHub
aamingaa opened a new pull request, #14066: URL: https://github.com/apache/dubbo/pull/14066 upgrade 3.2.12 to 3.2.13-SNAPSHOT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] metrics need to merge old and new implementations [dubbo]

2024-04-11 Thread via GitHub
wcy666103 commented on issue #11953: URL: https://github.com/apache/dubbo/issues/11953#issuecomment-2049214770 I'm willing to do that ,May you give me more detail for this task? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]

2024-04-11 Thread via GitHub
heliang666s closed pull request #14058: [Feature] Move Mesh Rule Router to SPI Extensions URL: https://github.com/apache/dubbo/pull/14058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]

2024-04-11 Thread via GitHub
heliang666s commented on PR #14058: URL: https://github.com/apache/dubbo/pull/14058#issuecomment-2049189736 ok,thanks~@wcy666103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Optimize the structure of dubbo [dubbo-rust]

2024-04-11 Thread via GitHub
yang20150702 closed issue #189: Optimize the structure of dubbo URL: https://github.com/apache/dubbo-rust/issues/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Ftr: merge some mod to dubbo [dubbo-rust]

2024-04-11 Thread via GitHub
yang20150702 commented on PR #188: URL: https://github.com/apache/dubbo-rust/pull/188#issuecomment-2049185963 https://github.com/apache/dubbo-rust/issues/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Ftr: merge some mod to dubbo [dubbo-rust]

2024-04-11 Thread via GitHub
yang20150702 merged PR #188: URL: https://github.com/apache/dubbo-rust/pull/188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Is it correct to continue to maintain the connection pool when a connection encounters an error? [dubbo-getty]

2024-04-11 Thread via GitHub
No-SilverBullet commented on issue #116: URL: https://github.com/apache/dubbo-getty/issues/116#issuecomment-2049178642 > > 再补充一下这个 issue。当连接数超过 provider 上限之后,TCP 连接能够完成,但是服务端会马上主动断开连接。针对这种情况我认为是需要避免重新连接的。期待回复,谢谢。

Re: [PR] merge 3.2.12-release to 3.2 [dubbo]

2024-04-11 Thread via GitHub
AlbumenJ merged PR #14065: URL: https://github.com/apache/dubbo/pull/14065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] merge 3.2.12-release to 3.2 [dubbo]

2024-04-11 Thread via GitHub
aamingaa opened a new pull request, #14065: URL: https://github.com/apache/dubbo/pull/14065 merge 3.2.12-release to 3.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]

2024-04-11 Thread via GitHub
wcy666103 commented on PR #14058: URL: https://github.com/apache/dubbo/pull/14058#issuecomment-2049144984 You should do the migration on the `3.3` branch, not `3.2`. You can create a new pr and close this pr after doing the work on the 3.3 branch -- This is an automated message from the

Re: [I] Is it correct to continue to maintain the connection pool when a connection encounters an error? [dubbo-getty]

2024-04-11 Thread via GitHub
AlexStocks commented on issue #116: URL: https://github.com/apache/dubbo-getty/issues/116#issuecomment-2049126828 > 再补充一下这个 issue。当连接数超过 provider 上限之后,TCP 连接能够完成,但是服务端会马上主动断开连接。针对这种情况我认为是需要避免重新连接的。期待回复,谢谢。

Re: [PR] Task #13958 Move Rest Protocol to SPI Extensions [dubbo]

2024-04-11 Thread via GitHub
wcy666103 closed pull request #14055: Task #13958 Move Rest Protocol to SPI Extensions URL: https://github.com/apache/dubbo/pull/14055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Task #13958 Move Rest Protocol to SPI Extensions [dubbo]

2024-04-11 Thread via GitHub
wcy666103 commented on PR #14055: URL: https://github.com/apache/dubbo/pull/14055#issuecomment-2049115756 These works are applied to branch 3.3 [https://github.com/apache/dubbo/pull/14061](https://github.com/apache/dubbo/pull/14061),I will close this pr -- This is an automated message

Re: [PR] Task #13958 Move Rest Protocol to SPI Extensions [dubbo]

2024-04-11 Thread via GitHub
wcy666103 commented on PR #14061: URL: https://github.com/apache/dubbo/pull/14061#issuecomment-2049113009 There are three things to note: 1. I deleted rest related classes from `dubbo-compatible ` module because they are hard dependencies 2. The `dubbo-plugin/dubbo-rest-jaxrs` module

Re: [PR] Task #13958 Move Rest Protocol to SPI Extensions [dubbo]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #14061: URL: https://github.com/apache/dubbo/pull/14061#issuecomment-2049095576 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

2024-04-11 Thread via GitHub
sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2049073671 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Bump dubbo samples springcloud to jdk17 and springboot3.2.3 [dubbo-samples]

2024-04-11 Thread via GitHub
chi3316 opened a new pull request, #1130: URL: https://github.com/apache/dubbo-samples/pull/1130 - Update related dependencies in dubbo-samples-springcloud - Resolve logging conflicts in dubbo-samples-environment and update dubbo-zookeeper-curator5-spring-boot-starter version in