Re: [I] Zookeeper need catch exception when write failed [dubbo]

2024-04-29 Thread via GitHub
walkinggo commented on issue #12941: URL: https://github.com/apache/dubbo/issues/12941#issuecomment-2084476678 is there done?i want to try it if nobody want do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]

2024-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#issuecomment-2084347518 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]

2024-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#issuecomment-2084330032 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] Fix non-idempotent unit test `ClassGeneratorTest.testMain` [dubbo]

2024-04-29 Thread via GitHub
kaiyaok2 commented on PR #14135: URL: https://github.com/apache/dubbo/pull/14135#issuecomment-2084295603 @chickenlj @EarthChen @AlbumenJ Please also let me know if I shall include fixes to other non-idempotent tests (all relatively simple, including resetting some shared states) -- Thi

[I] [Bug] ContextHolderAuthenticationResolverFilter序列化异常 [dubbo]

2024-04-29 Thread via GitHub
javacctvnews opened a new issue, #14145: URL: https://github.com/apache/dubbo/issues/14145 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues

Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]

2024-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#issuecomment-2084271545 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]

2024-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#issuecomment-2084266787 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]

2024-04-29 Thread via GitHub
mark4z closed pull request #629: Upgrade dubbo-go to v3.1.1 URL: https://github.com/apache/dubbo-go-pixiu/pull/629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]

2024-04-29 Thread via GitHub
mark4z opened a new pull request, #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630 **What this PR does**: **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**: ```

Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]

2024-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #629: URL: https://github.com/apache/dubbo-go-pixiu/pull/629#issuecomment-2084263015 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

[PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]

2024-04-29 Thread via GitHub
mark4z opened a new pull request, #629: URL: https://github.com/apache/dubbo-go-pixiu/pull/629 **What this PR does**: **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**: ```

Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu-samples]

2024-04-29 Thread via GitHub
mark4z merged PR #53: URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu-samples]

2024-04-29 Thread via GitHub
mark4z opened a new pull request, #53: URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/53 **What this PR does**: **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**:

Re: [PR] upgrade dubbogo version: 3.1.1 [dubbo-go-pixiu]

2024-04-29 Thread via GitHub
mark4z closed pull request #612: upgrade dubbogo version: 3.1.1 URL: https://github.com/apache/dubbo-go-pixiu/pull/612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Hookokoko/develop [dubbo-go-pixiu]

2024-04-29 Thread via GitHub
mark4z closed pull request #626: Hookokoko/develop URL: https://github.com/apache/dubbo-go-pixiu/pull/626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[I] [Bug] Dubbo 版本 3.2.2 JDK 版本 17 使用 tolist 报错 [dubbo]

2024-04-29 Thread via GitHub
DIDA-lJ opened a new issue, #14144: URL: https://github.com/apache/dubbo/issues/14144 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=is

Re: [PR] Remove unused seata proxy [dubbo-go-pixiu]

2024-04-29 Thread via GitHub
mark4z merged PR #628: URL: https://github.com/apache/dubbo-go-pixiu/pull/628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [I] github.com/opentrx/seata-golang/v2 unknown revision v2.0.5 [dubbo-go-pixiu]

2024-04-29 Thread via GitHub
mark4z closed issue #627: github.com/opentrx/seata-golang/v2 unknown revision v2.0.5 URL: https://github.com/apache/dubbo-go-pixiu/issues/627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] complete Dubbo for Node.js ->Getting started & Implementing services pages #368 [dubbo-js]

2024-04-29 Thread via GitHub
jianyi-gronk commented on code in PR #394: URL: https://github.com/apache/dubbo-js/pull/394#discussion_r1583393396 ## docs/guide/dubboForNode/GettingStarted.md: ## Review Comment: refer to example/dubbo-node-example/README.md ## docs/guide/dubboForNode/GettingSta

Re: [PR] complete Dubbo for Node.js ->Getting started & Implementing services pages #368 [dubbo-js]

2024-04-29 Thread via GitHub
jianyi-gronk commented on code in PR #394: URL: https://github.com/apache/dubbo-js/pull/394#discussion_r1583380343 ## docs/guide/dubboForNode/GettingStarted.md: ## @@ -1 +1,295 @@ -# GettingStarted +# Getting started + +Dubbo-Node is a library for serving Dubbo, gRPC, and gRPC-W

Re: [I] [Bug] The actual number of connections established is twice what I configured [dubbo]

2024-04-29 Thread via GitHub
walkinggo commented on issue #14129: URL: https://github.com/apache/dubbo/issues/14129#issuecomment-2083103290 i can see the number of connections in DubboProtocol#getClients and it's normal.can u provide more information?i can't reproduce this bug. -- This is an automated message from th

Re: [PR] Triple protocol http1 upgrade support [dubbo]

2024-04-29 Thread via GitHub
oxsean commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2082989318 LGTM, but have you tested no impact to dubbo protocol? And It would be good to place your test as a unit test in the Dubbo project, or you could put it in the integration tests as well:

Re: [PR] Remove unused seata proxy [dubbo-go-pixiu]

2024-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #628: URL: https://github.com/apache/dubbo-go-pixiu/pull/628#issuecomment-2082984552 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

[PR] Remove unused seata proxy [dubbo-go-pixiu]

2024-04-29 Thread via GitHub
mark4z opened a new pull request, #628: URL: https://github.com/apache/dubbo-go-pixiu/pull/628 **What this PR does**: **Which issue(s) this PR fixes**: Fixes #627 **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**:

Re: [PR] Fix netty memory leak [dubbo]

2024-04-29 Thread via GitHub
oxsean commented on code in PR #14127: URL: https://github.com/apache/dubbo/pull/14127#discussion_r1583086955 ## dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http2/GenericHttp2ServerTransportListener.java: ## @@ -164,7 +165,7 @@ protected void o

Re: [PR] Fix netty memory leak [dubbo]

2024-04-29 Thread via GitHub
oxsean commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2082719092 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[I] spring boot yml configuration,The qos.enable configuration is not effective, but the qos.port configuration is effective [dubbo]

2024-04-29 Thread via GitHub
pyshiweijia opened a new issue, #14143: URL: https://github.com/apache/dubbo/issues/14143 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?

Re: [PR] feat: add some application and instance APIs [dubbo-kubernetes]

2024-04-29 Thread via GitHub
chickenlj merged PR #265: URL: https://github.com/apache/dubbo-kubernetes/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] complete dynamic config [dubbo-kubernetes]

2024-04-29 Thread via GitHub
chickenlj merged PR #266: URL: https://github.com/apache/dubbo-kubernetes/pull/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] update: compatible dubbo 3.0.x [dubbo-spi-extensions]

2024-04-29 Thread via GitHub
codecov-commenter commented on PR #336: URL: https://github.com/apache/dubbo-spi-extensions/pull/336#issuecomment-2082291298 ## [Codecov](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/336?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&u

[PR] update: compatible dubbo 3.0.x [dubbo-spi-extensions]

2024-04-29 Thread via GitHub
aofall opened a new pull request, #336: URL: https://github.com/apache/dubbo-spi-extensions/pull/336 ## What is the purpose of the change 1. Use `rivision` tag manager version and Bump version to 3.0.0-SNAPSHOT 2. Cherry pick bug fix from master branch 3. fix test case failed

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.13 to 1.14.14 [dubbo]

2024-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #14142: URL: https://github.com/apache/dubbo/pull/14142#issuecomment-2082088648 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Bump bytebuddy.version from 1.14.13 to 1.14.14 [dubbo]

2024-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #14140: URL: https://github.com/apache/dubbo/pull/14140#issuecomment-2082086924 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Bump org.apache.maven.plugins:maven-shade-plugin from 3.5.2 to 3.5.3 [dubbo]

2024-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #14141: URL: https://github.com/apache/dubbo/pull/14141#issuecomment-2082086655 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

[PR] Bump net.bytebuddy:byte-buddy from 1.14.13 to 1.14.14 [dubbo]

2024-04-29 Thread via GitHub
dependabot[bot] opened a new pull request, #14142: URL: https://github.com/apache/dubbo/pull/14142 Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.14.13 to 1.14.14. Release notes Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:

[PR] Bump org.apache.maven.plugins:maven-shade-plugin from 3.5.2 to 3.5.3 [dubbo]

2024-04-29 Thread via GitHub
dependabot[bot] opened a new pull request, #14141: URL: https://github.com/apache/dubbo/pull/14141 Bumps [org.apache.maven.plugins:maven-shade-plugin](https://github.com/apache/maven-shade-plugin) from 3.5.2 to 3.5.3. Commits https://github.com/apache/maven-shade-plugin/commit

[PR] Bump bytebuddy.version from 1.14.13 to 1.14.14 [dubbo]

2024-04-29 Thread via GitHub
dependabot[bot] opened a new pull request, #14140: URL: https://github.com/apache/dubbo/pull/14140 Bumps `bytebuddy.version` from 1.14.13 to 1.14.14. Updates `net.bytebuddy:byte-buddy` from 1.14.13 to 1.14.14 Release notes Sourced from https://github.com/raphw/byte-buddy/releases