Re: [PR] catch the warning and ignore when childUrl is not json. [dubbo]

2024-05-06 Thread via GitHub
walkinggo commented on PR #14157: URL: https://github.com/apache/dubbo/pull/14157#issuecomment-2097484359 so i close it and try to create a new one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] catch the warning and ignore when childUrl is not json. [dubbo]

2024-05-06 Thread via GitHub
walkinggo commented on PR #14157: URL: https://github.com/apache/dubbo/pull/14157#issuecomment-2097483966 this pr didn't obey the code format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] catch the warning and ignore when childUrl is not json. [dubbo]

2024-05-06 Thread via GitHub
walkinggo closed pull request #14157: catch the warning and ignore when childUrl is not json. URL: https://github.com/apache/dubbo/pull/14157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix netty memory leak [dubbo]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2097379931 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2097378464 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] delete_rpc_rest [dubbo]

2024-05-06 Thread via GitHub
finefuture commented on code in PR #14084: URL: https://github.com/apache/dubbo/pull/14084#discussion_r1591765587 ## dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/bootstrap/DubboBootstrapTest.java: ## @@ -1,406 +0,0 @@ -/* Review Comment: Why were

Re: [PR] delete_rpc_rest [dubbo]

2024-05-06 Thread via GitHub
finefuture commented on PR #14084: URL: https://github.com/apache/dubbo/pull/14084#issuecomment-2097371642 Please resolve the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [Bug] nacos tests timeout and dubbo-samples-test-13787 caseSpecificVersion led to the failure of the integration tests [dubbo]

2024-05-06 Thread via GitHub
FoghostCn commented on issue #14158: URL: https://github.com/apache/dubbo/issues/14158#issuecomment-2097254669 The case-versions.conf configuration file describes the dubbo version that is expected to run. It will not run when your version does not match. so if you use

Re: [PR] fix(3.2): ReactorDubbo3TripleStub.mustache add schema registry [dubbo]

2024-05-06 Thread via GitHub
caoyanan666 commented on PR #14035: URL: https://github.com/apache/dubbo/pull/14035#issuecomment-2097228030 @AlbumenJ PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] feat:remove old zookeeper [dubbo]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #14028: URL: https://github.com/apache/dubbo/pull/14028#issuecomment-2097221626 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[I] [Bug] nacos tests timeout and dubbo-samples-test-13787 caseSpecificVersion led to the failure of the integration tests [dubbo]

2024-05-06 Thread via GitHub
jkoChen opened a new issue, #14158: URL: https://github.com/apache/dubbo/issues/14158 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the

[PR] catch the warning and ignore when childUrl is not json. [dubbo]

2024-05-06 Thread via GitHub
walkinggo opened a new pull request, #14157: URL: https://github.com/apache/dubbo/pull/14157 ## What is the purpose of the change catch the exception when the url can't be deserialization.[issue12941](https://github.com/apache/dubbo/issues/12941) ## Brief changelog add the

Re: [PR] optimise: create http client by connection pool [dubbo]

2024-05-06 Thread via GitHub
suncairong163 commented on PR #14079: URL: https://github.com/apache/dubbo/pull/14079#issuecomment-2096038700 > > > * For [OkHttpClient should use connection pool  #13596](https://github.com/apache/dubbo/issues/13596) > > > > > > You can dowload the task error log,and query

Re: [PR] fix the signature error when using reflection to access the org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation method [dubbo]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #14156: URL: https://github.com/apache/dubbo/pull/14156#issuecomment-2096007979 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] fix the signature error when using reflection to access the org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation method [dubbo]

2024-05-06 Thread via GitHub
jkoChen opened a new pull request, #14156: URL: https://github.com/apache/dubbo/pull/14156 Fixes https://github.com/apache/dubbo/issues/14104. ## The Problem The method `org.apache.dubbo.config.spring.util.AnnotationUtils#tryGetMergedAnnotation` utilizes reflection to access

Re: [PR] fix the signature error when using reflection to access the org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation method [dubbo]

2024-05-06 Thread via GitHub
jkoChen closed pull request #14152: fix the signature error when using reflection to access the org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation method URL: https://github.com/apache/dubbo/pull/14152 -- This is an automated message from the Apache Git Service.

Re: [PR] test: test case [dubbo]

2024-05-06 Thread via GitHub
jkoChen closed pull request #14155: test: test case URL: https://github.com/apache/dubbo/pull/14155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] test: test case [dubbo]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #14155: URL: https://github.com/apache/dubbo/pull/14155#issuecomment-2095695217 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] test: test case [dubbo]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #14155: URL: https://github.com/apache/dubbo/pull/14155#issuecomment-2095692676 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] test: test case [dubbo]

2024-05-06 Thread via GitHub
jkoChen opened a new pull request, #14155: URL: https://github.com/apache/dubbo/pull/14155 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a

Re: [I] [Bug] ContextHolderAuthenticationResolverFilter序列化异常 [dubbo]

2024-05-06 Thread via GitHub
FoghostCn commented on issue #14145: URL: https://github.com/apache/dubbo/issues/14145#issuecomment-2095574793 plz provide a demo project to reproduce -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [Feature] maven中央仓库还没有3.2.12版本的dubbo [dubbo]

2024-05-06 Thread via GitHub
FoghostCn commented on issue #14107: URL: https://github.com/apache/dubbo/issues/14107#issuecomment-2095567477 https://central.sonatype.com/artifact/org.apache.dubbo/dubbo/3.2.12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] [Feature] maven中央仓库还没有3.2.12版本的dubbo [dubbo]

2024-05-06 Thread via GitHub
FoghostCn closed issue #14107: [Feature] maven中央仓库还没有3.2.12版本的dubbo URL: https://github.com/apache/dubbo/issues/14107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] optimise: create http client by connection pool [dubbo]

2024-05-06 Thread via GitHub
yuluo-yx commented on PR #14079: URL: https://github.com/apache/dubbo/pull/14079#issuecomment-2095534006 > > * For [OkHttpClient should use connection pool  #13596](https://github.com/apache/dubbo/issues/13596) > > You can dowload the task error log,and query "error" keyword to find

Re: [PR] optimise: create http client by connection pool [dubbo]

2024-05-06 Thread via GitHub
suncairong163 commented on PR #14079: URL: https://github.com/apache/dubbo/pull/14079#issuecomment-2095485095 > * For [OkHttpClient should use connection pool  #13596](https://github.com/apache/dubbo/issues/13596) You can dowload the task error log,and query "error" keyword to find

Re: [PR] test: add yaml loadAs test [dubbo]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #14080: URL: https://github.com/apache/dubbo/pull/14080#issuecomment-2095421684 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] test: add yaml loadAs test [dubbo]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #14080: URL: https://github.com/apache/dubbo/pull/14080#issuecomment-2095389260 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Bump org.apache.maven.plugin-tools:maven-plugin-annotations from 3.12.0 to 3.13.0 [dubbo]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #14154: URL: https://github.com/apache/dubbo/pull/14154#issuecomment-2095384293 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Bump jackson_version from 2.17.0 to 2.17.1 [dubbo]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #14153: URL: https://github.com/apache/dubbo/pull/14153#issuecomment-2095383847 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] optimise: create http client by connection pool [dubbo]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #14079: URL: https://github.com/apache/dubbo/pull/14079#issuecomment-2095382932 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] 3.3 dev xds security [dubbo]

2024-05-06 Thread via GitHub
Tomoko-hjf closed pull request #14150: 3.3 dev xds security URL: https://github.com/apache/dubbo/pull/14150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] [Bug] rmi protocol doesnot work for threads ,iothreads etc.. [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ closed issue #14089: [Bug] rmi protocol doesnot work for threads ,iothreads etc.. URL: https://github.com/apache/dubbo/issues/14089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump com.alibaba.fastjson2:fastjson2 from 2.0.48 to 2.0.49 [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ merged PR #14087: URL: https://github.com/apache/dubbo/pull/14087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update .ignore to exclude log files. [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ commented on PR #14064: URL: https://github.com/apache/dubbo/pull/14064#issuecomment-2095334251 > @AlbumenJ would you please merge this PR to (apache:3.3)? done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] feat:remove old zookeeper [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ commented on PR #14028: URL: https://github.com/apache/dubbo/pull/14028#issuecomment-2095327569 ![image](https://github.com/apache/dubbo/assets/9292748/5bef8e3d-43c6-4406-9e2c-4169bf0afacd) -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] test: add yaml loadAs test [dubbo]

2024-05-06 Thread via GitHub
yuluo-yx commented on PR #14080: URL: https://github.com/apache/dubbo/pull/14080#issuecomment-2095325131 > The background of this feature is that snakeyaml supports including class names within the content. Therefore, it's intended to test and verify that classes configured on the

[PR] Bump org.apache.maven.plugin-tools:maven-plugin-annotations from 3.12.0 to 3.13.0 [dubbo]

2024-05-06 Thread via GitHub
dependabot[bot] opened a new pull request, #14154: URL: https://github.com/apache/dubbo/pull/14154 Bumps [org.apache.maven.plugin-tools:maven-plugin-annotations](https://github.com/apache/maven-plugin-tools) from 3.12.0 to 3.13.0. Commits

Re: [PR] Bump org.apache.maven.plugins:maven-plugin-plugin from 3.10.2 to 3.12.0 [dubbo]

2024-05-06 Thread via GitHub
dependabot[bot] commented on PR #14045: URL: https://github.com/apache/dubbo/pull/14045#issuecomment-2095320138 A newer version of org.apache.maven.plugins:maven-plugin-plugin exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR

[PR] Bump jackson_version from 2.17.0 to 2.17.1 [dubbo]

2024-05-06 Thread via GitHub
dependabot[bot] opened a new pull request, #14153: URL: https://github.com/apache/dubbo/pull/14153 Bumps `jackson_version` from 2.17.0 to 2.17.1. Updates `com.fasterxml.jackson.core:jackson-core` from 2.17.0 to 2.17.1 Commits

Re: [I] [Feature] [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ closed issue #14083: [Feature] URL: https://github.com/apache/dubbo/issues/14083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] remove the remoting-http [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ merged PR #14082: URL: https://github.com/apache/dubbo/pull/14082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat: Validator supports automatic switch [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ commented on PR #13923: URL: https://github.com/apache/dubbo/pull/13923#issuecomment-2095299510 > > A more conscise way is to use `org.apache.dubbo.common.extension.Activate#onClass` and create two filter for `javax` and `jakarta` > > @AlbumenJ I try to use

Re: [PR] fix:embedded-redis need update version to run on macos Sonoma [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ merged PR #14074: URL: https://github.com/apache/dubbo/pull/14074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug] RedisMetadataReportTest UnitTest Error [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ closed issue #14072: [Bug] RedisMetadataReportTest UnitTest Error URL: https://github.com/apache/dubbo/issues/14072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] fix:embedded-redis need update version to run on macos Sonoma [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ commented on PR #14074: URL: https://github.com/apache/dubbo/pull/14074#issuecomment-2095289694 Test pass in https://github.com/Stellar1999/dubbo/actions/runs/8797724351/job/24143774059 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Sync BitList for all the operations [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ merged PR #14057: URL: https://github.com/apache/dubbo/pull/14057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] spring parse config failed [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ commented on issue #12806: URL: https://github.com/apache/dubbo/issues/12806#issuecomment-2095258018 > @AlbumenJ I need to confirm whether these configurations are allowed to be set via `application.properties`: `dubbo.application.metadata.publish.delay=1000`

Re: [I] [Task] All samples support builds and launches with jar or native-image [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ commented on issue #13861: URL: https://github.com/apache/dubbo/issues/13861#issuecomment-2095249659 >

Re: [PR] Feature metrics support otlp 3.3 [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ commented on PR #14067: URL: https://github.com/apache/dubbo/pull/14067#issuecomment-2095248726 @songxiaosheng PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Feature metrics support otlp 3.3 [dubbo]

2024-05-06 Thread via GitHub
AlbumenJ commented on code in PR #14067: URL: https://github.com/apache/dubbo/pull/14067#discussion_r1590569842 ## dubbo-configcenter/dubbo-configcenter-apollo/pom.xml: ## @@ -54,6 +54,11 @@ dubbo-metrics-prometheus ${project.parent.version} + +