Re: [PR] Separate the code for indicator monitoring [dubbo]

2024-06-18 Thread via GitHub
walklown commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1644813721 ## dubbo-demo/dubbo-demo-xml/dubbo-demo-xml-provider/src/main/resources/spring/dubbo-provider.xml: ## @@ -29,7 +29,7 @@ - + Review Comment: C

[I] [Bug] Some test cases still rely on the REST protocol [dubbo]

2024-06-18 Thread via GitHub
walklown opened a new issue, #14340: URL: https://github.com/apache/dubbo/issues/14340 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=i

Re: [PR] Compatibility/java interop [dubbo-go]

2024-06-18 Thread via GitHub
SHA-4096 commented on code in PR #2687: URL: https://github.com/apache/dubbo-go/pull/2687#discussion_r1644560329 ## common/rpc_service.go: ## @@ -19,6 +19,7 @@ package common import ( "context" + "dubbo.apache.org/dubbo-go/v3/common/dubboutil" Review Comment:

Re: [PR] Compatibility/java interop [dubbo-go]

2024-06-18 Thread via GitHub
SHA-4096 commented on code in PR #2687: URL: https://github.com/apache/dubbo-go/pull/2687#discussion_r1644547269 ## server/server.go: ## @@ -180,6 +181,18 @@ func (s *Server) exportServices() (err error) { err = svcOpts.ExportWithoutInfo()

[I] [Feature] support Lambda parameter in remote method invoke [dubbo]

2024-06-18 Thread via GitHub
pgm-rookie opened a new issue, #14339: URL: https://github.com/apache/dubbo/issues/14339 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q

Re: [I] [Bug] Dubbo 3.2.11 , use dual registries(ZK+Nacos),provider defined timeout expires(consumer no timeout specified) [dubbo]

2024-06-18 Thread via GitHub
mrwangyin commented on issue #14336: URL: https://github.com/apache/dubbo/issues/14336#issuecomment-2176022506 @AlbumenJ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] upgrade opentelemetry and zipkin-reporter version [dubbo]

2024-06-18 Thread via GitHub
sonarcloud[bot] commented on PR #14338: URL: https://github.com/apache/dubbo/pull/14338#issuecomment-2176001290 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

[PR] upgrade [dubbo]

2024-06-18 Thread via GitHub
songxiaosheng opened a new pull request, #14338: URL: https://github.com/apache/dubbo/pull/14338 ## What is the purpose of the change ⬆️ upgrade zipkin-reporter -> 3.4.0] ⬆️ upgrade opentelemetry -> 1.39.0 ## Brief changelog ## Verifying this change

Re: [PR] impl Application, Instance and Service scenario rule configuration [dubbo-kubernetes]

2024-06-18 Thread via GitHub
chickenlj commented on PR #301: URL: https://github.com/apache/dubbo-kubernetes/pull/301#issuecomment-2175703176 Well done. This pull request can be merged once the core features are covered. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] feat:add metadata-samples [dubbo-spi-samples]

2024-06-18 Thread via GitHub
qyi71 commented on PR #12: URL: https://github.com/apache/dubbo-spi-samples/pull/12#issuecomment-2175620135 @heliang666s hello 看下你的loadbalance测试用例呗,失败了。。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [Bug] redis、consul、etcd not 'mapping' implementation [dubbo]

2024-06-18 Thread via GitHub
qyi71 commented on issue #14337: URL: https://github.com/apache/dubbo/issues/14337#issuecomment-2175614959 @AlbumenJ PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[I] [Bug] redis、consul、etcd not 'mapping' implementation [dubbo]

2024-06-18 Thread via GitHub
qyi71 opened a new issue, #14337: URL: https://github.com/apache/dubbo/issues/14337 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=is%3

Re: [PR] New metadata service [dubbo]

2024-06-18 Thread via GitHub
chickenlj commented on code in PR #14210: URL: https://github.com/apache/dubbo/pull/14210#discussion_r1644025989 ## dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/metadata/ServiceInstanceMetadataUtils.java: ## @@ -96,6 +96,8 @@ public class Serv

Re: [PR] feat: support prometheus new client of micrometer 1.13.0 version [dubbo]

2024-06-18 Thread via GitHub
qyi71 commented on PR #14269: URL: https://github.com/apache/dubbo/pull/14269#issuecomment-2175336181 @AlbumenJ PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns