Re: [PR] [fix] fix ci && Dubboctl deploy subcommand error fix [dubbo-kubernetes]

2024-06-21 Thread via GitHub
chickenlj merged PR #304: URL: https://github.com/apache/dubbo-kubernetes/pull/304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Implement communication with Dubbo Java and Dubbo Go [dubbo-js]

2024-06-21 Thread via GitHub
thegenius commented on issue #363: URL: https://github.com/apache/dubbo-js/issues/363#issuecomment-2182067941 我尝试了一下用dubbo-js连接dubbo-java, 发现Server received greet request null,是底层还有什么不支持的东西吗 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Separate the code for indicator monitoring [dubbo]

2024-06-21 Thread via GitHub
walklown commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1641662301 ## dubbo-demo/dubbo-demo-xml/dubbo-demo-xml-provider/src/main/resources/spring/dubbo-provider.xml: ## @@ -29,7 +29,7 @@ - + Review Comment:

Re: [I] [Bug] Dubbo 3.2.11 , use dual registries(ZK+Nacos),provider defined timeout expires(consumer no timeout specified) [dubbo]

2024-06-21 Thread via GitHub
AlbumenJ commented on issue #14336: URL: https://github.com/apache/dubbo/issues/14336#issuecomment-2177381327 Configure `timeout` on registry is meanless now. I think we should remove it in the future. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Bump ws from 5.2.2 to 5.2.4 in /initializer-page [dubbo-initializer]

2024-06-21 Thread via GitHub
AlbumenJ merged PR #38: URL: https://github.com/apache/dubbo-initializer/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug] Some test cases still rely on the REST protocol [dubbo]

2024-06-21 Thread via GitHub
wcy666103 commented on issue #14340: URL: https://github.com/apache/dubbo/issues/14340#issuecomment-2177400949 I think it's better to replace it with tri, extensions have their own samples repository, try not to mix it up? -- This is an automated message from the Apache Git Service. To

Re: [PR] dubbo-samples-rest-springmvc-1 [dubbo-samples]

2024-06-21 Thread via GitHub
chickenlj commented on PR #1121: URL: https://github.com/apache/dubbo-samples/pull/1121#issuecomment-2177391933 Rerun this pull request when https://github.com/apache/dubbo/pull/14334 is merged. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] feat: support prometheus new client of micrometer 1.13.0 version [dubbo]

2024-06-21 Thread via GitHub
AlbumenJ commented on PR #14269: URL: https://github.com/apache/dubbo/pull/14269#issuecomment-2177366784 ![image](https://github.com/apache/dubbo/assets/9292748/34f20462-d055-472e-ba4e-814359ca4fde) -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Bump org.apache.maven.plugins:maven-failsafe-plugin from 3.2.5 to 3.3.0 [dubbo]

2024-06-21 Thread via GitHub
AlbumenJ merged PR #14329: URL: https://github.com/apache/dubbo/pull/14329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Question] support Lambda parameter in remote method invoke [dubbo]

2024-06-21 Thread via GitHub
AlbumenJ closed issue #14339: [Question] support Lambda parameter in remote method invoke URL: https://github.com/apache/dubbo/issues/14339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [Bug] redis、consul、etcd not 'mapping' implementation [dubbo]

2024-06-21 Thread via GitHub
AlbumenJ commented on issue #14337: URL: https://github.com/apache/dubbo/issues/14337#issuecomment-2177367262 Can you please help imlement it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [Feature][3.3] Triple protocol support multi arguments [dubbo]

2024-06-21 Thread via GitHub
oxsean commented on issue #13962: URL: https://github.com/apache/dubbo/issues/13962#issuecomment-2177332977 ```groovy def "override mapping test"() { given: def request = new TestRequest(path: path) expect: runner.run(request,

Re: [PR] Bump io.micrometer:micrometer-bom from 1.13.0 to 1.13.1 [dubbo]

2024-06-21 Thread via GitHub
AlbumenJ merged PR #14331: URL: https://github.com/apache/dubbo/pull/14331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] upgrade opentelemetry and zipkin-reporter version [dubbo]

2024-06-21 Thread via GitHub
AlbumenJ merged PR #14338: URL: https://github.com/apache/dubbo/pull/14338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Feature][3.3] Triple rest path match support case insensitive [dubbo]

2024-06-21 Thread via GitHub
oxsean closed issue #13967: [Feature][3.3] Triple rest path match support case insensitive URL: https://github.com/apache/dubbo/issues/13967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [Feature][3.3] Triple rest useTrailingSlashMatch useSuffixPatternMatch support [dubbo]

2024-06-21 Thread via GitHub
oxsean closed issue #14036: [Feature][3.3] Triple rest useTrailingSlashMatch useSuffixPatternMatch support URL: https://github.com/apache/dubbo/issues/14036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Rest Refine [dubbo]

2024-06-21 Thread via GitHub
oxsean commented on PR #14334: URL: https://github.com/apache/dubbo/pull/14334#issuecomment-2177321071 #14036 #13967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] build(deps): bump ws from 8.16.0 to 8.17.1 in /ui-vue3 [dubbo-kubernetes]

2024-06-21 Thread via GitHub
dependabot[bot] opened a new pull request, #302: URL: https://github.com/apache/dubbo-kubernetes/pull/302 Bumps [ws](https://github.com/websockets/ws) from 8.16.0 to 8.17.1. Release notes Sourced from https://github.com/websockets/ws/releases;>ws's releases. 8.17.1 Bug