Re: [I] [Bug] 如果注册中心的用户密码包含'#'字符,会导致dubbo 的URLStrParser解析出错 [dubbo]

2024-06-23 Thread via GitHub
wcy666103 commented on issue #14361: URL: https://github.com/apache/dubbo/issues/14361#issuecomment-2185729879 So you need to avoid using this special character -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[I] [Bug] 如果注册中心的用户密码包含'#'字符,会导致dubbo 的URLStrParser解析出错 [dubbo]

2024-06-23 Thread via GitHub
linsida1 opened a new issue, #14361: URL: https://github.com/apache/dubbo/issues/14361 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=i

Re: [PR] fixed pojoutils string class issue [dubbo]

2024-06-23 Thread via GitHub
sonarcloud[bot] commented on PR #14102: URL: https://github.com/apache/dubbo/pull/14102#issuecomment-2185653100 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Fix the issue of errors when running out of HTTP2 stream IDs [dubbo]

2024-06-23 Thread via GitHub
sonarcloud[bot] commented on PR #14209: URL: https://github.com/apache/dubbo/pull/14209#issuecomment-2185637455 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [I] Docs: improvement of the `dubboctl` quick start guide [dubbo-kubernetes]

2024-06-23 Thread via GitHub
yin1999 commented on issue #291: URL: https://github.com/apache/dubbo-kubernetes/issues/291#issuecomment-2185604441 cross ref: #306, which introduced support for installing dubbo-admin as a k8s service -- This is an automated message from the Apache Git Service. To respond to the message

Re: [I] io.grpc.StatusRuntimeException: DEADLINE_EXCEEDED: deadline exceeded after 0.981473792s. [buffered_nanos=71961167, remote_addr=localhost/127.0.0.1:50051] [dubbo]

2024-06-23 Thread via GitHub
sunheyi6 commented on issue #12414: URL: https://github.com/apache/dubbo/issues/12414#issuecomment-2185523988 @chaoyoung VoiceChat class does not exist ![image](https://github.com/apache/dubbo/assets/50973219/ae1eee0d-c65b-4c75-bf13-2383e3db04a7) -- This is an automated message fro

[I] [Bug] Unit Test On windows-latest (JDK: 8) action failed [dubbo]

2024-06-23 Thread via GitHub
sunheyi6 opened a new issue, #14360: URL: https://github.com/apache/dubbo/issues/14360 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=i

Re: [PR] feat(dubboctl): add dubbo-cp k8s service support [dubbo-kubernetes]

2024-06-23 Thread via GitHub
chickenlj merged PR #306: URL: https://github.com/apache/dubbo-kubernetes/pull/306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] [Bug] Is there any graceful way to prevent running out of http2 stream id in Dubbo3.x [dubbo]

2024-06-23 Thread via GitHub
icodening commented on issue #14098: URL: https://github.com/apache/dubbo/issues/14098#issuecomment-2185470138 > > @PaulTan94 @oxsean @icodening @AlbumenJ I have an idea to handle GoAway gracefully, but need a testcase to cover. It's difficult to reproduce the scenario. Can you help? >

Re: [PR] Fix metrics unable to retrieve lazy inited executor status [dubbo]

2024-06-23 Thread via GitHub
AlbumenJ merged PR #14348: URL: https://github.com/apache/dubbo/pull/14348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dub

Re: [PR] test: add yaml loadAs test [dubbo]

2024-06-23 Thread via GitHub
yuluo-yx commented on code in PR #14080: URL: https://github.com/apache/dubbo/pull/14080#discussion_r1650090585 ## dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/yaml/YamlCodeCTest.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] New metadata service [dubbo]

2024-06-23 Thread via GitHub
sonarcloud[bot] commented on PR #14210: URL: https://github.com/apache/dubbo/pull/14210#issuecomment-2184991700 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Fix metrics unable to retrieve lazy inited executor status [dubbo]

2024-06-23 Thread via GitHub
codecov-commenter commented on PR #14348: URL: https://github.com/apache/dubbo/pull/14348#issuecomment-2184979158 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/14348?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fix metrics unable to retrieve lazy inited executor status [dubbo]

2024-06-23 Thread via GitHub
sonarcloud[bot] commented on PR #14348: URL: https://github.com/apache/dubbo/pull/14348#issuecomment-2184978403 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] New metadata service [dubbo]

2024-06-23 Thread via GitHub
namele commented on code in PR #14210: URL: https://github.com/apache/dubbo/pull/14210#discussion_r1650069182 ## dubbo-metadata/dubbo-metadata-api/src/main/proto/metadata_service_v2.proto: ## @@ -0,0 +1,30 @@ +syntax = "proto3"; Review Comment: OK. License are ad

Re: [PR] Fix metrics unable to retrieve lazy inited executor status [dubbo]

2024-06-23 Thread via GitHub
sonarcloud[bot] commented on PR #14348: URL: https://github.com/apache/dubbo/pull/14348#issuecomment-2184973260 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] New metadata service [dubbo]

2024-06-23 Thread via GitHub
AlbumenJ commented on code in PR #14210: URL: https://github.com/apache/dubbo/pull/14210#discussion_r1650060772 ## dubbo-metadata/dubbo-metadata-api/src/main/proto/metadata_service_v2.proto: ## @@ -0,0 +1,30 @@ +syntax = "proto3"; Review Comment: License header is required

Re: [PR] Fix metrics unable to retrieve lazy inited executor status [dubbo]

2024-06-23 Thread via GitHub
AlbumenJ commented on PR #14348: URL: https://github.com/apache/dubbo/pull/14348#issuecomment-2184964011 @CrazyHZM PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] feat(dubboctl): add dubbo-cp k8s service support [dubbo-kubernetes]

2024-06-23 Thread via GitHub
mfordjody commented on code in PR #306: URL: https://github.com/apache/dubbo-kubernetes/pull/306#discussion_r1650053527 ## deploy/charts/admin/values.yaml: ## @@ -41,7 +52,7 @@ image: # Source of the container image. registry: docker.io/apache/dubbo-admin # Version tag

Re: [PR] support "dubbo-samples-native-image" builds and launches with jar or native-image [dubbo-samples]

2024-06-23 Thread via GitHub
FoghostCn commented on PR #1158: URL: https://github.com/apache/dubbo-samples/pull/1158#issuecomment-2184949962 maybe you can make it work in native image scenario by add a `native-case-configuration.yml` -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] feat(dubboctl): add dubbo-cp k8s service support [dubbo-kubernetes]

2024-06-23 Thread via GitHub
yin1999 commented on code in PR #306: URL: https://github.com/apache/dubbo-kubernetes/pull/306#discussion_r1650035705 ## deploy/charts/admin/values.yaml: ## @@ -41,7 +52,7 @@ image: # Source of the container image. registry: docker.io/apache/dubbo-admin # Version tag of

Re: [PR] feat(dubboctl): add dubbo-cp k8s service support [dubbo-kubernetes]

2024-06-23 Thread via GitHub
mfordjody commented on code in PR #306: URL: https://github.com/apache/dubbo-kubernetes/pull/306#discussion_r1650027835 ## deploy/charts/admin/values.yaml: ## @@ -41,7 +52,7 @@ image: # Source of the container image. registry: docker.io/apache/dubbo-admin # Version tag

Re: [PR] feat(dubboctl): add dubbo-cp k8s service support [dubbo-kubernetes]

2024-06-23 Thread via GitHub
mfordjody commented on code in PR #306: URL: https://github.com/apache/dubbo-kubernetes/pull/306#discussion_r1650027053 ## deploy/charts/admin/Chart.yaml: ## Review Comment: Alright, let's do it your way for now. I'll make changes later :) -- This is an automated messag