[GitHub] [dubbo] CrazyHZM commented on pull request #11021: Added support for Micrometer Observation API

2023-01-18 Thread GitBox
CrazyHZM commented on PR #11021: URL: https://github.com/apache/dubbo/pull/11021#issuecomment-1386979430 > So should I update the PR with your suggestions or I shouldn't touch it at all and just do a review? It would of course be best if the issue could be fixed on this PR in time.

[GitHub] [dubbo] CrazyHZM commented on pull request #11021: Added support for Micrometer Observation API

2023-01-18 Thread GitBox
CrazyHZM commented on PR #11021: URL: https://github.com/apache/dubbo/pull/11021#issuecomment-1386753347 @marcingrzejszczak Hello, we are actively promoting Dubbo's observability capabilities, including tracing. We have also reviewed the PR and found that there is no problem with the

[GitHub] [dubbo] CrazyHZM commented on pull request #11021: Added support for Micrometer Observation API

2023-01-16 Thread GitBox
CrazyHZM commented on PR #11021: URL: https://github.com/apache/dubbo/pull/11021#issuecomment-1384781003 ping @marcingrzejszczak Pleas check and process the above review content. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [dubbo] CrazyHZM commented on pull request #11021: Added support for Micrometer Observation API

2022-12-04 Thread GitBox
CrazyHZM commented on PR #11021: URL: https://github.com/apache/dubbo/pull/11021#issuecomment-1336702221 Thanks to @marcingrzejszczak for this contribution, because the content of this PR will directly provide users with the Micrometer Observation function, we need to discuss whether it