[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.

2018-05-30 Thread GitBox
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393389089 @normanmaurer @justinmclean I have already add Netty header in files which I modified. And fix License file. The specific cont

[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.

2018-05-30 Thread GitBox
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393380659 ``` org.apache.rat apache-rat-plugin ${apache-rat-plugin.version} verify.r

[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.

2018-05-30 Thread GitBox
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393376164 Ok, I will fix it as soon as possible. thx This is an automated m

[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.

2018-05-30 Thread GitBox
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393169145 > In that case I would expect the original header to stay. See [1] It means the header of InternalThreadLocal which is in this

[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.

2018-05-30 Thread GitBox
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393161411 @normanmaurer @justinmclean https://github.com/apache/incubator-dubbo/pull/1865 I have submit a pull request to fix this probl

[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.

2018-05-30 Thread GitBox
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393150210 Oh, I will add this to NOTICE which content is like : ``` This product contains a modified portion of 'Apache Commons Lang

[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.

2018-05-30 Thread GitBox
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393148249 I have read this. And I will list sth which is not comply with Apache 2.0. If u agree, I will supplement this things as soon as

[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.

2018-05-30 Thread GitBox
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393135489 In the doc, I mentiond `This design is learning from {@see io.netty.util.concurrent.FastThreadLocal} which is in Netty.` What othe

[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.

2018-05-30 Thread GitBox
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393134212 @normanmaurer Oh, I mentioned this InternalThreadLocal isI inspired by FastThreadLocal in Netty in the doc. It means I refere

[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.

2018-05-14 Thread GitBox
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-388745592 @beiwei30 done. This is an automated message from the Apache Git Se