cnzakii closed pull request #1128: [Task] All samples unified switch to
annotation + yaml configuration …
URL: https://github.com/apache/dubbo-samples/pull/1128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
cnzakii commented on PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#issuecomment-2056598900
OK, I will close this "massive" pull request and submit new pull requests
module by module.
--
This is an automated message from the Apache Git Service.
To respond to the message,
chickenlj commented on PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#issuecomment-2056442526
Thanks @cnzakii , we really appreciate your contribution. I agree with
@CrazyHZM lease one module each time.
--
This is an automated message from the Apache Git Service.
To resp
CrazyHZM commented on code in PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1560697795
##
10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-filter-provider/src/main/resources/application.yml:
##
@@ -0,0 +1,31 @@
+# Licensed to the A
cnzakii commented on code in PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1556786592
##
10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-filter-provider/src/main/resources/application.yml:
##
@@ -0,0 +1,31 @@
+# Licensed to the Ap
cnzakii commented on code in PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1560690409
##
10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-filter-provider/src/main/resources/application.yml:
##
@@ -0,0 +1,31 @@
+# Licensed to the Ap
CrazyHZM commented on code in PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1560681265
##
10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-filter-provider/src/main/resources/application.yml:
##
@@ -0,0 +1,31 @@
+# Licensed to the A
cnzakii commented on PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#issuecomment-2044094126
> @cnzakii For new contributors to the community, we would prefer to see as
small a PR as possible for one or a few modules, as this is easier to review
and can be merge
cnzakii commented on code in PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1556822699
##
10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-protocol-consumer/src/main/resources/application.yml:
##
@@ -13,15 +13,17 @@
# See the Licen
cnzakii commented on code in PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1556822699
##
10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-protocol-consumer/src/main/resources/application.yml:
##
@@ -13,15 +13,17 @@
# See the Licen
cnzakii commented on code in PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1556788083
##
10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-protocol-consumer/src/main/resources/application.yml:
##
@@ -13,15 +13,17 @@
# See the Licen
cnzakii commented on code in PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1556788083
##
10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-protocol-consumer/src/main/resources/application.yml:
##
@@ -13,15 +13,17 @@
# See the Licen
cnzakii commented on code in PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1556788083
##
10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-protocol-consumer/src/main/resources/application.yml:
##
@@ -13,15 +13,17 @@
# See the Licen
cnzakii commented on code in PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1556786592
##
10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-filter-provider/src/main/resources/application.yml:
##
@@ -0,0 +1,31 @@
+# Licensed to the Ap
CrazyHZM commented on PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#issuecomment-2044049630
@cnzakii For new contributors to the community, we would prefer to see as
small a PR as possible for one or a few modules, as this is easier to review
and can be merged faster.
CrazyHZM commented on code in PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#discussion_r1556764092
##
10-task/dubbo-samples-extensibility/dubbo-samples-extensibility-protocol-consumer/src/main/resources/application.yml:
##
@@ -13,15 +13,17 @@
# See the Lice
cnzakii commented on PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#issuecomment-2042744745
@CrazyHZM
The reasons causing the CI checks to fail do not appear to be caused by this
PR:
1. The CI check for Dubbo 3.2 passed without issues.
2. The failures in `Dubbo 3.
CrazyHZM commented on PR #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128#issuecomment-2042561109
@cnzakii Please fix the ci.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
cnzakii opened a new pull request, #1128:
URL: https://github.com/apache/dubbo-samples/pull/1128
## What is the purpose of the change
[Task] All samples unified switch to annotation + yaml configuration
[#13860](https://github.com/apache/dubbo/issues/13860)
## Brief changelog
Co
19 matches
Mail list logo
