Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

AlbumenJ merged PR #13971: URL: https://github.com/apache/dubbo/pull/13971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2099702446 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2097378464 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2074000902 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2058390972 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

chickenlj commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2057088111 @finefuture thanks for the patience and contribution, we do appreciate it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2056758400 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

chickenlj commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2056445087 Sorry for the late response, I am working on this pull request now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2049073671 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2041460501 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

finefuture commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2041448817 @chickenlj Does DynamicConfiguration need to support multiple namespaces?  --

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

finefuture commented on code in PR #13971: URL: https://github.com/apache/dubbo/pull/13971#discussion_r1554846944 ## dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/report/support/AbstractMetadataReportFactory.java: ## @@ -89,6 +91,12 @@ public

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2041381822 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2041374207 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

finefuture commented on code in PR #13971: URL: https://github.com/apache/dubbo/pull/13971#discussion_r1554846944 ## dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/report/support/AbstractMetadataReportFactory.java: ## @@ -89,6 +91,12 @@ public

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

finefuture commented on code in PR #13971: URL: https://github.com/apache/dubbo/pull/13971#discussion_r1554846663 ## dubbo-common/src/main/java/org/apache/dubbo/config/RegistryConfig.java: ## @@ -220,12 +219,6 @@ public RegistryConfig(ApplicationModel applicationModel, String

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

chickenlj commented on code in PR #13971: URL: https://github.com/apache/dubbo/pull/13971#discussion_r1542428296 ## dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/report/support/AbstractMetadataReportFactory.java: ## @@ -89,6 +91,12 @@ public

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2033505083 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2031221667 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2026958232 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2026639962 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2025070577 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

finefuture commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2025014688 @chickenlj PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

finefuture commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2024754788 > I think it would be better to just change the way how `REGISTRY_CLUSTER_KEY` is generated. > > For now, `REGISTRY_CLUSTER_KEY` is the same as `id` (controlled by

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

chickenlj commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2024665793 I think it would be better to just change the way how `REGISTRY_CLUSTER_KEY` is generated. Before `REGISTRY_CLUSTER_KEY` is the same as `id`, but now we want it to include

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2020974137 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2011793259 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

codecov-commenter commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2011186665 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/13971?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2011183227 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]

finefuture opened a new pull request, #13971: URL: https://github.com/apache/dubbo/pull/13971 ## What is the purpose of the change Key missing namespace information: https://github.com/apache/dubbo/assets/18413695/fde4b37e-278c-458f-8dcf-d7bafe871575;> ## Brief changelog