AlbumenJ merged PR #14026:
URL: https://github.com/apache/dubbo/pull/14026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dub
sonarcloud[bot] commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2104809459
## [](https://sonarclo
walklown commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1596853404
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##
@@ -143,31 +149,52 @@ public void configServerProtocolHandle
oxsean commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1596841843
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##
@@ -143,31 +149,52 @@ public void configServerProtocolHandler(
oxsean commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1596840246
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##
@@ -143,31 +149,52 @@ public void configServerProtocolHandler(
oxsean commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1596838156
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##
@@ -184,4 +211,22 @@ protected void initChannel(Http2StreamCha
oxsean commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1596838156
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##
@@ -184,4 +211,22 @@ protected void initChannel(Http2StreamCha
walklown commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2102008683
The check item 'dubbo-samples-test-13787' failed because the tests attribute
in 'case-configuration.yml' was set incorrectly. I think it should be replaced
with
` tests:
sonarcloud[bot] commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2101894481
## [](https://sonarclo
walklown commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1594912777
##
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyPortUnificationServerHandler.java:
##
@@ -181,4 +153,48 @@ privat
walklown commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1594912777
##
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyPortUnificationServerHandler.java:
##
@@ -181,4 +153,48 @@ privat
AlbumenJ commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1594884669
##
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyPortUnificationServerHandler.java:
##
@@ -181,4 +153,48 @@ privat
sonarcloud[bot] commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2100973411
## [](https://sonarclo
walklown commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2100890254
> @walklown Sorry, I forgot commit the comments, please take a look.
Submitted, thanks for your guidance !
--
This is an automated message from the Apache Git Service.
To respond
walklown commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1594238993
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##
@@ -143,31 +149,54 @@ public void configServerProtocolHandle
walklown commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1594238993
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##
@@ -143,31 +149,54 @@ public void configServerProtocolHandle
walklown commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1594236514
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##
@@ -143,31 +149,54 @@ public void configServerProtocolHandle
walklown commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1594223745
##
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyPortUnificationServerHandler.java:
##
@@ -181,4 +153,48 @@ privat
oxsean commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1583229862
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##
@@ -143,31 +149,54 @@ public void configServerProtocolHandler(
oxsean commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2100811720
@walklown Sorry, I forgot commit the comments, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
walklown commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2085123076
@AlbumenJ The problem has been solved, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
walklown commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2085120737
> LGTM, but have you tested no impact to dubbo protocol? And It would be
good to place your test as a unit test in the Dubbo project, or you could put
it in the integration tests as well
oxsean commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2082989318
LGTM, but have you tested no impact to dubbo protocol?
And It would be good to place your test as a unit test in the Dubbo project,
or you could put it in the integration tests as well:
sonarcloud[bot] commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2078594018
## [](https://sonarclo
walklown commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2078563393
> I think so, but we need to confirm whether adding ALPN support cause a
regression in protocols other than Triple, such as the Dubbo protocol.
Submitted a commit. Please take a lo
sonarcloud[bot] commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076968043
## [](https://sonarclo
walklown commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076895079
> > > Please look into whether Application-Layer Protocol Negotiation is
supported in addition to h2c:
https://matthewparrilla.com/post/negotiation-http2-alpn-tls-handshake/
https://imq
walklown commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1579263649
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##
@@ -143,13 +148,63 @@ public void configServerProtocolHandle
walklown commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076889743
> > > Test `org.apache.dubbo.demo.provider.ApiProvider` with curl:
> > > ```
> > > curl.exe -v --http2 -k -H "Content-Type: application/json" -d '"asd"'
http://127.0.0.1:50051/org.a
oxsean commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076845063
> > Please look into whether Application-Layer Protocol Negotiation is
supported in addition to h2c:
https://matthewparrilla.com/post/negotiation-http2-alpn-tls-handshake/
https://imququ.
walklown commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076766699
> Please look into whether Application-Layer Protocol Negotiation is
supported in addition to h2c:
https://matthewparrilla.com/post/negotiation-http2-alpn-tls-handshake/
https://imququ.
oxsean commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076522474
> > Test `org.apache.dubbo.demo.provider.ApiProvider` with curl:
> > ```
> > curl.exe -v --http2 -k -H "Content-Type: application/json" -d '"asd"'
http://127.0.0.1:50051/org.apache.du
walklown commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076455166
> Test `org.apache.dubbo.demo.provider.ApiProvider` with curl:
>
> ```
> curl.exe -v --http2 -k -H "Content-Type: application/json" -d '"asd"'
http://127.0.0.1:50051/org.apache.
oxsean commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1578163707
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##
@@ -143,13 +148,63 @@ public void configServerProtocolHandler(
oxsean commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2075349461
Please look into whether Application-Layer Protocol Negotiation is supported
in addition to h2c:
https://matthewparrilla.com/post/negotiation-http2-alpn-tls-handshake/
https://imququ.
oxsean commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2075309346
Test `org.apache.dubbo.demo.provider.ApiProvider` with curl:
```
curl.exe -v --http2 -k -H "Content-Type: application/json" -d '"asd"'
http://127.0.0.1:50051/org.apache.dubbo.demo.Gre
sonarcloud[bot] commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2042101871
## [](https://sonarclo
walklown commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1555327965
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/HttpServerAfterUpgradeHandler.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apach
AlbumenJ commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1554821301
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/HttpServerAfterUpgradeHandler.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apach
AlbumenJ commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2041324640
@oxsean PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
sonarcloud[bot] commented on PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2032608711
## [](https://sonarclo
41 matches
Mail list logo
