yang20150702 merged PR #166:
URL: https://github.com/apache/dubbo-rust/pull/166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
yang20150702 commented on PR #166:
URL: https://github.com/apache/dubbo-rust/pull/166#issuecomment-1823759965
LGTM! Good work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
yang20150702 commented on code in PR #166:
URL: https://github.com/apache/dubbo-rust/pull/166#discussion_r1401439896
##
dubbo/src/directory/mod.rs:
##
@@ -164,26 +160,27 @@ where
let registry = self.inner.clone();
-let (tx, rx) = channel(1024);
+let
yang20150702 commented on code in PR #166:
URL: https://github.com/apache/dubbo-rust/pull/166#discussion_r1400762072
##
dubbo/src/loadbalancer/mod.rs:
##
@@ -40,59 +44,50 @@ where
let svc = self.inner.new_service(target);
LoadBalancer {
-inner: sv
onewe opened a new pull request, #166:
URL: https://github.com/apache/dubbo-rust/pull/166
- refactor some logic for directory component
- BufferedBody use CloneBody instead of generics
- add CloneInvoker component and remove request param generics
- add map_request method in the Tri
