Re: [PR] feat: support prometheus new client of micrometer 1.13.0 version [dubbo]

2024-06-24 Thread via GitHub
qyi71 commented on PR #14345: URL: https://github.com/apache/dubbo/pull/14345#issuecomment-2186550639 > You can get the case in https://github.com/apache/dubbo-integration-cases/tree/main/99-integration/dubbo-samples-test-13580. Update the dubbo version in pom, and test it. Thanks

Re: [PR] feat: support prometheus new client of micrometer 1.13.0 version [dubbo]

2024-06-24 Thread via GitHub
qyi71 commented on PR #14345: URL: https://github.com/apache/dubbo/pull/14345#issuecomment-2186550165 > You can get the case in https://github.com/apache/dubbo-integration-cases/tree/main/99-integration/dubbo-samples-test-13580. Update the dubbo version in pom, and test it.您可以在 https://git

Re: [PR] feat: support prometheus new client of micrometer 1.13.0 version [dubbo]

2024-06-24 Thread via GitHub
AlbumenJ commented on PR #14345: URL: https://github.com/apache/dubbo/pull/14345#issuecomment-2186046501 You can get the case in https://github.com/apache/dubbo-integration-cases/tree/main/99-integration/dubbo-samples-test-13580. Update the dubbo version in pom, and test it. -- This is a

Re: [PR] feat: support prometheus new client of micrometer 1.13.0 version [dubbo]

2024-06-21 Thread via GitHub
AlbumenJ commented on PR #14269: URL: https://github.com/apache/dubbo/pull/14269#issuecomment-2177366784 ![image](https://github.com/apache/dubbo/assets/9292748/34f20462-d055-472e-ba4e-814359ca4fde) -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] feat: support prometheus new client of micrometer 1.13.0 version [dubbo]

2024-06-18 Thread via GitHub
qyi71 commented on PR #14269: URL: https://github.com/apache/dubbo/pull/14269#issuecomment-2175336181 @AlbumenJ PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] feat: support prometheus new client of micrometer 1.13.0 version [dubbo]

2024-06-05 Thread via GitHub
AlbumenJ commented on code in PR #14269: URL: https://github.com/apache/dubbo/pull/14269#discussion_r1628730486 ## dubbo-dependencies-bom/pom.xml: ## @@ -717,15 +717,14 @@ io.prometheus -simpleclient +prometheus-metrics-core ${pr

Re: [PR] feat: support prometheus new client of micrometer 1.13.0 version [dubbo]

2024-06-05 Thread via GitHub
qyi71 commented on PR #14269: URL: https://github.com/apache/dubbo/pull/14269#issuecomment-2149322913 @songxiaosheng please help look this , maybe is not my fault -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] feat: support prometheus new client of micrometer 1.13.0 version [dubbo]

2024-06-04 Thread via GitHub
sonarcloud[bot] commented on PR #14269: URL: https://github.com/apache/dubbo/pull/14269#issuecomment-2147277184 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] feat: support prometheus new client of micrometer 1.13.0 version [dubbo]

2024-06-04 Thread via GitHub
songxiaosheng commented on code in PR #14269: URL: https://github.com/apache/dubbo/pull/14269#discussion_r1625763032 ## dubbo-metrics/dubbo-metrics-prometheus/src/main/java/org/apache/dubbo/metrics/prometheus/PrometheusMetricsReporter.java: ## @@ -93,7 +96,7 @@ private void sche

Re: [PR] feat: support prometheus new client of micrometer 1.13.0 version [dubbo]

2024-06-01 Thread via GitHub
songxiaosheng commented on PR #14269: URL: https://github.com/apache/dubbo/pull/14269#issuecomment-2143415787 @AlbumenJ help check sample ci,thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] feat: support prometheus new client of micrometer 1.13.0 version [dubbo]

2024-06-01 Thread via GitHub
sonarcloud[bot] commented on PR #14269: URL: https://github.com/apache/dubbo/pull/14269#issuecomment-2143354927 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

[PR] feat: support prometheus new client of micrometer 1.13.0 version [dubbo]

2024-06-01 Thread via GitHub
qyi71 opened a new pull request, #14269: URL: https://github.com/apache/dubbo/pull/14269 ## What is the purpose of the change support prometheus new client of micrometer 1.13.0 version ref: #14228 @AlbumenJ @songxiaosheng ## Brief changelog ## Verifying this