[GitHub] [fluo-uno] ctubbsii commented on pull request #254: Do more with ShellCheck

2020-08-20 Thread GitBox
ctubbsii commented on pull request #254: URL: https://github.com/apache/fluo-uno/pull/254#issuecomment-677859599 This isn't quite ready for merging. I saw a bug where this didn't properly trigger the install of ZooKeeper after installing Hadoop, when doing `uno setup accumulo` *without* do

[GitHub] [fluo-uno] ctubbsii commented on a change in pull request #254: Do more with ShellCheck

2020-08-20 Thread GitBox
ctubbsii commented on a change in pull request #254: URL: https://github.com/apache/fluo-uno/pull/254#discussion_r474222177 ## File path: bin/impl/install.sh ## @@ -15,6 +15,7 @@ # See the License for the specific language governing permissions and # limitations under the Lic

[GitHub] [fluo-uno] ctubbsii commented on a change in pull request #254: Do more with ShellCheck

2020-08-20 Thread GitBox
ctubbsii commented on a change in pull request #254: URL: https://github.com/apache/fluo-uno/pull/254#discussion_r474222177 ## File path: bin/impl/install.sh ## @@ -15,6 +15,7 @@ # See the License for the specific language governing permissions and # limitations under the Lic

[GitHub] [fluo-uno] ctubbsii commented on a change in pull request #254: Do more with ShellCheck

2020-08-20 Thread GitBox
ctubbsii commented on a change in pull request #254: URL: https://github.com/apache/fluo-uno/pull/254#discussion_r474221878 ## File path: README.md ## @@ -188,17 +188,19 @@ applications or follow the instructions starting at the [Configure a Fluo applic section of the Fluo in

[GitHub] [fluo-uno] keith-turner commented on a change in pull request #254: Do more with ShellCheck

2020-08-20 Thread GitBox
keith-turner commented on a change in pull request #254: URL: https://github.com/apache/fluo-uno/pull/254#discussion_r474199567 ## File path: bin/impl/install.sh ## @@ -15,6 +15,7 @@ # See the License for the specific language governing permissions and # limitations under the

[GitHub] [fluo-uno] ctubbsii opened a new pull request #254: Do more with ShellCheck

2020-08-20 Thread GitBox
ctubbsii opened a new pull request #254: URL: https://github.com/apache/fluo-uno/pull/254 * Fix numerous issues to make ShellCheck pass across `bin/*` and `conf/uno.conf` * Add GitHub Actions and CI script for automated ShellCheck testing * Add missing checksum for latest Hadoop 3