ctubbsii commented on pull request #254: URL: https://github.com/apache/fluo-uno/pull/254#issuecomment-679311347
@keith-turner I fixed the previous error, if you want to take another pass at a review. Some of the conditional statements in bash at the end of some scripts were returning `false`, which resulted in the return code for the entire script being false, and causing some of the steps to not execute. I fixed this by adding a 'true' statement at the end of called scripts, so that they don't return false, if they aren't supposed to. In order to track this down, I ended up consolidating a few smaller scripts into a single script with multiple functions. This refactor helped me track down the bug fix the problem. I'm leaving it included in this PR, because I think it's better this way, and using functions instead of scripts helps with understanding return codes. I think there's more opportunities to clean up additional things in these scripts, but this PR is already too big, so I'll defer to another time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
