[GitHub] [fluo] keith-turner commented on a diff in pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-12-29 Thread GitBox
keith-turner commented on code in PR #1120: URL: https://github.com/apache/fluo/pull/1120#discussion_r1059231874 ## modules/core/src/main/java/org/apache/fluo/core/impl/TransactionImpl.java: ## @@ -1571,6 +1579,20 @@ private void beginCommitAsyncTest(CommitData cd) { } p

[GitHub] [fluo] keith-turner commented on a diff in pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-12-29 Thread GitBox
keith-turner commented on code in PR #1120: URL: https://github.com/apache/fluo/pull/1120#discussion_r1059230134 ## modules/api/src/main/java/org/apache/fluo/api/config/SimpleConfiguration.java: ## @@ -242,6 +243,27 @@ public void setProperty(String key, String value) { int

[GitHub] [fluo] keith-turner commented on a diff in pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-12-29 Thread GitBox
keith-turner commented on code in PR #1120: URL: https://github.com/apache/fluo/pull/1120#discussion_r1059229937 ## modules/api/src/main/java/org/apache/fluo/api/config/FluoConfiguration.java: ## @@ -510,6 +514,19 @@ public String getAccumuloPassword() { throw new NoSuchEle

[GitHub] [fluo] keith-turner commented on a diff in pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-12-29 Thread GitBox
keith-turner commented on code in PR #1120: URL: https://github.com/apache/fluo/pull/1120#discussion_r1059229771 ## modules/api/src/main/java/org/apache/fluo/api/client/FluoClient.java: ## @@ -15,6 +15,8 @@ package org.apache.fluo.api.client; +import java.util.Collection; +

[GitHub] [fluo] keith-turner commented on pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-12-29 Thread GitBox
keith-turner commented on PR #1120: URL: https://github.com/apache/fluo/pull/1120#issuecomment-1367705887 @wjsl I was looking at this. The API returned a Snapshot which gave me the feel that maybe it would not change the current snapshot object, but would create a new one with the auths se