[GitHub] incubator-fluo-website issue #17: Update downloads to refer to fluo-parent a...

2016-08-11 Thread ctubbsii
GitHub user ctubbsii opened an issue: https://github.com/apache/incubator-fluo-website/issues/17 Update downloads to refer to fluo-parent and build-resources I don't think these deserve a prominent display on the downloads page, because they're primarily used via Maven, b

[GitHub] incubator-fluo issue #761: Found and fixed two bugs while working on the Flu...

2016-08-30 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/incubator-fluo/pull/761 If you mean Jenkins, it's been having a lot of problems lately, like not being able to resolve dependencies, etc. --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-fluo-recipes issue #99: Made thrift version configurable.

2016-09-02 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/incubator-fluo-recipes/pull/99 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-fluo issue #762: CollisionIT failed

2016-09-13 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/incubator-fluo/issues/762 I saw: ``` Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 17.547 sec <<< FAILURE! - in org.apache.fluo.integration.impl.CollisionIT testLotsOfC

[GitHub] incubator-fluo pull request #766: Avoid use of auxiliary class, and other wa...

2016-09-13 Thread ctubbsii
GitHub user ctubbsii opened a pull request: https://github.com/apache/incubator-fluo/pull/766 Avoid use of auxiliary class, and other warnings * Move auxiliary AsciiSequence class to own file * Remove redundant type args (use diamond) * Suppress warnings in thrift classes

[GitHub] incubator-fluo pull request #766: Avoid use of auxiliary class, and other wa...

2016-09-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/766#discussion_r78795784 --- Diff: modules/api/src/test/java/org/apache/fluo/api/data/AsciiSequence.java --- @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-fluo pull request #766: Avoid use of auxiliary class, and other wa...

2016-09-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/766#discussion_r78797796 --- Diff: modules/core/src/main/java/org/apache/fluo/core/thrift/OracleService.java --- @@ -26,6 +26,7 @@ import org.slf4j.Logger; import

[GitHub] incubator-fluo pull request #769: Add helper script for building release can...

2016-09-14 Thread ctubbsii
GitHub user ctubbsii opened a pull request: https://github.com/apache/incubator-fluo/pull/769 Add helper script for building release candidates * Adds helper script to contrib/ * Fix tagNameFormat for release tag names You can merge this pull request into a Git repository by

[GitHub] incubator-fluo pull request #778: Fixes #777 - Set Fluo version in fluo.prop...

2016-09-22 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/778#discussion_r80134295 --- Diff: modules/distribution/src/main/config/fluo.properties --- @@ -56,7 +56,7 @@ fluo.admin.hdfs.root=hdfs://localhost:1 # every tablet

[GitHub] incubator-fluo pull request #778: Fixes #777 - Set Fluo version in fluo.prop...

2016-09-22 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/778#discussion_r80132128 --- Diff: modules/distribution/src/main/assembly/bin.xml --- @@ -94,4 +94,11 @@ + + + src/main

[GitHub] incubator-fluo pull request #778: Fixes #777 - Set Fluo version in fluo.prop...

2016-09-22 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/778#discussion_r80139615 --- Diff: modules/distribution/pom.xml --- @@ -63,6 +63,9 @@ maven-assembly-plugin

[GitHub] incubator-fluo issue #781: Added license header to docs

2016-09-23 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/incubator-fluo/pull/781 :+1: (interesting note about new GitHub review stuffs can't :+1: a previous approval, and can't add an approval to an already merged PR). --- If your project is set up for i

[GitHub] incubator-fluo pull request #783: Add incubating parenthetical to NOTICE

2016-09-27 Thread ctubbsii
GitHub user ctubbsii opened a pull request: https://github.com/apache/incubator-fluo/pull/783 Add incubating parenthetical to NOTICE You can merge this pull request into a Git repository by running: $ git pull https://github.com/ctubbsii/fluo updates-from-rc1 Alternatively

[GitHub] incubator-fluo-website issue #23: Fluo 1.0.0

2016-10-12 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/incubator-fluo-website/pull/23 Diff is far too big to preview/review in GitHub. Can you strip out the commit which adds the javadocs, and just put in a placeholder to be fixed before merging? Also, this

[GitHub] incubator-fluo-website pull request #23: Fluo 1.0.0

2016-10-13 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/23#discussion_r83275841 --- Diff: _layouts/default.html --- @@ -31,8 +31,10 @@ -Documentation

[GitHub] incubator-fluo-website pull request #27: Major refactoring of release posts

2016-10-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/27#discussion_r83468525 --- Diff: _posts/blog/2016-01-11-webindex-long-run.md --- @@ -1,6 +1,6 @@ --- title: "Running Webindex for 3 days o

[GitHub] incubator-fluo-website pull request #27: Major refactoring of release posts

2016-10-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/27#discussion_r83468865 --- Diff: _posts/blog/2016-01-11-webindex-long-run.md --- @@ -1,6 +1,6 @@ --- title: "Running Webindex for 3 days o

[GitHub] incubator-fluo-website issue #8: Clearly document non-Apache releases as suc...

2016-10-19 Thread ctubbsii
Github user ctubbsii closed the issue at: https://github.com/apache/incubator-fluo-website/issues/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-fluo-recipes pull request #117: Fix small compiler warning in IT

2016-10-20 Thread ctubbsii
GitHub user ctubbsii opened a pull request: https://github.com/apache/incubator-fluo-recipes/pull/117 Fix small compiler warning in IT Make use of resource inside of try-with-resources block by ensuring it's not null. You can merge this pull request into a Git reposito

[GitHub] incubator-fluo issue #790: Add verification code to RC email

2016-10-21 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/incubator-fluo/issues/790 ```bash function checkFile { local file; file=$1 echo '=' echo "$file" gpg2 --verify "${file}".asc "$file" for ha

[GitHub] incubator-fluo issue #790: Add verification code to RC email

2016-10-21 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/incubator-fluo/issues/790 Maybe simpler, and leaves some MD5SUM, SHA1SUM files around to manually check later: ```bash function checkFile { local file; file=$1 echo '=' e

[GitHub] incubator-fluo pull request #792: #791 give Oracle more time to stop in IT

2016-10-24 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/792#discussion_r84791922 --- Diff: modules/integration/src/test/java/org/apache/fluo/integration/impl/OracleIT.java --- @@ -226,7 +226,7 @@ public void

[GitHub] incubator-fluo issue #716: Release fluo-parent-1-incubating (parent POM)

2016-10-25 Thread ctubbsii
Github user ctubbsii closed the issue at: https://github.com/apache/incubator-fluo/issues/716 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-fluo issue #716: Release fluo-parent-1-incubating (parent POM)

2016-10-25 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/incubator-fluo/issues/716 Yes. Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-fluo issue #762: CollisionIT failed

2016-10-25 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/incubator-fluo/issues/762 So, this was just a test bug, not a problem with collisions? That's a relief. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] incubator-fluo-website issue #31: Add twitter link

2016-10-25 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/incubator-fluo-website/issues/31 If you want, you can share access to other PMC members with https://tweetdeck.twitter.com --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-fluo-website pull request #32: Mention that tx are cross node on f...

2016-10-25 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/32#discussion_r85042450 --- Diff: index.html --- @@ -56,7 +56,7 @@ Major Features Core API - The core Fluo API supports

[GitHub] incubator-fluo-website issue #33: Integrate Google+ comments onto blog posts

2016-10-27 Thread ctubbsii
GitHub user ctubbsii opened an issue: https://github.com/apache/incubator-fluo-website/issues/33 Integrate Google+ comments onto blog posts Found a tutorial online that said to just add the following (have not tested): ``` https://apis.google.com/js/plusone.js&quo

[GitHub] incubator-fluo-website issue #34: Add twitter and facebook sharing to each b...

2016-10-27 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/incubator-fluo-website/issues/34 If we add it to the overall page template, it would make it easier to share all pages, blog posts or otherwise. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-fluo-website pull request #41: Blog post about immutable bytes

2016-11-09 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/41#discussion_r87272869 --- Diff: _posts/blog/2016-11-09-immutable-bytes.md --- @@ -0,0 +1,180 @@ +--- +title: "Java needs an immutable byte s

[GitHub] incubator-fluo-website pull request #41: Blog post about immutable bytes

2016-11-09 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/41#discussion_r87280245 --- Diff: _posts/blog/2016-11-09-immutable-bytes.md --- @@ -0,0 +1,180 @@ +--- +title: "Java needs an immutable byte s

[GitHub] incubator-fluo-website pull request #41: Blog post about immutable bytes

2016-11-09 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/41#discussion_r87273763 --- Diff: _posts/blog/2016-11-09-immutable-bytes.md --- @@ -0,0 +1,180 @@ +--- +title: "Java needs an immutable byte s

[GitHub] incubator-fluo-website pull request #41: Blog post about immutable bytes

2016-11-09 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/41#discussion_r87273093 --- Diff: _posts/blog/2016-11-09-immutable-bytes.md --- @@ -0,0 +1,180 @@ +--- +title: "Java needs an immutable byte s

[GitHub] incubator-fluo-website pull request #41: Blog post about immutable bytes

2016-11-09 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/41#discussion_r87280336 --- Diff: _posts/blog/2016-11-09-immutable-bytes.md --- @@ -0,0 +1,180 @@ +--- +title: "Java needs an immutable byte s

[GitHub] incubator-fluo-website pull request #41: Blog post about immutable bytes

2016-11-09 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/41#discussion_r87272823 --- Diff: _posts/blog/2016-11-09-immutable-bytes.md --- @@ -0,0 +1,180 @@ +--- +title: "Java needs an immutable byte s

[GitHub] incubator-fluo-website pull request #41: Blog post about immutable bytes

2016-11-09 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/41#discussion_r87273916 --- Diff: _posts/blog/2016-11-09-immutable-bytes.md --- @@ -0,0 +1,180 @@ +--- +title: "Java needs an immutable byte s

[GitHub] incubator-fluo-website pull request #42: Update to Jekyll 3.3.0

2016-11-10 Thread ctubbsii
GitHub user ctubbsii opened a pull request: https://github.com/apache/incubator-fluo-website/pull/42 Update to Jekyll 3.3.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ctubbsii/incubator-fluo-website gh-pages Alternatively

[GitHub] incubator-fluo issue #800: Investigate caching String to Bytes conversions a...

2016-11-15 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/incubator-fluo/issues/800 Accumulo's client code has suffered from excessive caching of objects globally/statically in the JVM, all outside the user's control. If a caching feature is introduced, the u

[GitHub] incubator-fluo-website pull request #44: Update excercise 1 to add CFM and i...

2016-11-29 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/44#discussion_r90113456 --- Diff: tour/exercise-1.md --- @@ -240,14 +237,15 @@ public class ContentObserver extends AbstractObserver { /** * Utility

[GitHub] incubator-fluo-website pull request #44: Update excercise 1 to add CFM and i...

2016-11-29 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/44#discussion_r90113671 --- Diff: tour/exercise-1.md --- @@ -297,113 +295,357 @@ observer as follows. After implementing the Observer, the output of the program

[GitHub] incubator-fluo-website pull request #45: Update (most) old fluo-io links

2016-11-29 Thread ctubbsii
GitHub user ctubbsii opened a pull request: https://github.com/apache/incubator-fluo-website/pull/45 Update (most) old fluo-io links You can merge this pull request into a Git repository by running: $ git pull https://github.com/ctubbsii/incubator-fluo-website gh-pages

[GitHub] incubator-fluo-website pull request #45: Update (most) old fluo-io links

2016-12-01 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/45#discussion_r90535851 --- Diff: _posts/blog/2014-12-30-stress-test-long-run.md --- @@ -22,19 +22,19 @@ everything finished, the test was a success. The number of

[GitHub] incubator-fluo pull request #817: fixes #816 introduced better way to setup ...

2017-03-20 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/817#discussion_r107008945 --- Diff: modules/api/src/main/java/org/apache/fluo/api/observer/ObserversFactory.java --- @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache

[GitHub] incubator-fluo pull request #817: fixes #816 introduced better way to setup ...

2017-03-20 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/817#discussion_r107010658 --- Diff: modules/api/src/main/java/org/apache/fluo/api/observer/ObserversFactory.java --- @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache

[GitHub] incubator-fluo pull request #817: fixes #816 introduced better way to setup ...

2017-03-20 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/817#discussion_r107011986 --- Diff: modules/api/src/main/java/org/apache/fluo/api/observer/StringObserver.java --- @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache

[GitHub] incubator-fluo pull request #817: fixes #816 introduced better way to setup ...

2017-03-20 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/817#discussion_r107029175 --- Diff: modules/api/src/main/java/org/apache/fluo/api/observer/StringObserver.java --- @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache

[GitHub] incubator-fluo pull request #817: fixes #816 introduced better way to setup ...

2017-03-20 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/817#discussion_r107032718 --- Diff: modules/api/src/main/java/org/apache/fluo/api/observer/ObserversFactory.java --- @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache

[GitHub] incubator-fluo pull request #817: fixes #816 introduced better way to setup ...

2017-03-20 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/817#discussion_r107034326 --- Diff: modules/api/src/main/java/org/apache/fluo/api/observer/ObserversFactory.java --- @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache

[GitHub] incubator-fluo issue #500: Reduce amount of scaning needed to find notificat...

2017-04-03 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/incubator-fluo/issues/500 How would tablets be assigned to groups? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-fluo pull request #825: fixes #823

2017-04-21 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/825#discussion_r112800248 --- Diff: modules/api/src/main/java/org/apache/fluo/api/data/Bytes.java --- @@ -355,6 +354,36 @@ public static final Bytes of(String s, Charset c

[GitHub] incubator-fluo pull request #825: fixes #823

2017-04-21 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/825#discussion_r112800262 --- Diff: modules/api/src/main/java/org/apache/fluo/api/data/Bytes.java --- @@ -355,6 +354,36 @@ public static final Bytes of(String s, Charset c

[GitHub] incubator-fluo pull request #825: fixes #823

2017-04-21 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/825#discussion_r112800377 --- Diff: modules/api/src/main/java/org/apache/fluo/api/data/Bytes.java --- @@ -355,6 +354,36 @@ public static final Bytes of(String s, Charset c

[GitHub] incubator-fluo pull request #825: fixes #823

2017-04-21 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/825#discussion_r112800313 --- Diff: modules/api/src/main/java/org/apache/fluo/api/data/Bytes.java --- @@ -355,6 +354,36 @@ public static final Bytes of(String s, Charset c

[GitHub] incubator-fluo pull request #825: fixes #823

2017-04-21 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/825#discussion_r112800518 --- Diff: modules/api/src/main/java/org/apache/fluo/api/data/Bytes.java --- @@ -355,6 +354,36 @@ public static final Bytes of(String s, Charset c

[GitHub] incubator-fluo pull request #825: fixes #823

2017-04-21 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/825#discussion_r112800350 --- Diff: modules/api/src/test/java/org/apache/fluo/api/data/BytesTest.java --- @@ -79,6 +79,19 @@ public void testHashSubsequence

[GitHub] incubator-fluo-recipes pull request #128: Updated ExportQ and CFM to use new...

2017-04-25 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo-recipes/pull/128#discussion_r113216479 --- Diff: docs/accumulo-export-queue.md --- @@ -19,8 +19,8 @@ limitations under the License. ## Background The [Export

[GitHub] incubator-fluo issue #827: Add copyTo() method to bytes

2017-04-26 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/incubator-fluo/issues/827 Looking at this example, I'm wondering if the javadoc for any such method should make it a point to remind the user that the offset and length correspond to the UTF-8 encoded byte

[GitHub] incubator-fluo pull request #837: fixes #835 escaped binary data in collisio...

2017-05-11 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/837#discussion_r116111357 --- Diff: modules/integration/src/test/java/org/apache/fluo/integration/TestUtil.java --- @@ -17,18 +17,26 @@ import

[GitHub] incubator-fluo pull request #837: fixes #835 escaped binary data in collisio...

2017-05-11 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/837#discussion_r116110058 --- Diff: modules/core/src/main/java/org/apache/fluo/core/log/TracingTransaction.java --- @@ -96,6 +96,11 @@ private String encC(Map ret