[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69114635 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -368,149 +367,152 @@ public String inspect() { * Also see containsWithinBounds. */

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69114896 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -357,160 +363,182 @@ public String toString() { return reverse ? "" + to + ".." + from :

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69115248 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -426,89 +419,52 @@ public void remove() { innerIterator.remove(); }

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69115463 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -357,160 +363,182 @@ public String toString() { return reverse ? "" + to + ".." + from : ""

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69115512 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -357,160 +363,182 @@ public String toString() { return reverse ? "" + to + ".." + from : ""

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69115682 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -357,160 +363,182 @@ public String toString() { return reverse ? "" + to + ".." + from :

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69116308 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -426,89 +419,52 @@ public void remove() { innerIterator.remove();

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69117171 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -408,107 +401,66 @@ public void step(int step, Closure closure) { */ @Override

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69117475 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -426,89 +419,52 @@ public void remove() { innerIterator.remove(); }

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69118086 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -426,89 +419,52 @@ public void remove() { innerIterator.remove();

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69118703 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -426,89 +419,52 @@ public void remove() { innerIterator.remove(); }

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69119539 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -426,89 +419,52 @@ public void remove() { innerIterator.remove();

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69123403 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -408,107 +401,86 @@ public void step(int step, Closure closure) { */ @Override

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69129094 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -357,160 +363,198 @@ public String toString() { return reverse ? "" + to + ".." + from : ""

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69130766 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -357,160 +363,198 @@ public String toString() { return reverse ? "" + to + ".." + from :

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69131220 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -408,107 +401,86 @@ public void step(int step, Closure closure) { */ @Override

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69132663 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -408,107 +401,86 @@ public void step(int step, Closure closure) { */ @Override

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69133287 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -408,107 +401,86 @@ public void step(int step, Closure closure) { */ @Override

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69133774 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -408,107 +401,86 @@ public void step(int step, Closure closure) { */ @Override

[GitHub] groovy pull request #:

2016-06-30 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/f646e6e12abc3d1a9db0dcff74ff22ecadd986ca#commitcomment-18081357 In gradle/wrapper/gradle-wrapper.properties: In gradle/wrapper/gradle-wrapper.properties on line 6: TeamCity CI should

[jira] [Updated] (GROOVY-7842) MarkupTemplateEngine totally broken when used with a Security Manager

2016-06-30 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-7842: -- Summary: MarkupTemplateEngine totally broken when used with a Security Manager (was: MarkupTemplateEng

[jira] [Updated] (GROOVY-7842) MarkupTemplateEngine totally broken when used with a Security Manager

2016-06-30 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-7842: -- Priority: Critical (was: Blocker) > MarkupTemplateEngine totally broken when used with a Security Mana

[GitHub] groovy pull request #358: GROOVY-7842 - MarkupTemplateEngine Totally Broken

2016-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (GROOVY-7842) MarkupTemplateEngine totally broken when used with a Security Manager

2016-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357409#comment-15357409 ] ASF GitHub Bot commented on GROOVY-7842: Github user asfgit closed the pull reque

[jira] [Resolved] (GROOVY-7842) MarkupTemplateEngine totally broken when used with a Security Manager

2016-06-30 Thread John Wagenleitner (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Wagenleitner resolved GROOVY-7842. --- Resolution: Fixed Assignee: John Wagenleitner Fix Version/s: 2.4.8 Th

[jira] [Commented] (GROOVY-7160) NoSuchMethodError for varargs when type parameter extends interface

2016-06-30 Thread JIRA
[ https://issues.apache.org/jira/browse/GROOVY-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357610#comment-15357610 ] Jesper Steen Møller commented on GROOVY-7160: - Famously, this happens for Enu

[GitHub] groovy pull request #361: Removed JDK 6 from the Travis build

2016-06-30 Thread paplorinc
Github user paplorinc closed the pull request at: https://github.com/apache/groovy/pull/361 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69197327 --- Diff: src/main/groovy/lang/IntRange.java --- @@ -377,40 +382,52 @@ public boolean containsAll(Collection other) { @Override public v

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69197616 --- Diff: src/main/groovy/lang/IntRange.java --- @@ -377,40 +382,52 @@ public boolean containsAll(Collection other) { @Override publi

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69198173 --- Diff: src/main/groovy/lang/IntRange.java --- @@ -355,40 +360,54 @@ public boolean containsAll(Collection other) { return super.containsAll(othe

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69198426 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -488,37 +500,61 @@ public void remove() { @Override public List step(int step) {

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69198622 --- Diff: src/main/groovy/lang/IntRange.java --- @@ -355,40 +360,54 @@ public boolean containsAll(Collection other) { return super.containsAll(o

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69199253 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -488,37 +500,61 @@ public void remove() { @Override public List step(int step)

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69199617 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -488,37 +500,61 @@ public void remove() { @Override public List step(int step) {

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69200220 --- Diff: src/main/groovy/lang/IntRange.java --- @@ -377,40 +382,52 @@ public boolean containsAll(Collection other) { @Override publi

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69199956 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -488,37 +500,61 @@ public void remove() { @Override public List step(int step)

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69201043 --- Diff: src/main/groovy/lang/IntRange.java --- @@ -377,40 +382,52 @@ public boolean containsAll(Collection other) { @Override public v

[GitHub] groovy pull request #357: Groovy 2 4 x x

2016-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69213358 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -240,16 +237,16 @@ public Object get(int index) { if (index < 0) { throw ne

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69213942 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -240,16 +237,16 @@ public Object get(int index) { if (index < 0) { throw ne

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69214004 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -306,14 +303,13 @@ public int size() { } } else {

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69214070 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -339,24 +335,23 @@ public List subList(int fromIndex, int toIndex) { // Performance de

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69214104 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -378,15 +373,13 @@ public String inspect() { */ @Override public boolean cont

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69214359 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -306,14 +303,13 @@ public int size() { } } else {

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread tkruse
Github user tkruse commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69214548 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -499,7 +512,7 @@ public List step(int step) { * @param value the value to increment *

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69214723 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -378,15 +373,13 @@ public String inspect() { */ @Override public boolean c

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69215048 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -240,16 +237,16 @@ public Object get(int index) { if (index < 0) { throw

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69215368 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -499,7 +512,7 @@ public List step(int step) { * @param value the value to increment

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

2016-06-30 Thread paplorinc
Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69219351 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -339,24 +335,23 @@ public List subList(int fromIndex, int toIndex) { // Performance