[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512196 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512201 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512190 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512182 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512093 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512083 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512068 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512060 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512057 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512035 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512007 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512017 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82511988 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82511972 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82511943 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82511934 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain knowle

[jira] [Commented] (GROOVY-7953) Property expressions for extension methods on primitives fail STC

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558686#comment-15558686 ] ASF GitHub Bot commented on GROOVY-7953: Github user PascalSchumacher commented o

[GitHub] groovy pull request #442: GROOVY-7953: property expressions for extension me...

2016-10-08 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/groovy/pull/442#discussion_r82509499 --- Diff: src/spec/test-resources/META-INF/services/org.codehaus.groovy.runtime.ExtensionModule --- @@ -17,5 +17,5 @@ # IT IS A WORKAROUND FOR

[jira] [Commented] (GROOVY-7932) Cannot call private constructor from closures with @CompileStatic

2016-10-08 Thread Shil Sinha (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558634#comment-15558634 ] Shil Sinha commented on GROOVY-7932: The static compiler needs to generate bridge met

[GitHub] groovy pull request #443: Simplify MacroGroovy substitutions' implementation...

2016-10-08 Thread bsideup
GitHub user bsideup opened a pull request: https://github.com/apache/groovy/pull/443 Simplify MacroGroovy substitutions' implementation. Assume the order of substitutions, so we can use a list instead of a map to pass the context. Fixes some Antlr4 migration-related issues

[jira] [Commented] (GROOVY-7951) MethodCallExpression.transformExpression does not copy generic types

2016-10-08 Thread Shil Sinha (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558314#comment-15558314 ] Shil Sinha commented on GROOVY-7951: [~bigehokie] do you have an example which fails

[jira] [Commented] (GROOVY-7953) Property expressions for extension methods on primitives fail STC

2016-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558291#comment-15558291 ] ASF GitHub Bot commented on GROOVY-7953: GitHub user shils opened a pull request:

[GitHub] groovy pull request #442: GROOVY-7953: property expressions for extension me...

2016-10-08 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/442 GROOVY-7953: property expressions for extension methods on primitives… … fail STC You can merge this pull request into a Git repository by running: $ git pull https://github.com/shils/groovy

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread bsideup
Github user bsideup commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82503510 --- Diff: src/spec/test/metaprogramming/ASTMatcherFilteringTest.groovy --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread mariogarcia
Github user mariogarcia commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82503484 --- Diff: src/spec/test/metaprogramming/ASTMatcherTestingTest.groovy --- @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread mariogarcia
Github user mariogarcia commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82503479 --- Diff: src/spec/test/metaprogramming/ASTMatcherFilteringTest.groovy --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread mariogarcia
Github user mariogarcia commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82502595 --- Diff: src/spec/test/metaprogramming/ASTMatcherTestingTest.groovy --- @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread mariogarcia
Github user mariogarcia commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82502579 --- Diff: src/spec/test/metaprogramming/ASTMatcherFilteringTest.groovy --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (A