[jira] [Commented] (GROOVY-8467) IOGroovyMethods class readLine method works unexpected in

2018-02-06 Thread zhuxiaobing (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355095#comment-16355095 ] zhuxiaobing commented on GROOVY-8467: - [~blackdrag] yes, you are correct, this is what i want to say. 

[jira] [Updated] (GROOVY-8472) Final variable analysis doesn't account for early exit

2018-02-06 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-8472: -- Description: An example with early return from a method: {code} def method(String foo) { def str

[jira] [Commented] (GROOVY-8469) org.codehaus.groovy.runtime.typehandling.GroovyCastException:

2018-02-06 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354863#comment-16354863 ] Jochen Theodorou commented on GROOVY-8469: -- Most likely the classloader setup was different for

[jira] [Commented] (GROOVY-8472) Final variable analysis doesn't account for early exit

2018-02-06 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354862#comment-16354862 ] Jochen Theodorou commented on GROOVY-8472: -- to bad that the issue does not really describe the

[jira] [Updated] (GROOVY-8472) Final variable analysis doesn't account for early exit

2018-02-06 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-8472: -- Description: An example with early return from a method: {code} def method(String foo) { def str

[jira] [Created] (GROOVY-8473) Bump asm version to 6.1-beta2

2018-02-06 Thread Daniel Sun (JIRA)
Daniel Sun created GROOVY-8473: -- Summary: Bump asm version to 6.1-beta2 Key: GROOVY-8473 URL: https://issues.apache.org/jira/browse/GROOVY-8473 Project: Groovy Issue Type: Improvement

[jira] [Updated] (GROOVY-8472) Final variable analysis doesn't account for early exit

2018-02-06 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-8472: -- Description: An example with early return from a method: {code} def method(String foo) { def str

[jira] [Created] (GROOVY-8472) Final variable analysis doesn't account for early exit

2018-02-06 Thread Paul King (JIRA)
Paul King created GROOVY-8472: - Summary: Final variable analysis doesn't account for early exit Key: GROOVY-8472 URL: https://issues.apache.org/jira/browse/GROOVY-8472 Project: Groovy Issue

[jira] [Resolved] (GROOVY-8093) Final variable analysis broken within closure fields

2018-02-06 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-8093. --- Resolution: Fixed Assignee: Paul King Fix Version/s: 2.5.0-beta-3 Proposed PR

[jira] [Commented] (GROOVY-8093) Final variable analysis broken within closure fields

2018-02-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354660#comment-16354660 ] ASF GitHub Bot commented on GROOVY-8093: Github user asfgit closed the pull request at:

[GitHub] groovy pull request #659: GROOVY-8093: Final variable analysis broken within...

2018-02-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/659 ---

[jira] [Comment Edited] (GROOVY-8467) IOGroovyMethods class readLine method works unexpected in

2018-02-06 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353849#comment-16353849 ] Paul King edited comment on GROOVY-8467 at 2/6/18 1:04 PM: --- Workaround: use

[jira] [Comment Edited] (GROOVY-8467) IOGroovyMethods class readLine method works unexpected in

2018-02-06 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353849#comment-16353849 ] Paul King edited comment on GROOVY-8467 at 2/6/18 1:03 PM: --- Workaround: use

[jira] [Comment Edited] (GROOVY-8467) IOGroovyMethods class readLine method works unexpected in

2018-02-06 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353849#comment-16353849 ] Paul King edited comment on GROOVY-8467 at 2/6/18 1:02 PM: --- Workaround: use

[jira] [Commented] (GROOVY-8467) IOGroovyMethods class readLine method works unexpected in

2018-02-06 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353849#comment-16353849 ] Paul King commented on GROOVY-8467: --- Workaround: use readLines() or eachLine{ ... } (but they won't

[jira] [Commented] (GROOVY-8467) IOGroovyMethods class readLine method works unexpected in

2018-02-06 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353786#comment-16353786 ] Jochen Theodorou commented on GROOVY-8467: -- I think I see the problem now. If we read

[jira] [Commented] (GROOVY-4105) List Comprehensions are Missing from Groovy

2018-02-06 Thread Mario Garcia (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353753#comment-16353753 ] Mario Garcia commented on GROOVY-4105: -- At the time I started to implement list comprehensions

[jira] [Commented] (GROOVY-5249) Avoid unnecessary locking in ClassInfo.getMetaClass

2018-02-06 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-5249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353751#comment-16353751 ] Jochen Theodorou commented on GROOVY-5249: -- I think just cherry-picking them and not having

[GitHub] groovy pull request #566: Added IgnoreDefaultEqualsAndToString

2018-02-06 Thread pditommaso
Github user pditommaso commented on a diff in the pull request: https://github.com/apache/groovy/pull/566#discussion_r166250753 --- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java --- @@ -12026,6 +12026,9 @@ public static boolean equals(List left, List right)

[GitHub] groovy pull request #566: Added IgnoreDefaultEqualsAndToString

2018-02-06 Thread melix
Github user melix commented on a diff in the pull request: https://github.com/apache/groovy/pull/566#discussion_r166246347 --- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java --- @@ -12026,6 +12026,9 @@ public static boolean equals(List left, List right) {

[jira] [Commented] (GROOVY-8093) Final variable analysis broken within closure fields

2018-02-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353565#comment-16353565 ] ASF GitHub Bot commented on GROOVY-8093: GitHub user paulk-asert opened a pull request:

[GitHub] groovy pull request #659: GROOVY-8093: Final variable analysis broken within...

2018-02-06 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/659 GROOVY-8093: Final variable analysis broken within closure fields You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy