[
https://issues.apache.org/jira/browse/GROOVY-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421182#comment-16421182
]
ASF GitHub Bot commented on GROOVY-8525:
Github user asfgit closed the pull reque
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/679
---
[
https://issues.apache.org/jira/browse/GROOVY-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421173#comment-16421173
]
ASF GitHub Bot commented on GROOVY-8525:
Github user danielsun1106 commented on a
Github user danielsun1106 commented on a diff in the pull request:
https://github.com/apache/groovy/pull/679#discussion_r178422703
--- Diff:
src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
@@ -175,6 +174,11 @@ private V compute(K key, ValueProvider val
[
https://issues.apache.org/jira/browse/GROOVY-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421167#comment-16421167
]
ASF GitHub Bot commented on GROOVY-8525:
Github user paulk-asert commented on a d
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/679#discussion_r178422137
--- Diff:
src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
@@ -175,6 +174,11 @@ private V compute(K key, ValueProvider value
[
https://issues.apache.org/jira/browse/GROOVY-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421151#comment-16421151
]
ASF GitHub Bot commented on GROOVY-8525:
Github user danielsun1106 commented on a
Github user danielsun1106 commented on a diff in the pull request:
https://github.com/apache/groovy/pull/679#discussion_r178421232
--- Diff:
src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
@@ -175,6 +174,11 @@ private V compute(K key, ValueProvider val
[
https://issues.apache.org/jira/browse/GROOVY-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421150#comment-16421150
]
ASF GitHub Bot commented on GROOVY-8525:
Github user paulk-asert commented on a d
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/679#discussion_r178421035
--- Diff:
src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
@@ -199,20 +208,35 @@ public int size() {
return doW
[
https://issues.apache.org/jira/browse/GROOVY-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421149#comment-16421149
]
ASF GitHub Bot commented on GROOVY-8525:
Github user paulk-asert commented on a d
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/679#discussion_r178421016
--- Diff:
src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
@@ -175,6 +174,11 @@ private V compute(K key, ValueProvider value
[
https://issues.apache.org/jira/browse/GROOVY-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421140#comment-16421140
]
ASF GitHub Bot commented on GROOVY-8525:
Github user danielsun1106 commented on a
Github user danielsun1106 commented on a diff in the pull request:
https://github.com/apache/groovy/pull/679#discussion_r178419989
--- Diff:
src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
@@ -199,20 +208,35 @@ public int size() {
return d
[
https://issues.apache.org/jira/browse/GROOVY-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421139#comment-16421139
]
ASF GitHub Bot commented on GROOVY-8525:
Github user danielsun1106 commented on a
Github user danielsun1106 commented on a diff in the pull request:
https://github.com/apache/groovy/pull/679#discussion_r178419950
--- Diff:
src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
@@ -175,6 +174,11 @@ private V compute(K key, ValueProvider val
[
https://issues.apache.org/jira/browse/GROOVY-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421066#comment-16421066
]
ASF GitHub Bot commented on GROOVY-8525:
GitHub user paulk-asert opened a pull re
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/679
GROOVY-8525: Binary compatibility issue for GroovyClassLoader betweenâ¦
⦠2.4 vs later branches (alternative to PR#678)
What I haven't yet checked is whether we need to make some of t
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28347747
In src/antlr/GroovyLexer.g4:
If we do not like `'''1234''`, we can forbid it by lexer. To be honest,
I don't care ab
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28347515
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
But ''' and """ can quote themselves given the cu
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28347461
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
Let's discuss at
http://groovy.329449.n5.nabbl
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28347291
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
`/` and `'` can not quote themselves, so `/123
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28346795
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
I don't see this as a case of it can be done so i
[
https://issues.apache.org/jira/browse/GROOVY-8524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420403#comment-16420403
]
Daniel Sun commented on GROOVY-8524:
Here is a minor improvement for the new parser:
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28346491
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
Paul, `'''` and `"""` should be able to quote a
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28346403
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
There is no doubt some merit to this approach but
[
https://issues.apache.org/jira/browse/GROOVY-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420388#comment-16420388
]
ASF GitHub Bot commented on GROOVY-8525:
GitHub user paulk-asert opened a pull re
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/678
GROOVY-8525: Binary compatibility issue for GroovyClassLoader betweenâ¦
⦠2.4 vs later branches
You can merge this pull request into a Git repository by running:
$ git pull https://githu
[
https://issues.apache.org/jira/browse/GROOVY-8524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King resolved GROOVY-8524.
---
Resolution: Not A Problem
> Triple quoted string with quotes on end of line
> ---
[
https://issues.apache.org/jira/browse/GROOVY-8524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420368#comment-16420368
]
Paul King commented on GROOVY-8524:
---
Yes, it is expected behavior. You have a stray sin
[
https://issues.apache.org/jira/browse/GROOVY-8524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420298#comment-16420298
]
Daniel Sun edited comment on GROOVY-8524 at 3/30/18 8:59 AM:
-
[
https://issues.apache.org/jira/browse/GROOVY-8524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Sun updated GROOVY-8524:
---
Priority: Minor (was: Major)
> Triple quoted string with quotes on end of line
> ---
[
https://issues.apache.org/jira/browse/GROOVY-8524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420298#comment-16420298
]
Daniel Sun commented on GROOVY-8524:
When parser finds another ''', it will think tri
[
https://issues.apache.org/jira/browse/GROOVY-8524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Sun updated GROOVY-8524:
---
Component/s: (was: groovy-runtime)
lexer
> Triple quoted string with quotes on e
Paul King created GROOVY-8525:
-
Summary: Binary compatibility issue for GroovyClassLoader between
2.4 vs later branches
Key: GROOVY-8525
URL: https://issues.apache.org/jira/browse/GROOVY-8525
Project: Gro
Anvar Baimurunov created GROOVY-8524:
Summary: Triple quoted string with quotes on end of line
Key: GROOVY-8524
URL: https://issues.apache.org/jira/browse/GROOVY-8524
Project: Groovy
Issu
36 matches
Mail list logo
