Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28388536
Reverted all... trying to add missing `serialVersionUID` for 2.4 first
---
[
https://issues.apache.org/jira/browse/GROOVY-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King resolved GROOVY-8523.
---
Resolution: Fixed
Assignee: Paul King
Fix Version/s: 2.5.0-rc-1
PR merged. Thanks!
>
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28388135
Technically we only need to "fix" the broken bits but it will be easiest to
revert on all branches and work from the 2.4 branc
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28388111
Reverted on 2.4 branch:
https://github.com/apache/groovy/commit/c4253d71abdef1499d59f3d55c5b86aac5b82292
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387971
revert the commit on all branches?
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387886
Please revert. That just also breaks serializable compability between
2.4.15 and 2_4_X HEAD!!
Run this script on 2.4.
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387615
See
https://github.com/apache/groovy/commit/b7c9db3aa0e50cef860c43e0d9e303671106ae89
The missing `serialVersionUID` are
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387375
Let me generate you an example ...
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387373
my last reply was to your earlier comment.
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387370
OK. I'll sync the changes of 2.5 to 2.4 later.
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387349
Not all the classes probably gave errors but yep, that will probably be the
easiest. The only other comment I'll make is that
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387340
Paul, if we sync the changes of 2.5 to 2.4, the result should be same...
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387318
Let me revert the commit and generate missing `serialVersionUID` for 2.4,
at last sync the changes to other branches.
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387291
Bonus points if you can pin-point what is causing the false positives - we
should submit a bug report/PR to japicmp to fix our
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387263
Best bet for checking is to just serialize from 2.4 using
ObjectOutputStream into a dat file (binary file) and read that back
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387229
Also, I'd note that in some cases, like the ObservableList/Map/Set example
which weren't serializable in the first place - con
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387216
To keep serializability compatible within 2.4 we can add serialVersionUID
values generated from the 2.4 codebase. We can then
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387182
Yes but it will break serializability within a point release!
---
[
https://issues.apache.org/jira/browse/GROOVY-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Sun updated GROOVY-8523:
---
Priority: Major (was: Minor)
> Static type checking instanceof
> ---
>
>
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28386578
Syncing the changes to 2.4 branch will remove these warnings?
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28386425
If you get a chance to check the "Serializable incompatible(!)" warnings
from the checkBinaryCompatibility task that would be
[
https://issues.apache.org/jira/browse/GROOVY-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423274#comment-16423274
]
ASF GitHub Bot commented on GROOVY-8523:
Github user asfgit closed the pull reque
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/680
---
[
https://issues.apache.org/jira/browse/GROOVY-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422792#comment-16422792
]
Nikolay Chugunov commented on GROOVY-8523:
--
PR ready, link attached
> Static ty
24 matches
Mail list logo
