[GitHub] danielsun1106 commented on issue #865: GROOVY-8272: Extending trait can't execute static method

2019-01-28 Thread GitBox
danielsun1106 commented on issue #865: GROOVY-8272: Extending trait can't execute static method URL: https://github.com/apache/groovy/pull/865#issuecomment-458434766 +1 This is an automated message from the Apache Git Ser

[GitHub] danielsun1106 commented on issue #863: Trivial refactoring: replace explicit type with `<>` for simplicity

2019-01-28 Thread GitBox
danielsun1106 commented on issue #863: Trivial refactoring: replace explicit type with `<>` for simplicity URL: https://github.com/apache/groovy/pull/863#issuecomment-458429946 Understood. Keep it as it is or apply the patch for all branches. ---

[GitHub] paulk-asert commented on issue #861: Trivial refactoring: handle `Sql` with try-with-resources for simplicity

2019-01-28 Thread GitBox
paulk-asert commented on issue #861: Trivial refactoring: handle `Sql` with try-with-resources for simplicity URL: https://github.com/apache/groovy/pull/861#issuecomment-458419366 +1 This is an automated message from the Apac

[GitHub] paulk-asert commented on issue #862: Trivial refactoring: remove unnecessary boxing and unboxing for simpl…

2019-01-28 Thread GitBox
paulk-asert commented on issue #862: Trivial refactoring: remove unnecessary boxing and unboxing for simpl… URL: https://github.com/apache/groovy/pull/862#issuecomment-458419314 +1 This is an automated message from the Apache

[GitHub] paulk-asert commented on issue #864: GROOVY-8970: Fix typo in MANIFEST.MF: Main-class

2019-01-28 Thread GitBox
paulk-asert commented on issue #864: GROOVY-8970: Fix typo in MANIFEST.MF: Main-class URL: https://github.com/apache/groovy/pull/864#issuecomment-458418672 +1. My understanding is that header names are case insensitive but we should use the typical convention of using uppercase for both pa

[GitHub] paulk-asert opened a new pull request #865: GROOVY-8272: Extending trait can't execute static method

2019-01-28 Thread GitBox
paulk-asert opened a new pull request #865: GROOVY-8272: Extending trait can't execute static method URL: https://github.com/apache/groovy/pull/865 This is an automated message from the Apache Git Service. To respond to the

[GitHub] paulk-asert edited a comment on issue #863: Trivial refactoring: replace explicit type with `<>` for simplicity

2019-01-28 Thread GitBox
paulk-asert edited a comment on issue #863: Trivial refactoring: replace explicit type with `<>` for simplicity URL: https://github.com/apache/groovy/pull/863#issuecomment-458416752 +1. As further background, we have delayed doing such changes earlier since having such differences between

[GitHub] paulk-asert edited a comment on issue #863: Trivial refactoring: replace explicit type with `<>` for simplicity

2019-01-28 Thread GitBox
paulk-asert edited a comment on issue #863: Trivial refactoring: replace explicit type with `<>` for simplicity URL: https://github.com/apache/groovy/pull/863#issuecomment-458416752 +1. As further background, we have delayed doing such changes earlier since having such differences between

[GitHub] paulk-asert commented on issue #863: Trivial refactoring: replace explicit type with `<>` for simplicity

2019-01-28 Thread GitBox
paulk-asert commented on issue #863: Trivial refactoring: replace explicit type with `<>` for simplicity URL: https://github.com/apache/groovy/pull/863#issuecomment-458416752 +1. As further background, we have delayed doing such changes earlier since having such differences between branche

[jira] [Created] (GROOVY-8974) STC ignores declaration type

2019-01-28 Thread Daniil Ovchinnikov (JIRA)
Daniil Ovchinnikov created GROOVY-8974: -- Summary: STC ignores declaration type Key: GROOVY-8974 URL: https://issues.apache.org/jira/browse/GROOVY-8974 Project: Groovy Issue Type: Bug

[jira] [Closed] (GROOVY-3358) static imports don't work for statically defined getters (property access)

2019-01-28 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King closed GROOVY-3358. - I'll close this as it seems to have been fixed earlier: {code:java} class Environment { private static I

[jira] [Updated] (GROOVY-3358) static imports don't work for statically defined getters (property access)

2019-01-28 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-3358: -- Fix Version/s: (was: 4.x) > static imports don't work for statically defined getters (property acc

[jira] [Created] (GROOVY-8973) groovy.lang.MissingPropertyException with GORM and Groovy 2.5.5

2019-01-28 Thread JIRA
Iván López created GROOVY-8973: -- Summary: groovy.lang.MissingPropertyException with GORM and Groovy 2.5.5 Key: GROOVY-8973 URL: https://issues.apache.org/jira/browse/GROOVY-8973 Project: Groovy