[GitHub] danielsun1106 commented on issue #860: Fix non-atomic operation on volatile field 'count'

2019-02-04 Thread GitBox
danielsun1106 commented on issue #860: Fix non-atomic operation on volatile field 'count' URL: https://github.com/apache/groovy/pull/860#issuecomment-460519196 @blackdrag Thanks for your analysis  and your advice is always helpful.

[GitHub] danielsun1106 commented on issue #860: Fix non-atomic operation on volatile field 'count'

2019-02-04 Thread GitBox
danielsun1106 commented on issue #860: Fix non-atomic operation on volatile field 'count' URL: https://github.com/apache/groovy/pull/860#issuecomment-460518848 @melix I run static analysis from time to time, the potential issue was found by the tool. It is related to thread safe, so it's

[GitHub] asfgit closed pull request #871: Documentation: add mandatory tag for the groovy-all artifact

2019-02-04 Thread GitBox
asfgit closed pull request #871: Documentation: add mandatory tag for the groovy-all artifact URL: https://github.com/apache/groovy/pull/871 This is an automated message from the Apache Git Service. To respond to the

[GitHub] paulk-asert commented on issue #871: Documentation: add mandatory tag for the groovy-all artifact

2019-02-04 Thread GitBox
paulk-asert commented on issue #871: Documentation: add mandatory tag for the groovy-all artifact URL: https://github.com/apache/groovy/pull/871#issuecomment-460500844 Merged, thanks! This is an automated message from the

[GitHub] blackdrag commented on issue #860: Fix non-atomic operation on volatile field 'count'

2019-02-04 Thread GitBox
blackdrag commented on issue #860: Fix non-atomic operation on volatile field 'count' URL: https://github.com/apache/groovy/pull/860#issuecomment-460484213 My personal analysis on this is the following as long as count is only changed within a lock/unlock sequence volatile should be

[GitHub] melix commented on issue #860: Fix non-atomic operation on volatile field 'count'

2019-02-04 Thread GitBox
melix commented on issue #860: Fix non-atomic operation on volatile field 'count' URL: https://github.com/apache/groovy/pull/860#issuecomment-460419322 Can you give more context for this change? Is it a bugfix for something you saw? If so can you write a test?

[jira] [Resolved] (GROOVY-8980) Bump picocli to 3.9.3

2019-02-04 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun resolved GROOVY-8980. Resolution: Fixed Fixed by 

[GitHub] asfgit closed pull request #872: GROOVY-8980: Bump picocli to 3.9.3

2019-02-04 Thread GitBox
asfgit closed pull request #872: GROOVY-8980: Bump picocli to 3.9.3 URL: https://github.com/apache/groovy/pull/872 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[jira] [Created] (GROOVY-8980) Bump picocli to 3.9.3

2019-02-04 Thread Daniel Sun (JIRA)
Daniel Sun created GROOVY-8980: -- Summary: Bump picocli to 3.9.3 Key: GROOVY-8980 URL: https://issues.apache.org/jira/browse/GROOVY-8980 Project: Groovy Issue Type: Dependency upgrade

[GitHub] danielsun1106 opened a new pull request #872: GROOVY-8980: Bump picocli to 3.9.3

2019-02-04 Thread GitBox
danielsun1106 opened a new pull request #872: GROOVY-8980: Bump picocli to 3.9.3 URL: https://github.com/apache/groovy/pull/872 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] danielsun1106 commented on issue #860: Fix non-atomic operation on volatile field 'count'

2019-02-04 Thread GitBox
danielsun1106 commented on issue #860: Fix non-atomic operation on volatile field 'count' URL: https://github.com/apache/groovy/pull/860#issuecomment-460400810 ping @melix This is an automated message from the Apache Git

[GitHub] energister opened a new pull request #871: Add mandatory tag for the groovy-all artifact

2019-02-04 Thread GitBox
energister opened a new pull request #871: Add mandatory tag for the groovy-all artifact URL: https://github.com/apache/groovy/pull/871 without `pom` tag maven breaks build with > Failure to find org.codehaus.groovy:groovy-all:jar:2.5.5 in https://repo.maven.apache.org/maven2 was

[jira] [Created] (GROOVY-8979) JDK 11,java.lang.ClassCastException: class [B cannot be cast to class [C ([B and [C are in module java.base of loader 'bootstrap')

2019-02-04 Thread TarakA (JIRA)
TarakA created GROOVY-8979: -- Summary: JDK 11,java.lang.ClassCastException: class [B cannot be cast to class [C ([B and [C are in module java.base of loader 'bootstrap') Key: GROOVY-8979 URL:

[GitHub] asfgit closed pull request #862: Trivial refactoring: remove unnecessary boxing and unboxing for simpl…

2019-02-04 Thread GitBox
asfgit closed pull request #862: Trivial refactoring: remove unnecessary boxing and unboxing for simpl… URL: https://github.com/apache/groovy/pull/862 This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (GROOVY-8978) NPE when accessing protected method from subclass clone

2019-02-04 Thread paolo di tommaso (JIRA)
paolo di tommaso created GROOVY-8978: Summary: NPE when accessing protected method from subclass clone Key: GROOVY-8978 URL: https://issues.apache.org/jira/browse/GROOVY-8978 Project: Groovy

[GitHub] danielsun1106 closed pull request #863: Trivial refactoring: replace explicit type with `<>` for simplicity

2019-02-04 Thread GitBox
danielsun1106 closed pull request #863: Trivial refactoring: replace explicit type with `<>` for simplicity URL: https://github.com/apache/groovy/pull/863 This is an automated message from the Apache Git Service. To respond