[GitHub] [groovy] danielsun1106 commented on issue #906: GROOVY-9073: added compiler option to enable preview features (JEP 12)

2019-04-12 Thread GitBox
danielsun1106 commented on issue #906: GROOVY-9073: added compiler option to enable preview features (JEP 12) URL: https://github.com/apache/groovy/pull/906#issuecomment-482778104 Make some changes and push, which will trigger the CI build, at last we can see the build result.

[GitHub] [groovy] keeganwitt commented on issue #906: GROOVY-9073: added compiler option to enable preview features (JEP 12)

2019-04-12 Thread GitBox
keeganwitt commented on issue #906: GROOVY-9073: added compiler option to enable preview features (JEP 12) URL: https://github.com/apache/groovy/pull/906#issuecomment-482777613 I'm not sure why checks were failing. It'd be kinda nice to have some tests for it too, but I'm not sure how

[jira] [Commented] (GROOVY-9080) MarkupTemplateEngine uses invalid XML entity for escaping double quotes

2019-04-12 Thread Dan Ziemba (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816660#comment-16816660 ] Dan Ziemba commented on GROOVY-9080: Looks like all that is needed is to fix the

[jira] [Created] (GROOVY-9080) MarkupTemplateEngine uses invalid XML entity for escaping double quotes

2019-04-12 Thread Dan Ziemba (JIRA)
Dan Ziemba created GROOVY-9080: -- Summary: MarkupTemplateEngine uses invalid XML entity for escaping double quotes Key: GROOVY-9080 URL: https://issues.apache.org/jira/browse/GROOVY-9080 Project: Groovy

[GitHub] [groovy] danielsun1106 opened a new pull request #909: Add the missing delegate methods to `InnerLoader`

2019-04-12 Thread GitBox
danielsun1106 opened a new pull request #909: Add the missing delegate methods to `InnerLoader` URL: https://github.com/apache/groovy/pull/909 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [groovy] danielsun1106 commented on issue #906: GROOVY-9073: added compiler option to enable preview features (JEP 12)

2019-04-12 Thread GitBox
danielsun1106 commented on issue #906: GROOVY-9073: added compiler option to enable preview features (JEP 12) URL: https://github.com/apache/groovy/pull/906#issuecomment-482651668 +1 This is an automated message from the

[GitHub] [groovy] danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API

2019-04-12 Thread GitBox
danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482642708 @blackdrag As far as I know, `javax.tools.JavaCompiler` is a normal official API and will not stop working suddenly, isn't it?

[GitHub] [groovy] danielsun1106 edited a comment on issue #904: GROOVY-9067: Compile Java stubs with standard API

2019-04-12 Thread GitBox
danielsun1106 edited a comment on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482640324 @blackdrag Jochen, in-memory compilation is still supported, but in-file compilation is changed to rely on the same

[GitHub] [groovy] danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API

2019-04-12 Thread GitBox
danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482640324 @blackdrag Jochen, in-memory compilation is still supported, but in-file compilation is changed to rely on the same API, e.g.

[GitHub] [groovy] blackdrag commented on issue #904: GROOVY-9067: Compile Java stubs with standard API

2019-04-12 Thread GitBox
blackdrag commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482637564 you are doing more than undoing the change for the in-memory compilation? In general I am partial to in-memory compilation, but it

[GitHub] [groovy] danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API

2019-04-12 Thread GitBox
danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482633625 @paulk-asert @blackdrag Please set aside some time to review the PR.

[jira] [Updated] (GROOVY-9076) Debugger Step Into doesn't work in Groovy-compiled classes

2019-04-12 Thread Daniil Ovchinnikov (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniil Ovchinnikov updated GROOVY-9076: --- Description: Please see https://github.com/dovchinnikov/debug-groovy-bug