[GitHub] [groovy] paulk-asert commented on issue #1072: refactor code

2019-11-06 Thread GitBox
paulk-asert commented on issue #1072: refactor code URL: https://github.com/apache/groovy/pull/1072#issuecomment-550717197 Merged. Thanks! This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [groovy] asfgit closed pull request #1072: refactor code

2019-11-06 Thread GitBox
asfgit closed pull request #1072: refactor code URL: https://github.com/apache/groovy/pull/1072 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [groovy] mattisonzhao opened a new pull request #1072: refactor code

2019-11-06 Thread GitBox
mattisonzhao opened a new pull request #1072: refactor code URL: https://github.com/apache/groovy/pull/1072 refactor some code about unnecessary objects This is an automated message from the Apache Git Service. To respond to t

[jira] [Commented] (GROOVY-9301) Parser error for enum constant with comma followed by method

2019-11-06 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968817#comment-16968817 ] Daniel Sun commented on GROOVY-9301: I'm trying to fix the issue for Parrot parser

[GitHub] [groovy] eric-milles opened a new pull request #1071: GROOVY-8372: GrapeIvy: pass remote (not local) conf to addDependencyArtifact

2019-11-06 Thread GitBox
eric-milles opened a new pull request #1071: GROOVY-8372: GrapeIvy: pass remote (not local) conf to addDependencyArtifact URL: https://github.com/apache/groovy/pull/1071 add dependency artifacts only if ext, type or classifier is non-default closes #626 -

[jira] [Commented] (GROOVY-9211) BUG! UNCAUGHT EXCEPTION on OpenJDK14-ea+8

2019-11-06 Thread Ross Goldberg (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968453#comment-16968453 ] Ross Goldberg commented on GROOVY-9211: --- Will ASM ever be updated for 2.x so this

[GitHub] [groovy] danielsun1106 merged pull request #1070: Minor refactoring: remove unnecessary visiting

2019-11-06 Thread GitBox
danielsun1106 merged pull request #1070: Minor refactoring: remove unnecessary visiting URL: https://github.com/apache/groovy/pull/1070 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [groovy] danielsun1106 opened a new pull request #1070: Minor refactoring: remove unnecessary visiting

2019-11-06 Thread GitBox
danielsun1106 opened a new pull request #1070: Minor refactoring: remove unnecessary visiting URL: https://github.com/apache/groovy/pull/1070 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [groovy] danielsun1106 merged pull request #1069: refactor code

2019-11-06 Thread GitBox
danielsun1106 merged pull request #1069: refactor code URL: https://github.com/apache/groovy/pull/1069 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [groovy] danielsun1106 commented on issue #1069: refactor code

2019-11-06 Thread GitBox
danielsun1106 commented on issue #1069: refactor code URL: https://github.com/apache/groovy/pull/1069#issuecomment-550239515 Merged. Thanks! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [groovy] mattisonzhao opened a new pull request #1069: refactor code

2019-11-06 Thread GitBox
mattisonzhao opened a new pull request #1069: refactor code URL: https://github.com/apache/groovy/pull/1069 I refactor some code about new java version and some unnecessary objects that I leant from effective java item6. --Make progress every day! -