[GitHub] [groovy] danielsun1106 commented on a change in pull request #1319: Minor tweak: create `Lookup` instance according to vm plugin

2020-08-08 Thread GitBox
danielsun1106 commented on a change in pull request #1319: URL: https://github.com/apache/groovy/pull/1319#discussion_r467536418 ## File path: src/main/java/org/codehaus/groovy/vmplugin/v8/Java8.java ## @@ -636,7 +637,7 @@ private Object getInvokeSpecialHandleFallback(Method

[jira] [Resolved] (GROOVY-9677) provide a library of pre-canned macro methods

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun resolved GROOVY-9677. Fix Version/s: 4.0.0-alpha-1 Assignee: Paul King Resolution: Fixed > provide a

[GitHub] [groovy] danielsun1106 commented on pull request #1343: GROOVY-9677: provide a library of pre-canned macro methods

2020-08-08 Thread GitBox
danielsun1106 commented on pull request #1343: URL: https://github.com/apache/groovy/pull/1343#issuecomment-671006231 Merged. Thanks. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [groovy] danielsun1106 merged pull request #1343: GROOVY-9677: provide a library of pre-canned macro methods

2020-08-08 Thread GitBox
danielsun1106 merged pull request #1343: URL: https://github.com/apache/groovy/pull/1343 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (GROOVY-9675) There should be a mechanism to disable individual macro methods & extension methods

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun resolved GROOVY-9675. Fix Version/s: 4.0.0-alpha-1 Assignee: Paul King Resolution: Fixed > There should

[GitHub] [groovy] danielsun1106 merged pull request #1342: GROOVY-9675: There should be a mechanism to disable individual macro …

2020-08-08 Thread GitBox
danielsun1106 merged pull request #1342: URL: https://github.com/apache/groovy/pull/1342 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [groovy] danielsun1106 commented on pull request #1342: GROOVY-9675: There should be a mechanism to disable individual macro …

2020-08-08 Thread GitBox
danielsun1106 commented on pull request #1342: URL: https://github.com/apache/groovy/pull/1342#issuecomment-671006159 Merged. Thanks. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [groovy] danielsun1106 commented on pull request #1339: Support useAs for @NamedVariant

2020-08-08 Thread GitBox
danielsun1106 commented on pull request #1339: URL: https://github.com/apache/groovy/pull/1339#issuecomment-671002758 The relevant test is expected for verifying the changes. This is an automated message from the Apache Git

[GitHub] [groovy] danielsun1106 commented on a change in pull request #1339: Support useAs for @NamedVariant

2020-08-08 Thread GitBox
danielsun1106 commented on a change in pull request #1339: URL: https://github.com/apache/groovy/pull/1339#discussion_r467532468 ## File path: src/main/java/org/codehaus/groovy/transform/NamedVariantASTTransformation.java ## @@ -238,23 +244,37 @@ private void

[GitHub] [groovy] danielsun1106 commented on a change in pull request #1339: Support useAs for @NamedVariant

2020-08-08 Thread GitBox
danielsun1106 commented on a change in pull request #1339: URL: https://github.com/apache/groovy/pull/1339#discussion_r467532425 ## File path: src/main/java/org/codehaus/groovy/transform/NamedVariantASTTransformation.java ## @@ -238,23 +244,37 @@ private void

[jira] [Resolved] (GROOVY-9679) The fork-join pool does not provide a good ClassLoader for Groovy types

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun resolved GROOVY-9679. Fix Version/s: 3.0.6 Resolution: Fixed > The fork-join pool does not provide a good

[GitHub] [groovy] danielsun1106 commented on pull request #1330: The fork-join pool does not provide a good ClassLoader for Groovy types

2020-08-08 Thread GitBox
danielsun1106 commented on pull request #1330: URL: https://github.com/apache/groovy/pull/1330#issuecomment-671001607 Merged with some trivial tweaks for better backward compatibility. Thanks! This is an automated message

[GitHub] [groovy] asfgit closed pull request #1330: The fork-join pool does not provide a good ClassLoader for Groovy types

2020-08-08 Thread GitBox
asfgit closed pull request #1330: URL: https://github.com/apache/groovy/pull/1330 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (GROOVY-9679) The fork-join pool does not provide a good ClassLoader for Groovy types

2020-08-08 Thread Daniel Sun (Jira)
Daniel Sun created GROOVY-9679: -- Summary: The fork-join pool does not provide a good ClassLoader for Groovy types Key: GROOVY-9679 URL: https://issues.apache.org/jira/browse/GROOVY-9679 Project: Groovy

[jira] [Updated] (GROOVY-9673) GroovyCastException when using Trait.super.name = ... with multiple setters

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-9673: --- Fix Version/s: 3.0.6 > GroovyCastException when using Trait.super.name = ... with multiple setters

[jira] [Updated] (GROOVY-9255) trait property throws MissingPropertyException when read using qualified super expression

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-9255: --- Fix Version/s: 3.0.6 > trait property throws MissingPropertyException when read using qualified >

[jira] [Updated] (GROOVY-9386) Field initialized in a trait using tap doesn't work correctly

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-9386: --- Fix Version/s: 3.0.6 > Field initialized in a trait using tap doesn't work correctly >

[jira] [Updated] (GROOVY-9673) GroovyCastException when using Trait.super.name = ... with multiple setters

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-9673: --- Fix Version/s: (was: 3.0.6) > GroovyCastException when using Trait.super.name = ... with

[jira] [Updated] (GROOVY-9255) trait property throws MissingPropertyException when read using qualified super expression

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-9255: --- Fix Version/s: (was: 3.0.6) > trait property throws MissingPropertyException when read using

[jira] [Updated] (GROOVY-9386) Field initialized in a trait using tap doesn't work correctly

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-9386: --- Labels: (was: breaking) > Field initialized in a trait using tap doesn't work correctly >

[jira] [Updated] (GROOVY-9386) Field initialized in a trait using tap doesn't work correctly

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-9386: --- Labels: breaking (was: ) > Field initialized in a trait using tap doesn't work correctly >

[jira] [Updated] (GROOVY-9386) Field initialized in a trait using tap doesn't work correctly

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-9386: --- Fix Version/s: (was: 3.0.6) > Field initialized in a trait using tap doesn't work correctly >

[jira] [Resolved] (GROOVY-9256) trait qualified-super expressions fail when inside closure

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun resolved GROOVY-9256. Fix Version/s: 3.0.6 4.0.0-alpha-1 Resolution: Fixed > trait

[jira] [Resolved] (GROOVY-9673) GroovyCastException when using Trait.super.name = ... with multiple setters

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun resolved GROOVY-9673. Fix Version/s: 3.0.6 4.0.0-alpha-1 Resolution: Fixed >

[jira] [Resolved] (GROOVY-9386) Field initialized in a trait using tap doesn't work correctly

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun resolved GROOVY-9386. Fix Version/s: 3.0.6 4.0.0-alpha-1 Resolution: Fixed > Field

[jira] [Resolved] (GROOVY-9255) trait property throws MissingPropertyException when read using qualified super expression

2020-08-08 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun resolved GROOVY-9255. Fix Version/s: 3.0.6 4.0.0-alpha-1 Resolution: Fixed > trait property

[jira] [Created] (GROOVY-9678) traits: add support for static property notation in static contexts

2020-08-08 Thread Eric Milles (Jira)
Eric Milles created GROOVY-9678: --- Summary: traits: add support for static property notation in static contexts Key: GROOVY-9678 URL: https://issues.apache.org/jira/browse/GROOVY-9678 Project: Groovy

[jira] [Commented] (GROOVY-7373) Interact Closures withing Groovy Trait methods are not recognized by the implementing class

2020-08-08 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173705#comment-17173705 ] Eric Milles commented on GROOVY-7373: - Probably resolved by GROOVY-9386 > Interact Closures withing

[jira] [Assigned] (GROOVY-7373) Interact Closures withing Groovy Trait methods are not recognized by the implementing class

2020-08-08 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-7373: --- Assignee: Eric Milles > Interact Closures withing Groovy Trait methods are not recognized

[jira] [Commented] (GROOVY-7399) Method "with()" fails to call on the object reference in Trait

2020-08-08 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173704#comment-17173704 ] Eric Milles commented on GROOVY-7399: - Fixed by GROOVY-9386 > Method "with()" fails to call on the

[jira] [Assigned] (GROOVY-7399) Method "with()" fails to call on the object reference in Trait

2020-08-08 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-7399: --- Assignee: Eric Milles > Method "with()" fails to call on the object reference in Trait >

[jira] [Commented] (GROOVY-7759) @Lazy does not work when used in a Trait

2020-08-08 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173703#comment-17173703 ] Eric Milles commented on GROOVY-7759: - {code:groovy} trait T { @Lazy String x = { -> 'works' }() }

[jira] [Assigned] (GROOVY-7759) @Lazy does not work when used in a Trait

2020-08-08 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-7759: --- Assignee: Eric Milles > @Lazy does not work when used in a Trait >

[jira] [Commented] (GROOVY-7843) Trait method calling closure cannot be inherited while using CompileStatic

2020-08-08 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-7843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173702#comment-17173702 ] Eric Milles commented on GROOVY-7843: - Fixed by GROOVY-9386 > Trait method calling closure cannot

[jira] [Assigned] (GROOVY-7843) Trait method calling closure cannot be inherited while using CompileStatic

2020-08-08 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-7843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-7843: --- Assignee: Eric Milles > Trait method calling closure cannot be inherited while using

[jira] [Assigned] (GROOVY-8049) Trait properties with 'with'

2020-08-08 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-8049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-8049: --- Assignee: Eric Milles > Trait properties with 'with' > > >

[jira] [Commented] (GROOVY-8049) Trait properties with 'with'

2020-08-08 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-8049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173701#comment-17173701 ] Eric Milles commented on GROOVY-8049: - Fixed by GROOVY-9386 > Trait properties with 'with' >

[jira] [Commented] (GROOVY-8820) Closure inside trait cannot use Closure's delegate variables

2020-08-08 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-8820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173699#comment-17173699 ] Eric Milles commented on GROOVY-8820: - Fixed by GROOVY-9386 > Closure inside trait cannot use

[jira] [Assigned] (GROOVY-8820) Closure inside trait cannot use Closure's delegate variables

2020-08-08 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-8820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-8820: --- Assignee: Eric Milles > Closure inside trait cannot use Closure's delegate variables >

[jira] [Assigned] (GROOVY-9672) trait conflict resolution not available for static methods

2020-08-08 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-9672: --- Assignee: Eric Milles > trait conflict resolution not available for static methods >

[GitHub] [groovy] eric-milles opened a new pull request #1344: GROOVY-9672: traits: replace "this" argument with "Type" for static super call

2020-08-08 Thread GitBox
eric-milles opened a new pull request #1344: URL: https://github.com/apache/groovy/pull/1344 https://issues.apache.org/jira/browse/GROOVY-9672 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [groovy] eric-milles merged pull request #1341: GROOVY-9256: process closure expressions for Trait.super.name transforms

2020-08-08 Thread GitBox
eric-milles merged pull request #1341: URL: https://github.com/apache/groovy/pull/1341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [groovy] eric-milles merged pull request #1338: GROOVY-9673: do not set method target on call expr in case of overloads

2020-08-08 Thread GitBox
eric-milles merged pull request #1338: URL: https://github.com/apache/groovy/pull/1338 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [groovy] eric-milles merged pull request #1340: GROOVY-9255: transform "TraitType.super.name" to getName()/isName() call

2020-08-08 Thread GitBox
eric-milles merged pull request #1340: URL: https://github.com/apache/groovy/pull/1340 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [groovy] eric-milles merged pull request #1334: GROOVY-9386: traits: do not transform dynamic variable within closure

2020-08-08 Thread GitBox
eric-milles merged pull request #1334: URL: https://github.com/apache/groovy/pull/1334 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (GROOVY-7996) Using with method with a closure that references a protected property produces ClassCastException

2020-08-08 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173632#comment-17173632 ] Paul King commented on GROOVY-7996: --- I know this was a while ago, but in hindsight, I probably would

[GitHub] [groovy] moonfruit commented on pull request #1339: Support useAs for @NamedVariant

2020-08-08 Thread GitBox
moonfruit commented on pull request #1339: URL: https://github.com/apache/groovy/pull/1339#issuecomment-670842874 Sorry, I don't know what are the STC errors. This is an automated message from the Apache Git Service. To

[GitHub] [groovy] moonfruit commented on pull request #1339: Support useAs for @NamedVariant

2020-08-08 Thread GitBox
moonfruit commented on pull request #1339: URL: https://github.com/apache/groovy/pull/1339#issuecomment-670842757 When define method in a class like this: ```groovy @CompileStatic class App { @NamedVariant(coerce = true) void run(int number) {