[GitHub] [groovy] danielsun1106 commented on pull request #1319: Minor tweak: create `Lookup` instance according to vm plugin

2020-08-29 Thread GitBox
danielsun1106 commented on pull request #1319: URL: https://github.com/apache/groovy/pull/1319#issuecomment-683367726 Yep, the static method "of" seems meaningless. We need instance method to apply polymorphism This is an au

[GitHub] [groovy] eric-milles commented on pull request #1319: Minor tweak: create `Lookup` instance according to vm plugin

2020-08-29 Thread GitBox
eric-milles commented on pull request #1319: URL: https://github.com/apache/groovy/pull/1319#issuecomment-683363055 What is the overall purpose of this change? Are you expecting that the way in which `Lookup` instances are created will change? At the moment, `Java8#of` is the provider.

[GitHub] [groovy] eric-milles merged pull request #1353: GROOVY-9570: collect context generics starting at innermost class/method

2020-08-29 Thread GitBox
eric-milles merged pull request #1353: URL: https://github.com/apache/groovy/pull/1353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (GROOVY-9706) Groovy 3.0.5 varargs [Static type checking] - Cannot find matching method

2020-08-29 Thread Chiang Seng Chang (Jira)
Chiang Seng Chang created GROOVY-9706: - Summary: Groovy 3.0.5 varargs [Static type checking] - Cannot find matching method Key: GROOVY-9706 URL: https://issues.apache.org/jira/browse/GROOVY-9706 P

[jira] [Commented] (GROOVY-9596) Cannot access protected field of Java superclass with --illegal-access=deny

2020-08-29 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187109#comment-17187109 ] Eric Milles commented on GROOVY-9596: - I think the solution requires: # remove {{mak

[jira] [Comment Edited] (GROOVY-9705) Groovy 3.0.5 Unit Test Class: TestNGException at Parameters.java:437

2020-08-29 Thread Chiang Seng Chang (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187074#comment-17187074 ] Chiang Seng Chang edited comment on GROOVY-9705 at 8/29/20, 6:28 PM: -

[jira] [Comment Edited] (GROOVY-9705) Groovy 3.0.5 Unit Test Class: TestNGException at Parameters.java:437

2020-08-29 Thread Chiang Seng Chang (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187074#comment-17187074 ] Chiang Seng Chang edited comment on GROOVY-9705 at 8/29/20, 6:26 PM: -

[jira] [Comment Edited] (GROOVY-9705) Groovy 3.0.5 Unit Test Class: TestNGException at Parameters.java:437

2020-08-29 Thread Chiang Seng Chang (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187074#comment-17187074 ] Chiang Seng Chang edited comment on GROOVY-9705 at 8/29/20, 6:26 PM: -

[jira] [Comment Edited] (GROOVY-9705) Groovy 3.0.5 Unit Test Class: TestNGException at Parameters.java:437

2020-08-29 Thread Chiang Seng Chang (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187074#comment-17187074 ] Chiang Seng Chang edited comment on GROOVY-9705 at 8/29/20, 6:24 PM: -

[jira] [Comment Edited] (GROOVY-9705) Groovy 3.0.5 Unit Test Class: TestNGException at Parameters.java:437

2020-08-29 Thread Chiang Seng Chang (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187074#comment-17187074 ] Chiang Seng Chang edited comment on GROOVY-9705 at 8/29/20, 6:23 PM: -

[jira] [Comment Edited] (GROOVY-9705) Groovy 3.0.5 Unit Test Class: TestNGException at Parameters.java:437

2020-08-29 Thread Chiang Seng Chang (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187074#comment-17187074 ] Chiang Seng Chang edited comment on GROOVY-9705 at 8/29/20, 6:23 PM: -

[jira] [Comment Edited] (GROOVY-9705) Groovy 3.0.5 Unit Test Class: TestNGException at Parameters.java:437

2020-08-29 Thread Chiang Seng Chang (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187074#comment-17187074 ] Chiang Seng Chang edited comment on GROOVY-9705 at 8/29/20, 6:22 PM: -

[jira] [Updated] (GROOVY-9705) Groovy 3.0.5 Unit Test Class: TestNGException at Parameters.java:437

2020-08-29 Thread Chiang Seng Chang (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chiang Seng Chang updated GROOVY-9705: -- Description: TestNG selects setMetaClass() and setProperty() as test methods. org.tes

[jira] [Updated] (GROOVY-9705) Groovy 3.0.5 Unit Test Class: TestNGException at Parameters.java:437

2020-08-29 Thread Chiang Seng Chang (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chiang Seng Chang updated GROOVY-9705: -- Description: TestNG selects setMetaClass() and setProperty() as test methods. {{org.t

[jira] [Commented] (GROOVY-9705) Groovy 3.0.5 Unit Test Class: TestNGException at Parameters.java:437

2020-08-29 Thread Chiang Seng Chang (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187074#comment-17187074 ] Chiang Seng Chang commented on GROOVY-9705: --- Found a workaround by filtering:

[GitHub] [groovy] eric-milles opened a new pull request #1357: reduce impact of makeAccessible(AccessibleObject)

2020-08-29 Thread GitBox
eric-milles opened a new pull request #1357: URL: https://github.com/apache/groovy/pull/1357 No need to create an array for single object. No need to call `setAccessible` if object is already accessible. This is an automate

[jira] [Created] (GROOVY-9705) Groovy 3.0.5 Unit Test Class: TestNGException at Parameters.java:437

2020-08-29 Thread Chiang Seng Chang (Jira)
Chiang Seng Chang created GROOVY-9705: - Summary: Groovy 3.0.5 Unit Test Class: TestNGException at Parameters.java:437 Key: GROOVY-9705 URL: https://issues.apache.org/jira/browse/GROOVY-9705 Projec