paulk-asert edited a comment on pull request #1504:
URL: https://github.com/apache/groovy/pull/1504#issuecomment-787571970
Actually, after further investigation, this is a breaking change but I
believe now exhibits the correct behavior. We'll need to document that change
and I'll create a
paulk-asert edited a comment on pull request #1504:
URL: https://github.com/apache/groovy/pull/1504#issuecomment-787571970
Actually, after further investigation, this is a breaking change but I
believe now exhibits the correct behavior. We'll need to document that change
and I'll create a
paulk-asert edited a comment on pull request #1504:
URL: https://github.com/apache/groovy/pull/1504#issuecomment-787571970
Actually, after further investigation. This is a breaking change but I
believe now exhibits the correct behavior. We'll need to document that change
and I'll create a
paulk-asert commented on pull request #1504:
URL: https://github.com/apache/groovy/pull/1504#issuecomment-787571970
Actually, let me investigate further. We have some short-circuit code for
some number types.
This is an auto
paulk-asert edited a comment on pull request #1504:
URL: https://github.com/apache/groovy/pull/1504#issuecomment-787568244
The `==` operator is deemed to have _business friendly_ behavior. Equating
`==` with `equals` is an over simplification. For comparable objects,
comparator logic is us
asfgit closed pull request #1504:
URL: https://github.com/apache/groovy/pull/1504
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
paulk-asert commented on pull request #1504:
URL: https://github.com/apache/groovy/pull/1504#issuecomment-787568244
The `==` operator is deemed to have _business friendly_ behavior. Equating
`==` with `equals` is an over simplification. For comparable objects,
comparator logic is used and
danielsun1106 commented on pull request #1504:
URL: https://github.com/apache/groovy/pull/1504#issuecomment-787554713
@paulk-asert `0.0f == -0.0f` yields `true`, is it the expected result in
Groovy? As we could see, Java yields `false`:
```java
jshell> ((Float)0.0f).equals(-0.0f)
$
[
https://issues.apache.org/jira/browse/GROOVY-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King updated GROOVY-9958:
--
Description:
Involves:
* Replace {{jcenter}} repositories in build scripts with {{mavenCentral}}
* Fin
[
https://issues.apache.org/jira/browse/GROOVY-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King updated GROOVY-9958:
--
Description:
Involves:
* Replace {{jcenter}} repositories in build scripts with {{mavenCentral}}
* Fin
tomikoskinen opened a new pull request #1506:
URL: https://github.com/apache/groovy/pull/1506
https://issues.apache.org/jira/browse/GROOVY-9797
This fixes the above bug by using `Float.equals()` which also changes `-0.0f
== 0.0f` to `false` instead of `true`. This corresponds with th
Paul King created GROOVY-9958:
-
Summary: Prepare for bintray/jcenter sunset
Key: GROOVY-9958
URL: https://issues.apache.org/jira/browse/GROOVY-9958
Project: Groovy
Issue Type: Task
Re
jonspe commented on pull request #1504:
URL: https://github.com/apache/groovy/pull/1504#issuecomment-787510417
Hmm, true. Float equality comparison should usually be done using a small
threshold epsilon value, so it should not be a big deal.
---
Exploder98 commented on pull request #1504:
URL: https://github.com/apache/groovy/pull/1504#issuecomment-787501799
@tomikoskinen
This could be expected as the [Groovy
documentation](https://docs.groovy-lang.org/docs/latest/html/documentation/#_identity_operator)
states that *"In Gr
tomikoskinen commented on pull request #1504:
URL: https://github.com/apache/groovy/pull/1504#issuecomment-787489694
This fix leads to `-0.0f == 0.0f` being `false`, which might be unwanted.
This is an automated message from
15 matches
Mail list logo
