paulk-asert commented on PR #1780:
URL: https://github.com/apache/groovy/pull/1780#issuecomment-1253206507
Let's not worry about the sync issue for now, it works fine for me on Linux,
just Windows has the problem and we can track that down as a separate activity.
--
This is an automated m
Goooler commented on PR #1780:
URL: https://github.com/apache/groovy/pull/1780#issuecomment-1253184400
Make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
paulk-asert commented on PR #1780:
URL: https://github.com/apache/groovy/pull/1780#issuecomment-1253183775
It is easy to add that back in but in the interests of repeatable setup for
all committers, I think pointing to the snapshot site would be better.
--
This is an automated message fro
daniellansun commented on PR #1784:
URL: https://github.com/apache/groovy/pull/1784#issuecomment-1253179638
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #1784:
URL: https://github.com/apache/groovy/pull/1784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
Goooler commented on PR #1780:
URL: https://github.com/apache/groovy/pull/1780#issuecomment-1253179174
Could you add `mavenLocal` back to `dependencyResolutionManagement` and try
again on you device?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
Goooler commented on PR #1780:
URL: https://github.com/apache/groovy/pull/1780#issuecomment-1253178149
Yeah, should be picked from `mavenLocal` if you already published to local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
paulk-asert commented on PR #1780:
URL: https://github.com/apache/groovy/pull/1780#issuecomment-1253176888
Also, sync'ing in IntelliJ currently gives me:
I presume we should ju
Goooler commented on PR #1780:
URL: https://github.com/apache/groovy/pull/1780#issuecomment-1253175946
Thanks, will take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
paulk-asert commented on PR #1780:
URL: https://github.com/apache/groovy/pull/1780#issuecomment-1253175366
Merged. Thanks. I spotted a few things I was going to try to fix but looks
like you found one already - I'll await for the CI checks and merge that too.
If you have some time, it wou
Goooler opened a new pull request, #1784:
URL: https://github.com/apache/groovy/pull/1784
Follow up #1780, missed renaming this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
paulk-asert merged PR #1780:
URL: https://github.com/apache/groovy/pull/1780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on code in PR #1780:
URL: https://github.com/apache/groovy/pull/1780#discussion_r976000131
##
build.gradle:
##
@@ -35,11 +35,6 @@ buildScanRecipes {
archivesBaseName = 'groovy'
-repositories {
-// todo Some repos are needed only for some configs. D
[
https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607383#comment-17607383
]
Christopher Smith commented on GROOVY-10763:
The results of "pass superclas
[
https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607380#comment-17607380
]
Eric Milles edited comment on GROOVY-10763 at 9/20/22 7:59 PM:
--
[
https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607380#comment-17607380
]
Eric Milles edited comment on GROOVY-10763 at 9/20/22 7:59 PM:
--
[
https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607380#comment-17607380
]
Eric Milles edited comment on GROOVY-10763 at 9/20/22 7:58 PM:
--
[
https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607380#comment-17607380
]
Eric Milles commented on GROOVY-10763:
--
ClassNode#isUsingGenerics is used as a qui
[
https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Smith updated GROOVY-10763:
---
Summary: Generic types not written to bytecode after
ClassNode#setSuperClass (was:
[
https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Smith updated GROOVY-10763:
---
Description:
I have an annotation that, if an annotated class has no {{{}extends{}}
[
https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Smith updated GROOVY-10763:
---
Description:
I have an annotation that, if an annotated class has no {{{}extends{}}
[
https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Smith updated GROOVY-10763:
---
Description:
I have an annotation that, if an annotated class has no {{{}extends{}}
[
https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Smith updated GROOVY-10763:
---
Description:
I have an annotation that, if an annotated class has no {{{}extends{}}
[
https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Smith updated GROOVY-10763:
---
Description:
I have an annotation that, if an annotated class has no {{{}extends{}}
[
https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Smith updated GROOVY-10763:
---
Description:
I have an annotation that, if an annotated class has no {{{}extends{}}
[
https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Smith updated GROOVY-10763:
---
Description:
I have an annotation that, if an annotated class has no {{{}extends{}}
[
https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Smith updated GROOVY-10763:
---
Description:
I have an annotation that, if an annotated class has no {{extends}}, s
Christopher Smith created GROOVY-10763:
--
Summary: Generic types are cleared when a ClassNode is assigned as
a superClass
Key: GROOVY-10763
URL: https://issues.apache.org/jira/browse/GROOVY-10763
[
https://issues.apache.org/jira/browse/GROOVY-10756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607322#comment-17607322
]
Eric Milles commented on GROOVY-10756:
--
https://github.com/apache/groovy/commit/ce
[
https://issues.apache.org/jira/browse/GROOVY-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Yates closed GROOVY-10762.
--
Resolution: Not A Bug
> Generated getters for wrapper type Boolean is missing isXXX method
>
[
https://issues.apache.org/jira/browse/GROOVY-10756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607320#comment-17607320
]
J. Brébec commented on GROOVY-10756:
Thank for the suggestion ^^
However these err
[
https://issues.apache.org/jira/browse/GROOVY-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607319#comment-17607319
]
Eric Milles commented on GROOVY-10758:
--
There are lots of examples in the codebase
[
https://issues.apache.org/jira/browse/GROOVY-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607300#comment-17607300
]
Eric Milles edited comment on GROOVY-10758 at 9/20/22 5:03 PM:
--
[
https://issues.apache.org/jira/browse/GROOVY-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607316#comment-17607316
]
Christopher Smith edited comment on GROOVY-10758 at 9/20/22 5:00 PM:
[
https://issues.apache.org/jira/browse/GROOVY-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607316#comment-17607316
]
Christopher Smith commented on GROOVY-10758:
Understood, and I know how to
[
https://issues.apache.org/jira/browse/GROOVY-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607315#comment-17607315
]
Tim Yates commented on GROOVY-10762:
Thanks Eric, I was looking in to upgrading Mic
[
https://issues.apache.org/jira/browse/GROOVY-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607315#comment-17607315
]
Tim Yates edited comment on GROOVY-10762 at 9/20/22 4:59 PM:
[
https://issues.apache.org/jira/browse/GROOVY-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607302#comment-17607302
]
Eric Milles edited comment on GROOVY-10762 at 9/20/22 4:42 PM:
--
[
https://issues.apache.org/jira/browse/GROOVY-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607302#comment-17607302
]
Eric Milles commented on GROOVY-10762:
--
This is an intended change for Groovy 4.
[
https://issues.apache.org/jira/browse/GROOVY-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Milles reassigned GROOVY-10762:
Assignee: Eric Milles
> Generated getters for wrapper type Boolean is missing isXXX meth
[
https://issues.apache.org/jira/browse/GROOVY-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607300#comment-17607300
]
Eric Milles commented on GROOVY-10758:
--
You can do the long form of creating a new
[
https://issues.apache.org/jira/browse/GROOVY-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Yates updated GROOVY-10762:
---
Description:
Inspecting the generated class for the following with 4.0.5
{code:java}
class Config
{
[
https://issues.apache.org/jira/browse/GROOVY-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607281#comment-17607281
]
Christopher Smith commented on GROOVY-10758:
The {{getPlainNodeReference}}
[
https://issues.apache.org/jira/browse/GROOVY-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Yates updated GROOVY-10762:
---
Description:
Inspecting the generated class for the following with 4.0.5
{{class Config}}
{
{{
[
https://issues.apache.org/jira/browse/GROOVY-10761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607278#comment-17607278
]
Christopher Smith commented on GROOVY-10761:
I have it working now; the cod
Tim Yates created GROOVY-10762:
--
Summary: Generated getters for wrapper type Boolean is missing
isXXX method
Key: GROOVY-10762
URL: https://issues.apache.org/jira/browse/GROOVY-10762
Project: Groovy
[
https://issues.apache.org/jira/browse/GROOVY-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607276#comment-17607276
]
Christopher Smith commented on GROOVY-10760:
Oddly enough, this code _in an
[
https://issues.apache.org/jira/browse/GROOVY-10756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607255#comment-17607255
]
Eric Milles commented on GROOVY-10756:
--
Until this is fixed in Groovy 3.0.14, you
[
https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607230#comment-17607230
]
Eric Milles commented on GROOVY-10682:
--
Okay, looks like we need to do something i
[
https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Milles reassigned GROOVY-10682:
Assignee: Eric Milles
> Provide eachWithIndex for primitive arrays
> ---
[
https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607223#comment-17607223
]
Felix Schnabel commented on GROOVY-10682:
-
I don't think I can set myself as th
[
https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607219#comment-17607219
]
Eric Milles commented on GROOVY-10682:
--
You can assign the issue to yourself and m
Goooler commented on PR #1780:
URL: https://github.com/apache/groovy/pull/1780#issuecomment-1252356567
Just revert 969d8b24ffaa9e1ca2fc226979a7385f1057e70a now, maybe we should do
it in a follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
[
https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607196#comment-17607196
]
Felix Schnabel commented on GROOVY-10682:
-
I would like to work on this issue.
Goooler commented on code in PR #1780:
URL: https://github.com/apache/groovy/pull/1780#discussion_r975349958
##
settings.gradle:
##
@@ -38,6 +40,14 @@ gradleEnterprise {
}
}
+dependencyResolutionManagement {
+repositories {
+mavenCentral()
+maven{
ur
[
https://issues.apache.org/jira/browse/GROOVY-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607187#comment-17607187
]
Eric Milles commented on GROOVY-10758:
--
To "create a new ClassNode referring to th
[
https://issues.apache.org/jira/browse/GROOVY-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607183#comment-17607183
]
Eric Milles commented on GROOVY-10760:
--
"addWarning" is not in common use. In ord
[
https://issues.apache.org/jira/browse/GROOVY-10761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606857#comment-17606857
]
Eric Milles edited comment on GROOVY-10761 at 9/20/22 1:06 PM:
--
[
https://issues.apache.org/jira/browse/GROOVY-10761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606857#comment-17606857
]
Eric Milles edited comment on GROOVY-10761 at 9/20/22 1:06 PM:
--
[
https://issues.apache.org/jira/browse/GROOVY-10761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606857#comment-17606857
]
Eric Milles edited comment on GROOVY-10761 at 9/20/22 1:04 PM:
--
[
https://issues.apache.org/jira/browse/GROOVY-10761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606857#comment-17606857
]
Eric Milles edited comment on GROOVY-10761 at 9/20/22 1:04 PM:
--
[
https://issues.apache.org/jira/browse/GROOVY-10761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606857#comment-17606857
]
Eric Milles edited comment on GROOVY-10761 at 9/20/22 1:03 PM:
--
[
https://issues.apache.org/jira/browse/GROOVY-10761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606857#comment-17606857
]
Eric Milles edited comment on GROOVY-10761 at 9/20/22 1:03 PM:
--
Goooler commented on code in PR #1780:
URL: https://github.com/apache/groovy/pull/1780#discussion_r975335172
##
settings.gradle:
##
@@ -38,6 +40,14 @@ gradleEnterprise {
}
}
+dependencyResolutionManagement {
+repositories {
+mavenCentral()
+maven{
ur
melix commented on code in PR #1780:
URL: https://github.com/apache/groovy/pull/1780#discussion_r975318492
##
settings.gradle:
##
@@ -38,6 +40,14 @@ gradleEnterprise {
}
}
+dependencyResolutionManagement {
+repositories {
+mavenCentral()
+maven{
url(
paulk-asert commented on PR #1780:
URL: https://github.com/apache/groovy/pull/1780#issuecomment-1252297069
It does mostly look good (apart from an import or two which popped above the
license header which are certainly fixable later). I just wanted to check it
doesn't cause issues for the r
[
https://issues.apache.org/jira/browse/GROOVY-10756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606996#comment-17606996
]
J. Brébec edited comment on GROOVY-10756 at 9/20/22 8:45 AM:
[
https://issues.apache.org/jira/browse/GROOVY-10756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606996#comment-17606996
]
J. Brébec commented on GROOVY-10756:
With 3.13, the previous snippet works. However
68 matches
Mail list logo
