[jira] [Commented] (GROOVY-10682) Provide eachWithIndex for primitive arrays

2022-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609724#comment-17609724 ] ASF GitHub Bot commented on GROOVY-10682: - paulk-asert commented on code in PR

[GitHub] [groovy] paulk-asert commented on a diff in pull request #1785: GROOVY-10682: Provide eachWithIndex for primitive arrays

2022-09-26 Thread GitBox
paulk-asert commented on code in PR #1785: URL: https://github.com/apache/groovy/pull/1785#discussion_r980582585 ## src/test/groovy/transform/stc/DefaultGroovyMethodsSTCTest.groovy: ## @@ -37,6 +37,20 @@ class DefaultGroovyMethodsSTCTest extends StaticTypeCheckingTestCase {

[jira] [Commented] (GROOVY-10682) Provide eachWithIndex for primitive arrays

2022-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609722#comment-17609722 ] ASF GitHub Bot commented on GROOVY-10682: - paulk-asert commented on code in PR

[GitHub] [groovy] paulk-asert commented on a diff in pull request #1785: GROOVY-10682: Provide eachWithIndex for primitive arrays

2022-09-26 Thread GitBox
paulk-asert commented on code in PR #1785: URL: https://github.com/apache/groovy/pull/1785#discussion_r980526924 ## src/main/java/org/codehaus/groovy/runtime/ArrayGroovyMethods.java: ## @@ -0,0 +1,85 @@ +package org.codehaus.groovy.runtime; + +import groovy.lang.Closure; +import

[jira] [Commented] (GROOVY-10682) Provide eachWithIndex for primitive arrays

2022-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609692#comment-17609692 ] ASF GitHub Bot commented on GROOVY-10682: - paulk-asert commented on code in PR

[GitHub] [groovy] paulk-asert commented on a diff in pull request #1785: GROOVY-10682: Provide eachWithIndex for primitive arrays

2022-09-26 Thread GitBox
paulk-asert commented on code in PR #1785: URL: https://github.com/apache/groovy/pull/1785#discussion_r980526924 ## src/main/java/org/codehaus/groovy/runtime/ArrayGroovyMethods.java: ## @@ -0,0 +1,85 @@ +package org.codehaus.groovy.runtime; + +import groovy.lang.Closure; +import

[jira] [Commented] (GROOVY-10768) Macro class should be able to resolve macro-method arguments

2022-09-26 Thread Christopher Smith (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609682#comment-17609682 ] Christopher Smith commented on GROOVY-10768: I'll investigate. Following th

[GitHub] [groovy] chrylis commented on pull request #1786: Improve generic-ClassNode compiler error message

2022-09-26 Thread GitBox
chrylis commented on PR #1786: URL: https://github.com/apache/groovy/pull/1786#issuecomment-1258626704 @paulk-asert That was what I'd originally tried, but (perhaps due to some other interactions; see GROOVY-10763) it does not resolve the error. Per @eric-milles, the two approaches I outlin

[jira] [Commented] (GROOVY-10682) Provide eachWithIndex for primitive arrays

2022-09-26 Thread Felix Schnabel (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609668#comment-17609668 ] Felix Schnabel commented on GROOVY-10682: - I searched through all the methods o

[jira] [Commented] (GROOVY-10682) Provide eachWithIndex for primitive arrays

2022-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609613#comment-17609613 ] ASF GitHub Bot commented on GROOVY-10682: - sonatype-lift[bot] commented on PR #

[GitHub] [groovy] sonatype-lift[bot] commented on pull request #1785: GROOVY-10682: Provide eachWithIndex for primitive arrays

2022-09-26 Thread GitBox
sonatype-lift[bot] commented on PR #1785: URL: https://github.com/apache/groovy/pull/1785#issuecomment-1258399808 :warning: **170 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/groovy/01GDXARFWERA7TXWZG1E

[jira] [Commented] (GROOVY-10682) Provide eachWithIndex for primitive arrays

2022-09-26 Thread Felix Schnabel (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609609#comment-17609609 ] Felix Schnabel commented on GROOVY-10682: - I squashed the commits and force pus

[jira] [Commented] (GROOVY-10682) Provide eachWithIndex for primitive arrays

2022-09-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609566#comment-17609566 ] Eric Milles commented on GROOVY-10682: -- We could choose to use {{ArrayGroovyMethod

[jira] [Comment Edited] (GROOVY-10682) Provide eachWithIndex for primitive arrays

2022-09-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609553#comment-17609553 ] Eric Milles edited comment on GROOVY-10682 at 9/26/22 3:55 PM: --

[jira] [Comment Edited] (GROOVY-10682) Provide eachWithIndex for primitive arrays

2022-09-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609558#comment-17609558 ] Eric Milles edited comment on GROOVY-10682 at 9/26/22 3:54 PM: --

[jira] [Commented] (GROOVY-10682) Provide eachWithIndex for primitive arrays

2022-09-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609558#comment-17609558 ] Eric Milles commented on GROOVY-10682: -- For each deprecated method, you can replac

[jira] [Commented] (GROOVY-10682) Provide eachWithIndex for primitive arrays

2022-09-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609553#comment-17609553 ] Eric Milles commented on GROOVY-10682: -- No, please leave {{each}} and {{eachWithIn

[jira] [Assigned] (GROOVY-10758) Improve error message when using generic ClassNodes in ASTT

2022-09-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-10758: Assignee: Eric Milles > Improve error message when using generic ClassNodes in ASTT > --

[jira] [Commented] (GROOVY-10758) Improve error message when using generic ClassNodes in ASTT

2022-09-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609547#comment-17609547 ] Eric Milles commented on GROOVY-10758: -- https://github.com/apache/groovy/pull/1786

[jira] [Resolved] (GROOVY-10763) ClassNode setSuperClass and setInterfaces should update usingGenerics

2022-09-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles resolved GROOVY-10763. -- Fix Version/s: 5.0.0-alpha-1 Resolution: Fixed https://github.com/apache/groovy/commit

[jira] [Commented] (GROOVY-10769) Invalid code generated after instanceof test

2022-09-26 Thread Szczepan Kuzniarz (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609515#comment-17609515 ] Szczepan Kuzniarz commented on GROOVY-10769: {color:#0747a6}> Can you try w

[jira] [Updated] (GROOVY-10757) Regression from 2.5.16+: ClassCastException at runtime

2022-09-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-10757: - Fix Version/s: 4.0.6 > Regression from 2.5.16+: ClassCastException at runtime > ---

[jira] [Updated] (GROOVY-10757) Regression from 2.5.16+: ClassCastException at runtime

2022-09-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-10757: - Fix Version/s: 3.0.14 > Regression from 2.5.16+: ClassCastException at runtime > --

[jira] [Resolved] (GROOVY-10757) Regression from 2.5.16+: ClassCastException at runtime

2022-09-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles resolved GROOVY-10757. -- Fix Version/s: 2.5.19 Resolution: Fixed > Regression from 2.5.16+: ClassCastException

[jira] [Commented] (GROOVY-10769) Invalid code generated after instanceof test

2022-09-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609496#comment-17609496 ] Eric Milles commented on GROOVY-10769: -- Can you try with 3.0.14-SNAPSHOT? Also, y

[jira] [Resolved] (GROOVY-10769) Invalid code generated after instanceof test

2022-09-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles resolved GROOVY-10769. -- Resolution: Duplicate > Invalid code generated after instanceof test > --

[jira] [Updated] (GROOVY-10769) Invalid code generated after instanceof test

2022-09-26 Thread Szczepan Kuzniarz (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szczepan Kuzniarz updated GROOVY-10769: --- Description: Code similar to (all classes have @CompileStatic annotation): {code:ja

[jira] [Created] (GROOVY-10769) Invalid code generated after instanceof test

2022-09-26 Thread Szczepan Kuzniarz (Jira)
Szczepan Kuzniarz created GROOVY-10769: -- Summary: Invalid code generated after instanceof test Key: GROOVY-10769 URL: https://issues.apache.org/jira/browse/GROOVY-10769 Project: Groovy I

[jira] [Commented] (GROOVY-10757) Regression from 2.5.16+: ClassCastException at runtime

2022-09-26 Thread Mauro Molinari (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609491#comment-17609491 ] Mauro Molinari commented on GROOVY-10757: - Yes Eric, with the original code and

[jira] [Commented] (GROOVY-10757) Regression from 2.5.16+: ClassCastException at runtime

2022-09-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609461#comment-17609461 ] Eric Milles commented on GROOVY-10757: -- Can you retest with original code and late

[jira] [Commented] (GROOVY-10757) Regression from 2.5.16+: ClassCastException at runtime

2022-09-26 Thread Mauro Molinari (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609416#comment-17609416 ] Mauro Molinari commented on GROOVY-10757: - {quote}Can you try replacing propert

[jira] [Comment Edited] (GROOVY-10757) Regression from 2.5.16+: ClassCastException at runtime

2022-09-26 Thread Mauro Molinari (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609416#comment-17609416 ] Mauro Molinari edited comment on GROOVY-10757 at 9/26/22 10:04 AM: --