[GitHub] [groovy] paulk-asert commented on pull request #1813: Cleanup build-logic

2022-10-25 Thread GitBox
paulk-asert commented on PR #1813: URL: https://github.com/apache/groovy/pull/1813#issuecomment-1291231063 Merged, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [groovy] paulk-asert commented on a diff in pull request #1813: Cleanup build-logic

2022-10-25 Thread GitBox
paulk-asert commented on code in PR #1813: URL: https://github.com/apache/groovy/pull/1813#discussion_r1005044467 ## build-logic/src/main/groovy/org/apache/groovy/gradle/ReleaseInfoGenerator.groovy: ## @@ -69,7 +69,7 @@ class ReleaseInfoGenerator extends DefaultTask { # "Licen

[GitHub] [groovy] paulk-asert merged pull request #1813: Cleanup build-logic

2022-10-25 Thread GitBox
paulk-asert merged PR #1813: URL: https://github.com/apache/groovy/pull/1813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] jonnybot0 commented on pull request #1814: Bugfix/groovy 9541 respect parent classloader

2022-10-25 Thread GitBox
jonnybot0 commented on PR #1814: URL: https://github.com/apache/groovy/pull/1814#issuecomment-1291223195 > Have you searched for each use of evaluateExpression or is there a subset that was handled? Yes, this is all the usages in the source code I could find. > The cast failur

[GitHub] [groovy] eric-milles commented on pull request #1814: Bugfix/groovy 9541 respect parent classloader

2022-10-25 Thread GitBox
eric-milles commented on PR #1814: URL: https://github.com/apache/groovy/pull/1814#issuecomment-1291198310 The cast failure implies that you used a different class loader to create the instance of `AnnotationCollectorMode` than the loader the compiler used to load that class. The transform

[GitHub] [groovy] eric-milles commented on pull request #1814: Bugfix/groovy 9541 respect parent classloader

2022-10-25 Thread GitBox
eric-milles commented on PR #1814: URL: https://github.com/apache/groovy/pull/1814#issuecomment-1291195299 Could you recreate the PR against the `master` branch? That is where we would first evaluate it and then we can cherry-pick it back to `4_0_X` and `3_0_X` for you if risk is minimal.

[GitHub] [groovy] sonatype-lift[bot] commented on pull request #1814: Bugfix/groovy 9541 respect parent classloader

2022-10-25 Thread GitBox
sonatype-lift[bot] commented on PR #1814: URL: https://github.com/apache/groovy/pull/1814#issuecomment-1291168193 :warning: **185 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/groovy/01GG8GA9EV124R0V0Y66

[jira] [Commented] (GROOVY-9541) Compiling statically using GroovyClassLoader does not always respect the configured parent ClassLoader

2022-10-25 Thread jonny (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624051#comment-17624051 ] jonny commented on GROOVY-9541: --- I've opened a PR at https://github.com/apache/groovy/pull

[GitHub] [groovy] jonnybot0 opened a new pull request, #1814: Bugfix/groovy 9541 respect parent classloader

2022-10-25 Thread GitBox
jonnybot0 opened a new pull request, #1814: URL: https://github.com/apache/groovy/pull/1814 Helpful background may be found in the comments of https://issues.apache.org/jira/browse/GROOVY-9541. As @eric-milles noted there, we may need to do a more careful consideration of each consum

[jira] [Comment Edited] (GROOVY-10796) TupleConstructor and map-ish constructor style don't mix

2022-10-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624023#comment-17624023 ] Eric Milles edited comment on GROOVY-10796 at 10/25/22 9:03 PM: -

[jira] [Commented] (GROOVY-10796) TupleConstructor and map-ish constructor style don't mix

2022-10-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624023#comment-17624023 ] Eric Milles commented on GROOVY-10796: -- In your original post, if you subtract "(d

[jira] [Comment Edited] (GROOVY-10792) Declared generic parameter on method not transferred to Closure

2022-10-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624019#comment-17624019 ] Eric Milles edited comment on GROOVY-10792 at 10/25/22 8:04 PM: -

[jira] [Commented] (GROOVY-10792) Declared generic parameter on method not transferred to Closure

2022-10-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624019#comment-17624019 ] Eric Milles commented on GROOVY-10792: -- {{ClosureWriter}} does this, so it require

[jira] [Comment Edited] (GROOVY-10792) Declared generic parameter on method not transferred to Closure

2022-10-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624008#comment-17624008 ] Eric Milles edited comment on GROOVY-10792 at 10/25/22 7:51 PM: -

[jira] [Commented] (GROOVY-10792) Declared generic parameter on method not transferred to Closure

2022-10-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624008#comment-17624008 ] Eric Milles commented on GROOVY-10792: -- Even {{Closure}} fails: {code:groovy} void

[jira] [Assigned] (GROOVY-10792) Declared generic parameter on method not transferred to Closure

2022-10-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-10792: Assignee: Eric Milles > Declared generic parameter on method not transferred to Closure

[jira] [Commented] (GROOVY-10796) TupleConstructor and map-ish constructor style don't mix

2022-10-25 Thread Christopher Smith (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624005#comment-17624005 ] Christopher Smith commented on GROOVY-10796: I think the (bad-)surprising p

[jira] [Commented] (GROOVY-10796) TupleConstructor and map-ish constructor style don't mix

2022-10-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624003#comment-17624003 ] Eric Milles commented on GROOVY-10796: -- If you use {{@TupleConstructor(defaults=fa

[jira] [Resolved] (GROOVY-10795) Regression: Returning List/Map created via literal as typed generic

2022-10-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles resolved GROOVY-10795. -- Resolution: Information Provided > Regression: Returning List/Map created via literal as type

[jira] [Commented] (GROOVY-10795) Regression: Returning List/Map created via literal as typed generic

2022-10-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623964#comment-17623964 ] Eric Milles commented on GROOVY-10795: -- As the type-checker's generics handling is

[jira] [Created] (GROOVY-10796) TupleConstructor and map-ish constructor style don't mix

2022-10-25 Thread Christopher Smith (Jira)
Christopher Smith created GROOVY-10796: -- Summary: TupleConstructor and map-ish constructor style don't mix Key: GROOVY-10796 URL: https://issues.apache.org/jira/browse/GROOVY-10796 Project: Groovy

[jira] [Updated] (GROOVY-10791) STC doesn't find method reference on superclass

2022-10-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-10791: - Fix Version/s: 3.0.14 > STC doesn't find method reference on superclass > -

[jira] [Resolved] (GROOVY-10791) STC doesn't find method reference on superclass

2022-10-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles resolved GROOVY-10791. -- Fix Version/s: 4.0.7 Resolution: Fixed https://github.com/apache/groovy/commit/f579fa3

[jira] [Comment Edited] (GROOVY-9541) Compiling statically using GroovyClassLoader does not always respect the configured parent ClassLoader

2022-10-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623826#comment-17623826 ] Eric Milles edited comment on GROOVY-9541 at 10/25/22 1:24 PM: ---

[jira] [Commented] (GROOVY-9541) Compiling statically using GroovyClassLoader does not always respect the configured parent ClassLoader

2022-10-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623826#comment-17623826 ] Eric Milles commented on GROOVY-9541: - Each location that it is used must be conside

[jira] [Commented] (GROOVY-9541) Compiling statically using GroovyClassLoader does not always respect the configured parent ClassLoader

2022-10-25 Thread Marcin Erdmann (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623668#comment-17623668 ] Marcin Erdmann commented on GROOVY-9541: I get that {{evaluateExpression}} was n